search

Expensify / App

Welcome to New Expensify: a complete re-imagination of financial collaboration, centered around chat. Help us build the next generation of Expensify by sharing feedback and contributing to the code.
https://new.expensify.com
MIT License
3.33k stars 2.76k forks source link

[$250] android - Chat - In room chat, edit comment shows suggestion list #47661

Open lanitochka17 opened 3 weeks ago

lanitochka17 commented 3 weeks ago

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

Version Number: 9.0.22 Reproducible in staging?: Y Reproducible in production?: Y If this was caught during regression testing, add the test name, ID and link from TestRail: https://expensify.testrail.io/index.php?/tests/view/4872065 Issue reported by: Applause - Internal Team

Action Performed:

  1. Launch app
  2. Tap fab -- start chat -- room
  3. Create a room
  4. Enter @jaihanumanblig@gmail.com
  5. Send the message
  6. In whishper message, tap invite
  7. Long press the message sent in step 4, and select edit comment

Expected Result:

In room chat, edit comment must not show suggestion list

Actual Result:

In room chat, edit comment shows suggestion list

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

Screenshots/Videos

Add any screenshot/video evidence

https://github.com/user-attachments/assets/4bfe1dd2-8bfe-4fac-87f6-0491a589e4f6

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~016746ee733b120550
  • Upwork Job ID: 1828406003775672724
  • Last Price Increase: 2024-09-03
  • Automatic offers:
    • mkhutornyi | Reviewer | 103882312
Issue OwnerCurrent Issue Owner: @mkhutornyi
melvin-bot[bot] commented 3 weeks ago

Triggered auto assignment to @miljakljajic (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

lanitochka17 commented 3 weeks ago

@miljakljajic FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

lanitochka17 commented 3 weeks ago

We think that this bug might be related to #vip-vsp

melvin-bot[bot] commented 3 weeks ago

@miljakljajic Whoops! This issue is 2 days overdue. Let's get this updated quick!

melvin-bot[bot] commented 2 weeks ago

Job added to Upwork: https://www.upwork.com/jobs/~016746ee733b120550

melvin-bot[bot] commented 2 weeks ago

Triggered auto assignment to Contributor-plus team member for initial proposal review - @mkhutornyi (External)

mkhutornyi commented 2 weeks ago

Awaiting proposals

kaushiktd commented 1 week ago

@mkhutornyi when long press on any message, you can see only three option like: Mark as read, Copy to clipboard and copy link. There is no option to edit the message.

melvin-bot[bot] commented 1 week ago

@miljakljajic @mkhutornyi this issue was created 2 weeks ago. Are we close to approving a proposal? If not, what's blocking us from getting this issue assigned? Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!

mkhutornyi commented 1 week ago

Still awaiting proposals

melvin-bot[bot] commented 1 week ago

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

JKobrynski commented 6 days ago

Hi, I'm Julian from Callstack - expert agency - and I would like to work on this issue.

miljakljajic commented 6 days ago

Thank you! I'll assign you

melvin-bot[bot] commented 6 days ago

📣 @mkhutornyi 🎉 An offer has been automatically sent to your Upwork account for the Reviewer role 🎉 Thanks for contributing to the Expensify app!

Offer link Upwork job

JKobrynski commented 5 days ago

Proposal

Please re-state the problem that we are trying to solve in this issue.

The suggestion list is shown when editing a comment.

What is the root cause of that problem?

The reason is that <Suggestions /> component is rendered in <ReportActionItemMessageEdit.tsx />.

What changes do you think we should make in order to solve the problem?

Remove <Suggestions /> component from <ReportActionItemMessageEdit.tsx /> along with every param/function that is unnecessary after removing it.

What alternative solutions did you explore? (Optional)

None.

mkhutornyi commented 5 days ago

@JKobrynski we added that new feature in https://github.com/Expensify/App/pull/44720. I think the bug here is that message in edit composer is automatically selected after clicking Edit comment from context menu. The root cause should explain why this happens only on android.