Closed lanitochka17 closed 2 weeks ago
Triggered auto assignment to @JmillsExpensify (Bug
), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.
@JmillsExpensify FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors
Sign in – New tab with video opens when click on download video in Welcome to Expensify modal
The url for onboarding modal is https://d2k5nsl2zxldvw.cloudfront.net/videos/intro-1280.mp4
and due to this, the condition below !isApiUrl && !isAttachmentUrl && !isSageUrl)
becomes true and a new tab opens.
https://github.com/Expensify/App/blob/7b4605a9bf642bdc54b70ede88e19e6d8193198b/src/libs/fileDownload/DownloadUtils.ts#L34-L42
const isCloudFrontURL = url.includes(CONST.CLOUDFRONT_URL);
!isCloudFrontURL
.
if (
// We have two file download cases that we should allow: 1. downloading attachments 2. downloading Expensify package for Sage Intacct
shouldOpenExternalLink ||
(!isApiUrl && !isAttachmentUrl && !isSageUrl && !isCloudFrontURL)
) {
@JmillsExpensify Whoops! This issue is 2 days overdue. Let's get this updated quick!
@JmillsExpensify 6 days overdue. This is scarier than being forced to listen to Vogon poetry!
We're deprecating the video, so I'm going to close this report.
If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
Version Number: 9.0.22-5 Reproducible in staging?: Y Reproducible in production?: Y If this was caught during regression testing, add the test name, ID and link from TestRail: https://expensify.testrail.io/index.php?/tests/view/4871545 Email or phone of affected tester (no customers): applausetester+jp_319824@applause.expensifail.com Issue reported by: Applause - Internal Team
Action Performed:
Expected Result:
Video is downloaded
Actual Result:
New tab with video opens
Workaround:
Unknown
Platforms:
Which of our officially supported platforms is this issue occurring on?
Screenshots/Videos
Add any screenshot/video evidence
https://github.com/user-attachments/assets/d24229cf-3a34-4e05-8115-0c81bd0d5f44
View all open jobs on GitHub