search

Expensify / App

Welcome to New Expensify: a complete re-imagination of financial collaboration, centered around chat. Help us build the next generation of Expensify by sharing feedback and contributing to the code.
https://new.expensify.com
MIT License
3.32k stars 2.75k forks source link

[HybridApp] Open app called back to back on bad wifi network and app never loads #47667

Closed m-natarajan closed 22 hours ago

m-natarajan commented 3 weeks ago

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

Version Number: Reproducible in staging?: Needs Reproduction Reproducible in production?: If this was caught during regression testing, add the test name, ID and link from TestRail: Email or phone of affected tester (no customers): Logs: https://stackoverflow.com/c/expensify/questions/4856 Expensify/Expensify Issue URL: Issue reported by: @quinthar Slack conversation: https://expensify.slack.com/archives/C05LX9D6E07/p1724045384113909

Action Performed:

  1. Be on a bad WiFi network
  2. Open the app

Expected Result:

App loads quickly

Actual Result:

Hybrid app never loads and not remembering the session/state and triggering OpenApp

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

Screenshots/Videos

https://github.com/user-attachments/assets/2d4af855-7c2f-4522-8fe8-833b5ed22690

Add any screenshot/video evidence

View all open jobs on GitHub

melvin-bot[bot] commented 3 weeks ago

Current assignee @puneetlath is eligible for the Bug assigner, not assigning anyone new.

melvin-bot[bot] commented 3 weeks ago

Current assignee @puneetlath is eligible for the AutoAssignerNewDotQuality assigner, not assigning anyone new.

MelvinBot commented 3 weeks ago

This has been labelled "Needs Reproduction". Follow the steps here: https://stackoverflowteams.com/c/expensify/questions/16989

mateuuszzzzz commented 3 weeks ago

Hi! I'll focus on this issue

melvin-bot[bot] commented 2 weeks ago

@puneetlath, @mateuuszzzzz Whoops! This issue is 2 days overdue. Let's get this updated quick!

mateuuszzzzz commented 2 weeks ago

I should finish HybridApp refactor today and I'll investigate this problem more thoroughly 👍

muttmuure commented 2 weeks ago

Great!

mateuuszzzzz commented 2 weeks ago

I believe our refactor should address this issue as well by removing some API calls that were previously made on OldDot before transitioning to NewDot. I’ll be able to provide more details tomorrow after testing the app with the network conditioner.

mateuuszzzzz commented 1 week ago

So it looks like our refactor fixes this. We have some minor issues related to refactor, but we're addressing them.

melvin-bot[bot] commented 1 week ago

@puneetlath @mateuuszzzzz this issue was created 2 weeks ago. Are we close to a solution? Let's make sure we're treating this as a top priority. Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!

muttmuure commented 1 week ago

@mateuuszzzzz how is this coming along?

melvin-bot[bot] commented 1 week ago

@puneetlath, @mateuuszzzzz Eep! 4 days overdue now. Issues have feelings too...

puneetlath commented 1 week ago

@mateuuszzzzz just checking in. How's this going?

melvin-bot[bot] commented 1 day ago

@puneetlath, @mateuuszzzzz Huh... This is 4 days overdue. Who can take care of this?

mateuuszzzzz commented 22 hours ago

Hi! Sorry for the delay I'm OOO.

Refactor that we've merged recently fixed this problem as well

trjExpensify commented 22 hours ago

Great stuff, let's close it out.