[$250] [Advanced Approval Workflows] Should display empty state when the member list is empty

Expensify / App

Welcome to New Expensify: a complete re-imagination of financial collaboration, centered around chat. Help us build the next generation of Expensify by sharing feedback and contributing to the code.

https://new.expensify.com

MIT License

3.34k stars 2.77k forks source link

[$250] [Advanced Approval Workflows] Should display empty state when the member list is empty #47700

Open dylanexpensify opened 4 weeks ago

dylanexpensify commented 4 weeks ago

Coming from this project, we have this follow-up polish issue we need to complete where we should display an empty state when the member list is empty. More details here.

Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~01040daf30f3152600
Upwork Job ID: 1825862440438169741
Last Price Increase: 2024-08-20

Issue Owner

Current Issue Owner: @

dylanexpensify commented 4 weeks ago

cc @blazejkustra

blazejkustra commented 4 weeks ago

Hey! I’m Błażej Kustra from Software Mansion, an expert agency, and I’d like to work on this issue!

melvin-bot[bot] commented 4 weeks ago

Job added to Upwork: https://www.upwork.com/jobs/~01040daf30f3152600

melvin-bot[bot] commented 4 weeks ago

Current assignee @DylanDylann is eligible for the External assigner, not assigning anyone new.

dylanexpensify commented 4 weeks ago

Hi @blazejkustra! It's all yours!

blazejkustra commented 4 weeks ago

Let's agree with one approach for a case when member list is empty @Expensify/design @JmillsExpensify.

https://github.com/user-attachments/assets/dac271bf-5da7-4d76-b643-72dec96334a5

I like the idea from @dannymcclain here. But, let's settle on a particular message to display.

DylanDylann commented 3 weeks ago

In this comment, @dannymcclain suggested: "Hey, all your members are part of approval workflows already! Right on. Everyone is getting approved. Way to go."

@blazejkustra I think we can confirm with the design team one more time after the implementation on the PR phase

JmillsExpensify commented 3 weeks ago

Yes, I think that should work. For clarity, we're also not going to show a search input in this case correct? Basically since there is nothing to search for.

As for the message, @jamesdeanexpensify you might want to weigh in on the copy. I think we could probably tweak Danny's suggestion a bit, e.g. "All workspace members belong to an approval workflow. Nice work, everyone is accounted for."

jamesdeanexpensify commented 3 weeks ago

Maybe switching the order a bit:

Nice job! All workspace members belong to an approval workflow.

JmillsExpensify commented 3 weeks ago

Love it.

blazejkustra commented 3 weeks ago

All yours @DylanDylann

https://github.com/Expensify/App/pull/47848

melvin-bot[bot] commented 2 weeks ago

Triggered auto assignment to @jasperhuangg, see https://stackoverflow.com/c/expensify/questions/7972 for more details.

melvin-bot[bot] commented 1 day ago

This issue has not been updated in over 15 days. @jasperhuangg, @blazejkustra, @DylanDylann eroding to Monthly issue.

P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do!