[HOLD for payment 2024-08-29] Update link to fork for react-native-qrcode-svg - Githubissues

Expensify / App

Welcome to New Expensify: a complete re-imagination of financial collaboration, centered around chat. Help us build the next generation of Expensify by sharing feedback and contributing to the code.

https://new.expensify.com

MIT License

3.35k stars 2.78k forks source link

[HOLD for payment 2024-08-29] Update link to fork for react-native-qrcode-svg #47713

Closed grgia closed 4 weeks ago

grgia commented 1 month ago

Part of https://github.com/Expensify/App/issues/47711

Update this line to point to Expensify/react-native-qrcode-svg-old

Issue Owner

Current Issue Owner: @zanyrenney

melvin-bot[bot] commented 1 month ago

Triggered auto assignment to @zanyrenney (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

melvin-bot[bot] commented 1 month ago

Reviewing label has been removed, please complete the "BugZero Checklist".

melvin-bot[bot] commented 1 month ago

The solution for this issue has been :rocket: deployed to production :rocket: in version 9.0.23-0 and is now subject to a 7-day regression period :calendar:. Here is the list of pull requests that resolve this issue:

https://github.com/Expensify/App/pull/47715

If no regressions arise, payment will be issued on 2024-08-29. :confetti_ball:

melvin-bot[bot] commented 1 month ago

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

[ ] [@grgia] The PR that introduced the bug has been identified. Link to the PR:
[ ] [@grgia] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
[ ] [@grgia] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
[ ] [@grgia] Determine if we should create a regression test for this bug.
[ ] [@grgia] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
[ ] [@zanyrenney] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

zanyrenney commented 1 month ago

reapplying bug label for payout as I am going to be OOO until next week!

melvin-bot[bot] commented 1 month ago

Triggered auto assignment to @slafortune (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

zanyrenney commented 1 month ago

making daily as payout in 3 days! thanks so much @slafortune

slafortune commented 1 month ago

@grgia, there really isn't any payment due here, is there? I see that @kicu is from SM who is reviewing. Just wanted to make sure I wasn't missing anyone.

melvin-bot[bot] commented 4 weeks ago

Skipping the payment summary for this issue since all the assignees are employees or vendors. If this is incorrect, please manually add the payment summary SO.

zanyrenney commented 4 weeks ago

Closing due to ^