search

Expensify / App

Welcome to New Expensify: a complete re-imagination of financial collaboration, centered around chat. Help us build the next generation of Expensify by sharing feedback and contributing to the code.
https://new.expensify.com
MIT License
3.53k stars 2.88k forks source link

[HOLD for payment 2024-11-14] [HybridApp] Open New Expensify `/travel` when clicking on the HybridApp `Trips` tab #47734

Closed AndrewGable closed 2 days ago

AndrewGable commented 2 months ago

Problem

We have a temporary fix in place for the new Travel feature but it has some limitations:

Solution

  1. When a user clicks on Travel tab, redirect the user to New Expensify /travel via the navigateToNewDot function
    1. If the user was using Expensify Classic, we should not set their tryNewDot.classicRedirect NVP
  2. When a user clicks on Book Travel in New Expensify we should open the browser as we do today, but we should take them back to Expensify Classic in the background.

The intention here is to not take the user back to New Expensify once they return back to the Expensify app.

Issue OwnerCurrent Issue Owner: @twisterdotcom
melvin-bot[bot] commented 2 months ago

Triggered auto assignment to @garrettmknight (NewFeature), see https://stackoverflowteams.com/c/expensify/questions/14418#:~:text=BugZero%20process%20steps%20for%20feature%20requests for more details. Please add this Feature request to a GH project, as outlined in the SO.

AndrewGable commented 2 months ago

Similar to this PR https://github.com/Expensify/Mobile-Expensify/pull/12700, but will require some more work!

AndrewGable commented 2 months ago

cc @mateuuszzzzz @staszekscp @war-in - Here is a polish issue that can be worked on once we finish all other release items

twisterdotcom commented 2 months ago

Still polish, prioritised correctly.

twisterdotcom commented 1 month ago

Same as above. Will downgrade to Monthly for now.

twisterdotcom commented 1 month ago

Wow, I thought I had made this Monthly.

AndrewGable commented 1 month ago

Bumping @mateuuszzzzz @staszekscp @war-in to see if anyone wants this one!

mateuuszzzzz commented 1 month ago

Hi! I'm gonna handle that one 👍

mateuuszzzzz commented 1 month ago

I prepared PRs they're in draft mode. I need to test Android tomorrow and then I should be able to move it to "ready for a review"

mateuuszzzzz commented 1 month ago

Hi, I have and update. I would like to postpone this PR until we unify the process for booting React Native on both platforms. Currently, on iOS, the app boots on startup, which leads to platform-specific implementations to ensure compatibility on iOS. This issue also affects the current PR.

I also spent some time today with @adamgrzybowski to figure out how we can integrate this feature with the current navigation. We have come up with a solution that works surprisingly well.

AndrewGable commented 1 month ago

Sounds good!

mateuuszzzzz commented 1 month ago

We managed to change how we boot RN on iOS and it works without any crashes 🎉 I presume I will continue work on this issue on Monday/Tuesday

mateuuszzzzz commented 1 month ago

I managed to fix all remaining issues in the blocking PR. I will continue work on Travel PR on Thursday 👍

melvin-bot[bot] commented 2 weeks ago

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

melvin-bot[bot] commented 2 weeks ago

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

AndrewGable commented 2 weeks ago

We reverted these PRs due to the linked deploy blockers, let's make sure to address them before trying to merge this again. Thanks!

AndrewGable commented 2 weeks ago

Also one thing I noticed, on the OldApp side of things we never renamed Trips to Travel, it'd be great to do that in this next round of PRs.

melvin-bot[bot] commented 2 weeks ago

Reviewing label has been removed, please complete the "BugZero Checklist".

melvin-bot[bot] commented 2 weeks ago

The solution for this issue has been :rocket: deployed to production :rocket: in version 9.0.51-4 and is now subject to a 7-day regression period :calendar:. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2024-10-29. :confetti_ball:

For reference, here are some details about the assignees on this issue:

melvin-bot[bot] commented 2 weeks ago

BugZero Checklist: The PR adding this new feature has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

twisterdotcom commented 2 weeks ago

Payment Summary:

AndrewGable commented 2 weeks ago

https://github.com/Expensify/App/issues/47734#issuecomment-2427314920

mateuuszzzzz commented 1 week ago

Hi! I have an update

I prepared two PRs that should also fix previous issues.

OldDot, NewDot

I resolved the following issues:

I haven't addressed the iOS crash. I've just confirmed that this crash is not related to the Travel PR. It still appears in Crashlytics even after reverting the initial PRs (9.0.51.3).

What's more, it looks like after introduction of Bridgeless mode on iOS (9.0.54.1). This crash has stopped appearing in Crashlytics, so I wouldn't introduce any additional fixes. cc: @AndrewGable

melvin-bot[bot] commented 1 week ago

Skipping the payment summary for this issue since all the assignees are employees or vendors. If this is incorrect, please manually add the payment summary SO.

twisterdotcom commented 1 week ago

Looks like we're just waiting for these two PRs right? Don't wanna close this yet.

mateuuszzzzz commented 1 week ago

Hi, I started the implementation of betas on the OldDot side today, which is the last thing to address. I will be OOO on Thursday and Friday, and I’ll continue working on this issue on Monday.

trjExpensify commented 6 days ago

Confirmed with Brandon here that this is the expectation on the OldApp side:

mateuuszzzzz commented 3 days ago

Hi, I had to take a day off due to a cold I’ll continue working on the PR tomorrow

mateuuszzzzz commented 2 days ago

I've implemented remaining betas checks

trjExpensify commented 2 days ago

Wahoo, and glad you're feeling better! Is it ready for a re-review?

mateuuszzzzz commented 2 days ago

Wahoo, and glad you're feeling better! Is it ready for a re-review?

Yes 👌

melvin-bot[bot] commented 13 hours ago

Reviewing label has been removed, please complete the "BugZero Checklist".

melvin-bot[bot] commented 13 hours ago

The solution for this issue has been :rocket: deployed to production :rocket: in version 9.0.58-2 and is now subject to a 7-day regression period :calendar:. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2024-11-14. :confetti_ball:

For reference, here are some details about the assignees on this issue:

melvin-bot[bot] commented 13 hours ago

BugZero Checklist: The PR adding this new feature has been merged! The following checklist (instructions) will need to be completed before the issue can be closed: