Closed lanitochka17 closed 2 days ago
Triggered auto assignment to @stephanieelliott (Bug
), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.
@stephanieelliott FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors
We think that this bug might be related to #vip-vsp
@stephanieelliott Whoops! This issue is 2 days overdue. Let's get this updated quick!
@stephanieelliott Still overdue 6 days?! Let's take care of this!
I see a lot of bug bug reports but they are either related to focus mode or slow API response. This seems like neither so adding the labels for this to be worked on.
Job added to Upwork: https://www.upwork.com/jobs/~01050a994b56365205
Triggered auto assignment to Contributor-plus team member for initial proposal review - @shubham1206agra (External
)
Unavailable workspace is displayed on chat header when go to chat while logged out
Sometimes when the user only has a personal policy, the policy data may be available after the report data. Let's see the image below that I logged the report
data, and allPolicies
data via useOnyx
in HeaderView
Then the policyName
is Unavailable workspace
briefly
https://github.com/Expensify/App/blob/071f11ce1012db7d07eb750d74f58b552eba6144/src/pages/home/HeaderView.tsx#L85
That leads renderAdditionalText
being displayed
After the policy data is available, an empty string is returned here and it disappears
For this case, let us return noPolicyFound
because if returnEmptyIfNotFound
is true
we always want to display the empty string for the not found policy.
Or for the DM the policyID
is _FAKE_
, we can return early noPolicyFound
or empty
if policyID
is fake
Hey @shubham1206agra can you review this proposal?
I think this is a duplicate of https://github.com/Expensify/App/issues/44480
Lets go with @nkdengineer's proposal.
🎀👀🎀 C+ reviewed
Triggered auto assignment to @marcaaron, see https://stackoverflow.com/c/expensify/questions/7972 for more details.
I think this is a duplicate of #44480
Thanks for the heads up, but I feel @nkdengineer solution is better.
Especially this
Or for the DM the policyID is FAKE, we can return early noPolicyFound or empty if policyID is fake
@stephanieelliott @marcaaron @shubham1206agra this issue was created 2 weeks ago. Are we close to approving a proposal? If not, what's blocking us from getting this issue assigned? Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!
Thanks for the heads up, but I feel @nkdengineer solution is better.
They linked to an issue. Is it a duplicate or not?
Thanks for the heads up, but I feel @nkdengineer solution is better.
They linked to an issue. Is it a duplicate or not?
RCA of both bug is the same, but they seem to approach this issue differently. I personally think the solution is wrong there.
Can you please share your opinion with everyone involved in that other issue and see what they say? It's not great to let a separate ticket fix the same bug in a different way. Let's communicate our intentions first.
📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸
@marcaaron Please close this. Since other ticket has an open PR now.
If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
Version Number: 9.0.22-0 Reproducible in staging?: Y Reproducible in production?: Y If this was caught during regression testing, add the test name, ID and link from TestRail: https://expensify.testrail.io/index.php?/tests/view/4874559&group_by=cases:section_id&group_id=229066&group_order=asc Email or phone of affected tester (no customers): gocemate+a1028@gmail.com Issue reported by: Applause - Internal Team
Action Performed:
Expected Result:
Unavailable workspace should not be displayed on chat header
Actual Result:
Unavailable workspace is displayed on chat header when go to chat while logged out
Workaround:
Unknown
Platforms:
Which of our officially supported platforms is this issue occurring on?
Screenshots/Videos
Add any screenshot/video evidence
https://github.com/user-attachments/assets/d5e767cf-6367-4522-b54f-781097eaa531
View all open jobs on GitHub
Upwork Automation - Do Not Edit
Issue Owner
Current Issue Owner: @shubham1206agra