Expensify / App

Welcome to New Expensify: a complete re-imagination of financial collaboration, centered around chat. Help us build the next generation of Expensify by sharing feedback and contributing to the code.
https://new.expensify.com
MIT License
3.32k stars 2.75k forks source link

[$250] Chat - Chat focus is lost when create room by mentioning #47750

Closed lanitochka17 closed 1 week ago

lanitochka17 commented 3 weeks ago

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 9.0.22-0 Reproducible in staging?: Y Reproducible in production?: Y If this was caught during regression testing, add the test name, ID and link from TestRail: N/A Email or phone of affected tester (no customers): gocemate+a1030@gmail.com Issue reported by: Applause - Internal Team

Action Performed:

  1. Create a room( name it #Room 1
  2. In room chat composer type # Room 2> Send
  3. Select Yes from actionable whisper that asking if they want to create the room
  4. Navigate to LHN
  5. Navigate to #Room 1

Expected Result:

Chat composer should be focused

Actual Result:

Chat focus is lost when navigate to the room in which new room was created by mentioning

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

Screenshots/Videos

Add any screenshot/video evidence

https://github.com/user-attachments/assets/8e7c1ae3-9c4b-49de-aefa-706fa3cb2ac1

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~019c626f819c1cb5bf
  • Upwork Job ID: 1828523320267674468
  • Last Price Increase: 2024-09-03
Issue OwnerCurrent Issue Owner: @fedirjh
melvin-bot[bot] commented 3 weeks ago

Triggered auto assignment to @puneetlath (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

lanitochka17 commented 3 weeks ago

@puneetlath FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

lanitochka17 commented 3 weeks ago

We think that this bug might be related to #vip-vsp

puneetlath commented 3 weeks ago

@lanitochka17 is that the right video? It doesn't seem related to your bug report.

melvin-bot[bot] commented 2 weeks ago

@puneetlath Huh... This is 4 days overdue. Who can take care of this?

lanitochka17 commented 2 weeks ago

@puneetlath sorry for delay, correct video

https://github.com/user-attachments/assets/d3a430b9-f650-4efb-9568-62876732d973

melvin-bot[bot] commented 2 weeks ago

Job added to Upwork: https://www.upwork.com/jobs/~019c626f819c1cb5bf

melvin-bot[bot] commented 2 weeks ago

Triggered auto assignment to Contributor-plus team member for initial proposal review - @fedirjh (External)

c3024 commented 1 week ago

This is expected behaviour. On native apps, we autofocus the composer only when the chat is empty. We do not focus on the composer if there is a message in the chat on these apps.

https://github.com/Expensify/App/blob/e60b8210a1f5a2471d8aa9d84d0e461774b791d6/src/pages/home/report/ReportActionCompose/ComposerWithSuggestions/ComposerWithSuggestions.tsx#L201-L203

https://github.com/Expensify/App/blob/e60b8210a1f5a2471d8aa9d84d0e461774b791d6/src/libs/canFocusInputOnScreenFocus/index.native.ts#L3

https://github.com/Expensify/App/blob/e60b8210a1f5a2471d8aa9d84d0e461774b791d6/src/pages/home/report/ReportActionCompose/ComposerWithSuggestions/ComposerWithSuggestions.tsx#L293

melvin-bot[bot] commented 1 week ago

@puneetlath, @fedirjh Huh... This is 4 days overdue. Who can take care of this?

melvin-bot[bot] commented 1 week ago

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

melvin-bot[bot] commented 1 week ago

@puneetlath @fedirjh this issue was created 2 weeks ago. Are we close to approving a proposal? If not, what's blocking us from getting this issue assigned? Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!

puneetlath commented 1 week ago

Ah good catch @c3024. Thanks for pointing that out! Going to close.