[HOLD for payment 2024-09-16][$250] mWeb - Chat - In contacts a random guest user is displayed after login via public room link

lanitochka17 commented 3 weeks ago

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

Version Number: 9.0.22 Reproducible in staging?: Y Reproducible in production?: Y If this was caught during regression testing, add the test name, ID and link from TestRail: N/A Issue reported by: Applause - Internal Team

Action Performed:

Go to this link as signed out user https://staging.new.expensify.com/r/7075912447943023
Tap sign in
Enter credentials and log in
Navigate to LHN
Tap fab -- start chat
In contacts, note a guest user is added.

Expected Result:

In contacts, a random guest user must not be displayed after login via public room link

Actual Result:

In contacts, a random guest user is displayed after login via public room link

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

[ ] Android: Native
[x] Android: mWeb Chrome
[ ] iOS: Native
[ ] iOS: mWeb Safari
[ ] MacOS: Chrome / Safari
[ ] MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

https://github.com/user-attachments/assets/55f56373-f43a-467d-822e-2343ad068345

View all open jobs on GitHub

Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~0148f0358fba85f9ac
Upwork Job ID: 1828135607297326184
Last Price Increase: 2024-08-26
Automatic offers:

jjcoffee | Reviewer | 103703199
dominictb | Contributor | 103703202

Issue Owner

Current Issue Owner: @jjcoffee

melvin-bot[bot] commented 3 weeks ago

Triggered auto assignment to @CortneyOfstad (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

lanitochka17 commented 3 weeks ago

@CortneyOfstad FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

dominictb commented 3 weeks ago

Edited by proposal-police: This proposal was edited at 2023-10-07T14:32:22Z.

Proposal

Please re-state the problem that we are trying to solve in this issue.

In contacts, a random guest user is displayed after login via public room link

What is the root cause of that problem?

When opening a public room as an anonymous user, the session data is:

accountID: A,
email: x@expensify.anon

and we create a personal detail for it:

accountID: A,
displayName: "Guest",
lastName: "Guest"

and after signing, we do not clear these data, so these data appear in contact list.

What changes do you think we should make in order to solve the problem?

We should create a function to cleanup the anon personal detail:

function removeAnonFromPersonalDetails() {
const anonAccountIDs = Object.values(personalDetails).filter((detail) => detail?.login?.includes('@expensify.anon'));
const data = anonAccountIDs.reduce((res, detail) => ({...res, [detail.accountID]: null}), {});
Onyx.merge(ONYXKEYS.PERSONAL_DETAILS_LIST, data);
}

and call it in: https://github.com/Expensify/App/blob/f12c1fff5f5344efb20cc48e2805e766c6b5523d/src/libs/Navigation/AppNavigator/AuthScreens.tsx#L124

What alternative solutions did you explore? (Optional)

Solution 1:

Can use useEffect:

    const isAnonymousUser = session?.authTokenType === CONST.AUTH_TOKEN_TYPES.ANONYMOUS;
    const prevIsAnonymousUser = usePrevious(isAnonymousUser);
    useEffect(() => {
        if (prevIsAnonymousUser && !isAnonymousUser) {
            removeAnonFromPersonalDetails();
        }
    }, [prevIsAnonymousUser, isAnonymousUser]);

Solution 2:

Can cleanup the anon personal details when the sign in API is called successfully, such as in: https://github.com/Expensify/App/blob/f12c1fff5f5344efb20cc48e2805e766c6b5523d/src/libs/actions/Session/index.ts#L520 and https://github.com/Expensify/App/blob/f12c1fff5f5344efb20cc48e2805e766c6b5523d/src/libs/actions/Session/index.ts#L588

dominictb commented 3 weeks ago

Proposal Updated

CortneyOfstad commented 2 weeks ago

I am confused by the steps, as it specifically mentions In contacts, note a guest user is added.

The contact was not added to the chat, but rather a suggestion. And this is by design.

@lanitochka17 does the tester recognize that email in any capacity in regards to Expensify or testing within Expensify?

dominictb commented 2 weeks ago

@CortneyOfstad If we do not sign in and then visit the public room, a random personal detail data is assigned to us. That data is something like:

accountID: A,
displayName: "Guest",
lastName: "Guest",
login: random@expensify.anon,

Then when signing in, the above random user data is not cleared, so it is displayed in the contact list.

CortneyOfstad commented 2 weeks ago

Thank you @dominictb for the clarification!

I am having trouble recreating this, so I am going to have this retest by QA 👍