Open IuliiaHerets opened 2 months ago
Triggered auto assignment to @lschurr (Bug
), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.
@lschurr FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors
Admin has 2 payment options - "Pay Elsewhare" and "Pay with Expensify" if Reimbursements is set to Indirect
The condition to show Pay with Expensify
does not include the case of Indirect
reimbursements:
Update shouldShowPaywithExpensifyOption
to check if policy's reimbursementChoice
is NOT reimburseManual
(Indirect).
!shouldHidePaymentOptions && ReportUtils.isPayer(session, iouReport) && policy?.reimbursementChoice !== CONST.POLICY.REIMBURSEMENT_CHOICES.REIMBURSEMENT_MANUAL
Job added to Upwork: https://www.upwork.com/jobs/~01d0a122b57dabf58d
Triggered auto assignment to Contributor-plus team member for initial proposal review - @mkhutornyi (External
)
@daledah's proposal looks good as per Expected Result: Admin only has one payment option "Pay Elsewhare" if Reimbursements is set to Indirect
πππ C+ reviewed
Triggered auto assignment to @yuwenmemon, see https://stackoverflow.com/c/expensify/questions/7972 for more details.
π£ @mkhutornyi π An offer has been automatically sent to your Upwork account for the Reviewer role π Thanks for contributing to the Expensify app!
π£ @daledah You have been assigned to this job! Please apply to the Upwork job and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review π§βπ» Once you apply to this job, your Upwork ID will be stored and you will be automatically hired for future jobs! Keep in mind: Code of Conduct | Contributing π
Looks like this was just assigned today. @daledah let us know when you have a PR up!
This issue has not been updated in over 15 days. @yuwenmemon, @lschurr, @mkhutornyi, @daledah eroding to Monthly issue.
P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do!
If you havenβt already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
Version Number: 9.0.23-0 Reproducible in staging?: Y Reproducible in production?: Y If this was caught during regression testing, add the test name, ID and link from TestRail: https://expensify.testrail.io/index.php?/tests/view/4879259 Email or phone of affected tester (no customers): fischer9966+082124aadm@gmail.com Issue reported by: Applause Internal Team
Action Performed:
Precondition NewDot:
Precondition OldDot:
Steps NewDot:
Expected Result:
Admin only has one payment option "Pay Elsewhare" if Reimbursements is set to Indirect
Actual Result:
Admin has 2 payment options - "Pay Elsewhare" and "Pay with Expensify" if Reimbursements is set to Indirect
Workaround:
Unknown
Platforms:
Screenshots/Videos
https://github.com/user-attachments/assets/064f098a-e711-4e05-ac4d-a55fb8beef72
View all open jobs on GitHub
Upwork Automation - Do Not Edit