[HOLD for payment 2024-10-10] [$250] connect to Quickbooks Dekstop on OldDot, the admin room in newdot shows incomplete system messages

[m-natarajan]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.0.23-0 Reproducible in staging?: y Reproducible in production?: y If this was caught during regression testing, add the test name, ID and link from TestRail: Email or phone of affected tester (no customers): Logs: https://stackoverflow.com/c/expensify/questions/4856 Expensify/Expensify Issue URL: Issue reported by: @dubielzyk-expensify Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1724242725049269

Action Performed:

1. Login with same account in OD and ND
2. Go to workspace in OD
3. Connect to Quickbooks Dekstop
4. Go to # admin room of the same workspace

   Expected Result:

   There shouldn't be any incomplete message

   Actual Result:

   “removed the connection to message appears

   Workaround:

   unknown

   Platforms:

   Which of our officially supported platforms is this issue occurring on?

   • [ ] Android: Native
   • [ ] Android: mWeb Chrome
   • [ ] iOS: Native
   • [ ] iOS: mWeb Safari
   • [x] MacOS: Chrome / Safari
   • [ ] MacOS: Desktop

Screenshots/Videos

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021833242408324478296
• Upwork Job ID: 1833242408324478296
• Last Price Increase: 2024-09-23
• Automatic offers:
• DylanDylann | Contributor | 104119799

Issue Owner

Current Issue Owner: @dylanexpensify

[daledah]

Edited by proposal-police: This proposal was edited at 2024-08-22 02:59:49 UTC.

Proposal

Please re-state the problem that we are trying to solve in this issue.

• “removed the connection to message appears

What is the root cause of that problem?

• We don't have a specific logic to display POLICYCHANGELOG_DELETE_INTEGRATION, so it displays the message[0].text, which is removed the connection to.

  What changes do you think we should make in order to solve the problem?

• We can create a logic to handle this type of message in: https://github.com/Expensify/App/blob/ad7c1d5e394c8a9ee1ce7427233aa085350bb500/src/pages/home/report/ReportActionItem.tsx#L676

      } else if (action.actionName === CONST.REPORT.ACTIONS.TYPE.POLICY_CHANGE_LOG.DELETE_INTEGRATION) {
          children = (
              <ReportActionItemBasicMessage
                  message={`Removed connection to ${CONST.POLICY.CONNECTIONS.NAME_USER_FRIENDLY[ReportActionsUtils.getOriginalMessage(action).connectionName]}`}
              />
          );

• Same logic should be applied to LHN in here: https://github.com/Expensify/App/blob/ad7c1d5e394c8a9ee1ce7427233aa085350bb500/src/libs/SidebarUtils.ts#L438

      } else if (lastAction?.actionName === CONST.REPORT.ACTIONS.TYPE.POLICY_CHANGE_LOG.DELETE_INTEGRATION) {
          result.alternateText = `Removed connection to ${CONST.POLICY.CONNECTIONS.NAME_USER_FRIENDLY[ReportActionsUtils.getOriginalMessage(lastAction).connectionName]}`;
      } 

  and https://github.com/Expensify/App/blob/ad7c1d5e394c8a9ee1ce7427233aa085350bb500/src/pages/home/report/ContextMenu/ContextMenuActions.tsx#L473

• The text to display can be updated later based on design.

  What alternative solutions did you explore? (Optional)

[melvin-bot[bot]]

Huh... This is 4 days overdue. Who can take care of this?

[melvin-bot[bot]]

Still overdue 6 days?! Let's take care of this!

[melvin-bot[bot]]

10 days overdue. Is anyone even seeing these? Hello?

[melvin-bot[bot]]

Triggered auto assignment to @dylanexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[dylanexpensify]

@bfitzexpensify confirming this is a bug, yeah?

[bfitzexpensify]

Yeah, I agree with the expected vs actual result differing, and this therefore being a bug

[melvin-bot[bot]]

@dylanexpensify this issue was created 2 weeks ago. Are we close to a solution? Let's make sure we're treating this as a top priority. Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!

[melvin-bot[bot]]

@dylanexpensify Eep! 4 days overdue now. Issues have feelings too...

[melvin-bot[bot]]

Job added to Upwork: https://www.upwork.com/jobs/~021833242408324478296

[melvin-bot[bot]]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @abdulrahuman5196 (External)

[trjExpensify]

Support for QBD is being built in #wave-control, moving.

[melvin-bot[bot]]

@abdulrahuman5196, @dylanexpensify Whoops! This issue is 2 days overdue. Let's get this updated quick!

[melvin-bot[bot]]

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

[abdulrahuman5196]

Hi, Will check in my morning

[melvin-bot[bot]]

@abdulrahuman5196 @dylanexpensify this issue is now 4 weeks old, please consider:

• Finding a contributor to fix the bug
• Closing the issue if BZ has been unable to add the issue to a VIP or Wave project
• If you have any questions, don't hesitate to start a discussion in #expensify-open-source

Thanks!

[melvin-bot[bot]]

@abdulrahuman5196, @dylanexpensify Whoops! This issue is 2 days overdue. Let's get this updated quick!

[melvin-bot[bot]]

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

[abdulrahuman5196]

Hi @dylanexpensify I am having my plate full at the moment and I don't want to delay this issue. Kindly reassign the label for a different C+. Unassigning myself.

[DylanDylann]

I am happy to take over this issue as C+ contributor

[dylanexpensify]

TY @DylanDylann!

[melvin-bot[bot]]

📣 @DylanDylann 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!

Offer link Upwork job Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻 Keep in mind: Code of Conduct | Contributing 📖

[DylanDylann]

@daledah Why doesn't this bug happen when disconnecting the connection on the new dot?

I just disconnected the connection on New Dot and the message display correctly

[daledah]

@DylanDylann I believe the issue is on the backend side. For QBO, message[0].text is removed the connection to QuickBooks Online, but for QBD, it’s just removed the connection to.

However, both change log messages include the connectionName data, which we can use to properly display the system message as mentioned in my proposal.

[DylanDylann]

@daledah's proposal looks good to me. Please add translation to the message in the PR phase.

🎀 👀 🎀 C+ reviewed

[melvin-bot[bot]]

Triggered auto assignment to @lakchote, see https://stackoverflow.com/c/expensify/questions/7972 for more details.

[lakchote]

@daledah's proposal LGTM.

[melvin-bot[bot]]

📣 @daledah You have been assigned to this job! Please apply to the Upwork job and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻 Once you apply to this job, your Upwork ID will be stored and you will be automatically hired for future jobs! Keep in mind: Code of Conduct | Contributing 📖

[daledah]

@DylanDylann Currently I don't have access to Expensify Slack Channel, can you help ask for the translation text added in my proposal? The text is: Removed connection to

[DylanDylann]

@daledah Let's use : "Conexión eliminada a"

I already asked someone to confirm on Slack: https://expensify.slack.com/archives/C01GTK53T8Q/p1727426074343199

[daledah]

@DylanDylann PR is ready. Waiting for translate confirmation https://github.com/Expensify/App/issues/47830#issuecomment-2378745548

[melvin-bot[bot]]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot[bot]]

The solution for this issue has been :rocket: deployed to production :rocket: in version 9.0.43-6 and is now subject to a 7-day regression period :calendar:. Here is the list of pull requests that resolve this issue:

• https://github.com/Expensify/App/pull/49834

If no regressions arise, payment will be issued on 2024-10-10. :confetti_ball:

For reference, here are some details about the assignees on this issue:

• @DylanDylann requires payment automatic offer (Contributor)
• @daledah requires payment (Needs manual offer from BZ)

[melvin-bot[bot]]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [ ] [@DylanDylann] The PR that introduced the bug has been identified. Link to the PR:
• [ ] [@DylanDylann] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [ ] [@DylanDylann] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [ ] [@DylanDylann] Determine if we should create a regression test for this bug.
• [ ] [@DylanDylann] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [ ] [@dylanexpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[dylanexpensify]

Coming up!

[dylanexpensify]

Coming up!

[dylanexpensify]

Payment summary:

Contributor: @daledah $250 Contributor+: @DylanDylann $250

Please apply/request!

[dylanexpensify]

@daledah please apply!

[dylanexpensify]

@DylanDylann paid!

[daledah]

@dylanexpensify applied

[dylanexpensify]

@daledah offer sent!

[DylanDylann]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

[@DylanDylann] The PR that introduced the bug has been identified. Link to the PR: *This change seem like a new feature, not a bug [@DylanDylann] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: NA [@DylanDylann] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: NA [@DylanDylann] Determine if we should create a regression test for this bug. Yes [@DylanDylann] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.

Regression Test Proposal

1. Login with the same account in OD and ND
2. Go to workspace in OD
3. Connect to Quickbooks Dekstop
4. In OD, disconnect from Quickbooks Desktop
5. In ND, navigate to WS #admins chat
6. Verify that: The Report Action Item, Sidebar Text shows the correct message
7. Right click on the message, click "Copy to Clipboard" and paste.
8. Verify that: Pasted text shows the correct message

Do we agree 👍 or 👎

[dylanexpensify]

Done!