Expensify / App

Welcome to New Expensify: a complete re-imagination of financial collaboration, centered around chat. Help us build the next generation of Expensify by sharing feedback and contributing to the code.
https://new.expensify.com
MIT License
3.43k stars 2.8k forks source link

[$250] Track – Setting expense to unreported in OldDot turn the expense in workspace chat to 0.00 #47884

Open lanitochka17 opened 1 month ago

lanitochka17 commented 1 month ago

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 9.0.24-0 Reproducible in staging?: Y Reproducible in production?: Y If this was caught during regression testing, add the test name, ID and link from TestRail: https://expensify.testrail.io/index.php?/tests/view/4887079&group_by=cases:section_id&group_order=asc&group_id=309130 Email or phone of affected tester (no customers): gocemate+a1060@gmail.com Issue reported by:Applause - Internal Team

Action Performed:

Precondition:

  1. In OldDot - Create an unreported transaction on OldDot
  2. Verify that it shows up on the self-DM in NewDot
  3. In OldDot - add the transaction to a report
  4. Verify it is removed from the self-DM in DM and send to Workspace chat
  5. In OldDot - make the transaction unreported again

Expected Result:

Transaction should be removed from workspace chat and send to self-DM chat again

Actual Result:

Same transaction is present on self-DM chat and workspace chat Sometimes the transaction in workspace chat appears with amount set to 0.00

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

Screenshots/Videos

Add any screenshot/video evidence

https://github.com/user-attachments/assets/d8ff2715-3aa8-46fb-a165-fba740c7808e

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~018a4221d84dcbfb8b
  • Upwork Job ID: 1829267536895122660
  • Last Price Increase: 2024-09-05
melvin-bot[bot] commented 1 month ago

Triggered auto assignment to @johncschuster (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

lanitochka17 commented 1 month ago

@johncschuster FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

Amoralchik commented 1 month ago

I believe this is part of the same issue and should be fixed along with it. https://github.com/Expensify/App/issues/46287.

My proposal outlines one possible client-side solution.

melvin-bot[bot] commented 1 month ago

@johncschuster Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

johncschuster commented 1 month ago

Raised in Slack. Keeping at a lower priority while we focus on higher urgency items.

melvin-bot[bot] commented 1 month ago

Job added to Upwork: https://www.upwork.com/jobs/~018a4221d84dcbfb8b

melvin-bot[bot] commented 1 month ago

Triggered auto assignment to Contributor-plus team member for initial proposal review - @aimane-chnaif (External)

melvin-bot[bot] commented 1 month ago

@johncschuster, @aimane-chnaif Whoops! This issue is 2 days overdue. Let's get this updated quick!

aimane-chnaif commented 1 month ago

Awaiting proposals

melvin-bot[bot] commented 4 weeks ago

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

melvin-bot[bot] commented 4 weeks ago

@johncschuster @aimane-chnaif this issue was created 2 weeks ago. Are we close to approving a proposal? If not, what's blocking us from getting this issue assigned? Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!

rezkiy37 commented 3 weeks ago

Hi, I am Michael (Mykhailo) from Callstack, an expert agency and I can work on this issue.

melvin-bot[bot] commented 3 weeks ago

@johncschuster, @aimane-chnaif Huh... This is 4 days overdue. Who can take care of this?

rezkiy37 commented 3 weeks ago

I am testing the bug.

rezkiy37 commented 3 weeks ago

I've completed the testing. I can confirm that it is a backend bug. There are 2 places to fix:

  1. Pusher: it does not send updates when the user makes the transaction unreported again. Neither the workspace chat nor the self-DM chat receives updates with added/removed expenses.
  2. The backend does not remove unreported transactions from the workspace chat. The backend still includes the transactions and successfully fetches its reports. Also, it duplicates report actions if the user makes the transaction reported again.

We need an internal engineer here 🙂

https://github.com/user-attachments/assets/68898e80-3a63-4b6e-b825-5bc7f88f65e9

cc @johncschuster

johncschuster commented 3 weeks ago

Amazing. Thanks for doing that, @rezkiy37! @dylanexpensify beat me to it, and has applied the Internal label. We'll get someone on this ASAP!

melvin-bot[bot] commented 3 weeks ago

@johncschuster, @rezkiy37, @aimane-chnaif Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

melvin-bot[bot] commented 2 weeks ago

@johncschuster, @rezkiy37, @aimane-chnaif 6 days overdue. This is scarier than being forced to listen to Vogon poetry!

johncschuster commented 2 weeks ago

@dylanexpensify can you help me prioritize this internally?

melvin-bot[bot] commented 2 weeks ago

@johncschuster @rezkiy37 @aimane-chnaif this issue is now 4 weeks old, please consider:

Thanks!

johncschuster commented 2 weeks ago

Chatted in Slack about this one. We agree this is still worth fixing, but it's currently a lower priority while we focus on more urgent things.

mvtglobally commented 2 weeks ago

Issue not reproducible during KI retests. (First week)

melvin-bot[bot] commented 1 week ago

@johncschuster, @rezkiy37, @aimane-chnaif Whoops! This issue is 2 days overdue. Let's get this updated quick!

johncschuster commented 1 week ago

Great! Let's wait one more week. If not reproducible, we can close the issue.

johncschuster commented 1 day ago

We need a retest on this, but it looks like we should wait until the next deploy