Expensify / App

Welcome to New Expensify: a complete re-imagination of financial collaboration, centered around chat. Help us build the next generation of Expensify by sharing feedback and contributing to the code.
https://new.expensify.com
MIT License
3.32k stars 2.76k forks source link

Android Native: The bottom half of the camera doesn't work (i.e. shutter, flash and file upload buttons) #47911

Open muttmuure opened 2 weeks ago

muttmuure commented 2 weeks ago

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: Android 9.0.24 Reproducible in staging?: Y Reproducible in production?: Y If this was caught during regression testing, add the test name, ID and link from TestRail: Email or phone of affected tester (no customers): Logs: https://stackoverflow.com/c/expensify/questions/4856 Expensify/Expensify Issue URL: Issue reported by: @jliexpensify Slack conversation: https://expensify.slack.com/archives/C05LX9D6E07/p1724402419158759

Action Performed:

Break down in numbered steps

  1. Click on "Submit expense"
  2. Camera opens and "you need to give permissions" is shown
  3. Click on "Continue" and notice nothing happens
  4. Go to Android camera settings and give permissions to Expensify app
  5. Permissions screen disappears
  6. Click on shutter, flash and upload file buttons - nothing happens

Expected Result:

Describe what you think should've happened

Shutter, flash and file upload buttons are responsive

Actual Result:

Describe what actually happened

They are not

Workaround:

Can the user still use Expensify without this being fixed? Have you informed them of the workaround?

Platforms:

Which of our officially supported platforms is this issue occurring on?

Screenshots/Videos

Add any screenshot/video evidence

View all open jobs on GitHub

melvin-bot[bot] commented 2 weeks ago

Triggered auto assignment to @muttmuure (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

hannojg commented 2 weeks ago

Hanno from Margelo here, who built the used react-native-vision-camera library. Feel free to assign me 👋

Julesssss commented 2 weeks ago

I can reproduce. Perhaps the bug is within the permission logic that occurs before the camera is launched.

Pixel 8A, Android 14, existing account that has just signed in.

hannojg commented 2 weeks ago

Yes, thats likely. We are using a very outdated version of rn-vision-camera and I believe this has been fixed already. I am currently looking in upgrading rn-vision-camera!

hannojg commented 2 weeks ago

what phone model + android version are you using @Julesssss ?

Julesssss commented 2 weeks ago

Just edited my comment. Pixel 8a, Android 14

hannojg commented 2 weeks ago

Regression was introduced in:

looking into a fix within react-native-pager-view now…

hannojg commented 2 weeks ago

(So its not a bug in react-native-vision-camera / an android 14 permission issue!)

hannojg commented 2 weeks ago

The issue was already reported in the library here:

I found the same fix as the library maintainer. Will propose a patch PR until this is fixed in the library!

parasharrajat commented 2 weeks ago

@Julesssss Should we go with the Patch or wait for the lib fix?

cristipaval commented 2 weeks ago

FYI: We reverted the library upgrade in the meantime, to fix 3 blockers and unblock the deploy.

jliexpensify commented 2 weeks ago

@cristipaval @hannojg @muttmuure @Julesssss the camera is working again!

parasharrajat commented 2 weeks ago

@hannojg In that case, we don't that PR.

parasharrajat commented 2 weeks ago

Please assign me to the issue as I am C+ on the PR @Julesssss

Julesssss commented 2 weeks ago

Please assign me to the issue as I am C+ on the PR @Julesssss

Done

muttmuure commented 2 weeks ago

@cristipaval @hannojg @muttmuure @Julesssss the camera is working again!

Hooray!