[$250] Workspace - Role changed to admin member can't access compose box in workspace chat

lanitochka17 commented 3 weeks ago

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

Version Number: 9.0.24-0 Reproducible in staging?: Y Reproducible in production?: Y If this was caught during regression testing, add the test name, ID and link from TestRail: Email or phone of affected tester (no customers): biruknew45+171@gmail.com Issue reported by: Applause - Internal Team

Action Performed:

Go to [https://staging.new.expensify.com/]
As User A, create a workspace and add User B
Navigate to the workspace chat
Click on the header and then "Settings."
Click on the "Who Can Post" settings
Change it to "Admin Only."
Go to the workspace settings
Change User B's role to admin
Observe the behavior as User B
Go to the workspace settings
Change User B's role to "Member."
Observe the behavior as User B

Expected Result:

After changing the member's role to admin, the member should be able to post immediately. The compose box and permission message should update consistently based on role and "Who Can Post" settings. after reverting the member's role to "Member," the compose box should be hidden again, preventing the member from attempting to send messages

Actual Result:

After changing the member's role to admin, the member cannot post. the compose box and permission message disappear and reappear inconsistently then the compose box remains visible even after reverting the member's role to "Member," but sending a message results in an error

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

[ ] Android: Native
[ ] Android: mWeb Chrome
[ ] iOS: Native
[ ] iOS: mWeb Safari
[x] MacOS: Chrome / Safari
[ ] MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

https://github.com/user-attachments/assets/30438e8b-9992-4d7e-a8a0-529295cf4592

View all open jobs on GitHub

Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~01c1f02627a154bb67
Upwork Job ID: 1828876093361855716
Last Price Increase: 2024-08-28
Automatic offers:

allgandalf | Contributor | 103786652

Issue Owner

Current Issue Owner: @daledah

melvin-bot[bot] commented 3 weeks ago

Triggered auto assignment to @abekkala (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

lanitochka17 commented 3 weeks ago

@abekkala FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

lanitochka17 commented 3 weeks ago

We think that this bug might be related to #wave-collect - Release 1

daledah commented 3 weeks ago

Proposal

Please re-state the problem that we are trying to solve in this issue.

Workspace - Role changed to admin member can't access compose box in workspace chat

What is the root cause of that problem?

When the policy.role changes, the ReportFooter is not rerendered: https://github.com/Expensify/App/blob/08bb00b2dc515bb1da2e70f9b9eae9d522c3be50/src/pages/home/report/ReportFooter.tsx#L225-L232

What changes do you think we should make in order to solve the problem?

Should add:

    lodashIsEqual(prevProps.policy?.employeeList, nextProps.policy?.employeeList) &&
    lodashIsEqual(prevProps.policy?.role, nextProps.policy?.role)

as well to the above propsAreEqual function.

Then we update: https://github.com/Expensify/App/blob/08bb00b2dc515bb1da2e70f9b9eae9d522c3be50/src/pages/home/report/ReportFooter.tsx#L108
```
const cannotPerformWriteAction = !ReportUtils.canUserPerformWriteAction(report) && !shouldShowComposerOptimistically
const shouldHideComposer = cannotPerformWriteAction || isBlockedFromChat;
```
What alternative solutions did you explore? (Optional)

NA