Expensify / App

Welcome to New Expensify: a complete re-imagination of financial collaboration, centered around chat. Help us build the next generation of Expensify by sharing feedback and contributing to the code.
https://new.expensify.com
MIT License
3.51k stars 2.86k forks source link

[$250] IOU-After inviting a member, creating split expense shows unexpected error #47980

Closed IuliiaHerets closed 1 month ago

IuliiaHerets commented 2 months ago

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 9.0.24 Reproducible in staging?: Y Reproducible in production?: Y Issue reported by: Applause Internal Team

Action Performed:

  1. Go to https://staging.new.expensify.com/home (use gmail account to login)
  2. Tap fab -- start chat
  3. Create a group
  4. Tap header -- member
  5. Invite a user
  6. Tap plus icon -- split expense
  7. Create a split expense

Expected Result:

After inviting a member, creating split expense must not show unexpected error.

Actual Result:

After inviting a member, creating split expense shows unexpected error.

Workaround:

Unknown

Platforms:

Screenshots/Videos

https://github.com/user-attachments/assets/9a4ff420-d78c-4007-a740-e25b699ed16c

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~016086fbf0990940e8
  • Upwork Job ID: 1828106989984610168
  • Last Price Increase: 2024-08-26
melvin-bot[bot] commented 2 months ago

Triggered auto assignment to @Christinadobrzyn (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

IuliiaHerets commented 2 months ago

We think that this bug might be related to #wave-control

IuliiaHerets commented 2 months ago

@Christinadobrzyn FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

codewaseem commented 2 months ago

I could not reproduce this on the latest main branch.

NJ-2020 commented 2 months ago

I can reproduce this issue on the latest main on staging server And I could say this is BE issue, when inviting the user to the group chat, the BE doesn't return the new user with an email or login property inside the personalDetails or for the participant for the transaction So when we request a split expense the BE shows this: Screenshot 2024-08-25 at 17 00 39

Screenshot 2024-08-25 at 17 01 00

When inviting user to the group chat the BE doesn't return the email or the login property Screenshot 2024-08-25 at 17 03 16

Christinadobrzyn commented 2 months ago

I'm adding this to vip-split. I can reproduce this error. I'm not sure if this needs to be BE so starting as external.

melvin-bot[bot] commented 2 months ago

Job added to Upwork: https://www.upwork.com/jobs/~016086fbf0990940e8

melvin-bot[bot] commented 2 months ago

Triggered auto assignment to Contributor-plus team member for initial proposal review - @dukenv0307 (External)

dukenv0307 commented 2 months ago

@Christinadobrzyn It's BE bug

Christinadobrzyn commented 2 months ago

thanks @dukenv0307 looking for a volunteer

Christinadobrzyn commented 2 months ago

looking for a volunteer

melvin-bot[bot] commented 1 month ago

@Christinadobrzyn, @dukenv0307 Whoops! This issue is 2 days overdue. Let's get this updated quick!

Christinadobrzyn commented 1 month ago

testing this again, I'm not getting an error. I think this might be resolved. @dukenv0307 can you test please?

Christinadobrzyn commented 1 month ago

also, I'm going to be ooo 9/4 - 9/10 so moving this to weekly while I'm gone because I think we'll be able to close this or at least we're waiting for a volunteer.

dukenv0307 commented 1 month ago

I also can't reproduce. We can close this @Christinadobrzyn