Expensify / App

Welcome to New Expensify: a complete re-imagination of financial collaboration, centered around chat. Help us build the next generation of Expensify by sharing feedback and contributing to the code.
https://new.expensify.com
MIT License
3.33k stars 2.76k forks source link

[HOLD for Payment 2024-09-6] [$250] [Search v2.1] Tag filter has duplicates and generates console errors #48005

Closed 289Adam289 closed 1 week ago

289Adam289 commented 2 weeks ago

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: Reproducible in staging?: yes Reproducible in production?: yes If this was caught during regression testing, add the test name, ID and link from TestRail: Email or phone of affected tester (no customers): Logs: https://stackoverflow.com/c/expensify/questions/4856 Expensify/Expensify Issue URL: Issue reported by: Slack conversation:

Action Performed:

Expected Result:

No duplicates

Actual Result:

Many duplicates

Workaround:

Can the user still use Expensify without this being fixed? Have you informed them of the workaround?

Platforms:

Which of our officially supported platforms is this issue occurring on?

Screenshots/Videos

image

Add any screenshot/video evidence

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~016f48b06e4d132623
  • Upwork Job ID: 1828149808542651493
  • Last Price Increase: 2024-08-26
Issue OwnerCurrent Issue Owner: @
melvin-bot[bot] commented 2 weeks ago

📣 @Lxx-c! 📣 Hey, it seems we don’t have your contributor details yet! You'll only have to do this once, and this is how we'll hire you on Upwork. Please follow these steps:

  1. Make sure you've read and understood the contributing guidelines.
  2. Get the email address used to login to your Expensify account. If you don't already have an Expensify account, create one here. If you have multiple accounts (e.g. one for testing), please use your main account email.
  3. Get the link to your Upwork profile. It's necessary because we only pay via Upwork. You can access it by logging in, and then clicking on your name. It'll look like this. If you don't already have an account, sign up for one here.
  4. Copy the format below and paste it in a comment on this issue. Replace the placeholder text with your actual details. Screen Shot 2022-11-16 at 4 42 54 PM Format:
    Contributor details
    Your Expensify account email: <REPLACE EMAIL HERE>
    Upwork Profile Link: <REPLACE LINK HERE>
melvin-bot[bot] commented 2 weeks ago

Triggered auto assignment to @lschurr (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

289Adam289 commented 2 weeks ago

@luacmartins The fix is easy and i can implement it.

melvin-bot[bot] commented 2 weeks ago

Job added to Upwork: https://www.upwork.com/jobs/~016f48b06e4d132623

melvin-bot[bot] commented 2 weeks ago

Current assignee @ikevin127 is eligible for the External assigner, not assigning anyone new.

ikevin127 commented 2 weeks ago

⚠️ Automation failed here -> this should be on [HOLD for Payment 2024-09-6] according to today’s production deploy from https://github.com/Expensify/App/pull/48074#issuecomment-2322123840.

cc @lschurr @luacmartins

lschurr commented 1 week ago

Not overdue - Payment is on Friday.

lschurr commented 1 week ago

Payment summary:

ikevin127 commented 1 week ago

@lschurr Offer accepted, thank you!

lschurr commented 1 week ago

All set!