[HOLD for payment 2024-09-17][Search v2.2] Update trip filters to All, Current and Past

Expensify / App

Welcome to New Expensify: a complete re-imagination of financial collaboration, centered around chat. Help us build the next generation of Expensify by sharing feedback and contributing to the code.

https://new.expensify.com

MIT License

3.33k stars 2.76k forks source link

[HOLD for payment 2024-09-17][Search v2.2] Update trip filters to All, Current and Past #48020

Open luacmartins opened 2 weeks ago

luacmartins commented 2 weeks ago

Problem

During implementation, we realized that we're basically just showing expense data as trip data. So we decided on an MVP showing the same Expense status filters, i.e. All, Drafts, Outstanding, Approved, and Paid.
While testing the Trips filter, we found it to be pretty confusing, because it's not really clear what a draft or outstanding trip is

Solution Update the Trips status filters to All, Current and Past

All is a list of all existing trips the user has access to
Current is a list of upcoming and current trips based on the start and end dates for the trip
Past is a list of all trips which end date are in the past

Issue Owner

Current Issue Owner: @CortneyOfstad

melvin-bot[bot] commented 2 weeks ago

Triggered auto assignment to @CortneyOfstad (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

melvin-bot[bot] commented 2 weeks ago

Triggered auto assignment to @isabelastisser (NewFeature), see https://stackoverflowteams.com/c/expensify/questions/14418#:~:text=BugZero%20process%20steps%20for%20feature%20requests for more details. Please add this Feature request to a GH project, as outlined in the SO.

JmillsExpensify commented 2 weeks ago

Also for clarity, I'm thinking we could use these icons for all, current, and past. Thoughts @shawnborton @dubielzyk-expensify @dannymcclain

shawnborton commented 2 weeks ago

I think those work? Alternatively, we could consider making some kind of new icon that has a calendar and a checkmark or something for past? And then maybe just the calendar for current?

JmillsExpensify commented 2 weeks ago

That could work too!

dannymcclain commented 2 weeks ago

I think they're alright, but I'm truthfully not in love with them. Do you all think these work a little better? (Nothing new/custom, just some different choices from the system)

CleanShot 2024-08-29 at 08 55 42@2x

I should note that I don't feel SUPER strongly. Happy to go with whatever you all think works!

shawnborton commented 2 weeks ago

I think I like those more than the others personally. Curious for Jason's thoughts too.

JmillsExpensify commented 2 weeks ago

Sounds great! I agree that those are better.

dubielzyk-expensify commented 2 weeks ago

Love em

melvin-bot[bot] commented 2 weeks ago

@CortneyOfstad, @luacmartins, @isabelastisser Whoops! This issue is 2 days overdue. Let's get this updated quick!

luacmartins commented 2 weeks ago

PRs in review

luacmartins commented 4 days ago

PR was deployed to production yesterday

CortneyOfstad commented 4 days ago

Thanks @luacmartins!