Closed IuliiaHerets closed 1 week ago
Triggered auto assignment to @OfstadC (Bug
), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.
Triggered auto assignment to @MariaHCD (DeployBlockerCash
), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.
:wave: Friendly reminder that deploy blockers are time-sensitive β± issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
We think that this bug might be related to #wave-control
"Default" label changes to "Workspace currency default" after changing tax code
Here were are not setting foreignTaxDefault
to the newTaxCode
when editing tax code
https://github.com/Expensify/App/blob/d5cfecfc53a2abf926a1dd9be8bc72c0b373ff81/src/libs/actions/TaxRate.ts#L486-L496
And here default badge is only displayed when taxID === defaultExternalID && taxID === foreignTaxDefault
condition holds to be true. And it is not being true, since we are not updating foreignTaxDefault
https://github.com/Expensify/App/blob/d5cfecfc53a2abf926a1dd9be8bc72c0b373ff81/src/pages/workspace/taxes/WorkspaceTaxesPage.tsx#L87-L91
We should update foreignTaxDefault
with the new tax code in optimistic data here
foreignTaxDefault: oldTaxCode === policy?.taxRates?.foreignTaxDefault ? newTaxCode : policy?.taxRates?.foreignTaxDefault,
And set foreignTaxDefault
to the existing foreignTaxDefault
in failure data
foreignTaxDefault: policy?.taxRates?.foreignTaxDefault,
Also we shouldn't update defaultExternalID
in successData since BE returns the updated value
Offending pr https://github.com/Expensify/App/pull/47819
cc: @rushatgabhane @cead22
@etCoderDysto's proposal looks good to me ππΌ
Job added to Upwork: https://www.upwork.com/jobs/~01e55f0f655d87efe9
Triggered auto assignment to Contributor-plus team member for initial proposal review - @akinwale (External
)
π£ @etCoderDysto π An offer has been automatically sent to your Upwork account for the Contributor role π Thanks for contributing to the Expensify app!
Offer link Upwork job Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review π§βπ» Keep in mind: Code of Conduct | Contributing π
Thanks! I will raise a PR in an hour.
π£ @shubham1206agra π An offer has been automatically sent to your Upwork account for the Contributor role π Thanks for contributing to the Expensify app!
Offer link Upwork job Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review π§βπ» Keep in mind: Code of Conduct | Contributing π
Assigning @shubham1206agra for C+ review
Reassigned the C+ since this was a regression:
https://expensify.slack.com/archives/C02NK2DQWUX/p1724769162552359
@etCoderDysto any updates on the PR just yet?
@etCoderDysto any updates on the PR just yet?
Sorry, I was on a road. I am working on the PR now. It will be ready for review under 30 minutes.
I confirmed this is fixed on staging. Thanks!
I think we are just waiting for this to be deployed to production in order to issue payment, but please correct me if I'm wrong.
@OfstadC this PR was cped on Aug 28. I think the automation is failing. It should be ready for payment.
Thanks for clarifying @etCoderDysto ! Sorry for the confusion here π
@OfstadC I did not reviewed the PR. @rushatgabhane did that as it was a regression from his PR.
no c+ pay due here π
Ah okay perfect! Thanks for letting me know @shubham1206agra!
If you havenβt already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
Version Number: v9.0.25-1 Reproducible in staging?: Y Reproducible in production?: N If this was caught during regression testing, add the test name, ID and link from TestRail: applausetester+kh050806@applause.expensifail.com Issue reported by: Applause Internal Team
Action Performed:
Expected Result:
"Default" label in the default tax code in the background will not change after changing tax code.
Actual Result:
"Default" label in the default tax code in the background changes to "Workspace currency default" briefly.
Workaround:
Unknown
Platforms:
Screenshots/Videos
https://github.com/user-attachments/assets/f915175d-0c36-4b38-9717-d9dec3518008
View all open jobs on GitHub
Upwork Automation - Do Not Edit
Issue Owner
Current Issue Owner: @akinwale