search

Expensify / App

Welcome to New Expensify: a complete re-imagination of financial collaboration, centered around chat. Help us build the next generation of Expensify by sharing feedback and contributing to the code.
https://new.expensify.com
MIT License
3.34k stars 2.77k forks source link

[Held requests] Workspace owes 0.00 is displayed on employee's LHN when partially approve report #48093

Open lanitochka17 opened 3 weeks ago

lanitochka17 commented 3 weeks ago

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

Version Number: 9.0.25-0 Reproducible in staging?: Y Reproducible in production?: Y If this was caught during regression testing, add the test name, ID and link from TestRail: https://expensify.testrail.io/index.php?/tests/view/4893676&group_by=cases:section_id&group_order=asc&group_id=309128 Email or phone of affected tester (no customers): gocemate+workspaceemployee165@gmail.com Issue reported by: Applause - Internal Team

Action Performed:

Precondition:

  1. Login as the owner of the workspace
  2. Invite the approver and employee to workspace
  3. Navigate to more features> Enable "workflows"
  4. On the "Workflow" editor - enable "Add Approvals"
  5. Set the Approver account as the Approver Steps:
  6. As Employee submit 2 expenses into workspace chat
  7. As Approver, put one of the requests on Hold
  8. As Approver, partially approve the report
  9. Take a look at LHN expense that is on hold from employee side

Expected Result:

Correct amount should be displayed

Actual Result:

Workspace owes 0.00 is displayed on employee's LHN when approver partially approve report

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

Screenshots/Videos

Add any screenshot/video evidence

https://github.com/user-attachments/assets/43d9d140-7955-4f4b-b1c7-45a9d416e1fb

View all open jobs on GitHub

melvin-bot[bot] commented 3 weeks ago

Triggered auto assignment to @JmillsExpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

FitseTLT commented 3 weeks ago

BE is returning wrong lastMessageText Control owes Br 0.00 Should be fixed in BE.

melvin-bot[bot] commented 2 weeks ago

@JmillsExpensify Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

melvin-bot[bot] commented 2 weeks ago

@JmillsExpensify Still overdue 6 days?! Let's take care of this!

JmillsExpensify commented 1 week ago

Agree that this is internal. @robertjchen do we not already have an existing issue for this one?

robertjchen commented 1 week ago

Yes, I think we've addressed this a week ago- I'lll confirm

melvin-bot[bot] commented 1 week ago

@JmillsExpensify Eep! 4 days overdue now. Issues have feelings too...

robertjchen commented 1 week ago

Adding to main issue update and handling this week

robertjchen commented 5 days ago

It appears a crucial Oynx update isn't making it to the employee after approval- should hopefully be a quick one, checking this out tomorrow.

robertjchen commented 1 day ago

Was able to reproduce this issue locally, working on a fix this week