Expensify / App

Welcome to New Expensify: a complete re-imagination of financial collaboration, centered around chat. Help us build the next generation of Expensify by sharing feedback and contributing to the code.
https://new.expensify.com
MIT License
3.33k stars 2.76k forks source link

[$250] iOS - Expense - Payment button shows black gradient #48103

Closed IuliiaHerets closed 3 days ago

IuliiaHerets commented 2 weeks ago

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 9.0.25-3 Reproducible in staging?: Y Reproducible in production?: N If this was caught during regression testing, add the test name, ID and link from TestRail: Exp https://expensify.testrail.io/index.php?/tests/view/4895183 Email or phone of affected tester (no customers): applausetester+kh05081@applause.expensifail.com Issue reported by: Applause Internal Team

Action Performed:

Updated reproduction steps here and listed below:

  1. Launch New Expensify app.
  2. Create a workspace.
  3. Connect it to QBO.
  4. Disable auto-sync.
  5. submit a report and pay it.
  6. Navigate to export button.

Expected Result:

Export button will not have black gradient.

Actual Result:

Export button shows black gradient.

Workaround:

Unknown

Platforms:

Screenshots/Videos

Bug6584280_1724773991771!IMG_4669

https://github.com/user-attachments/assets/318ab224-279b-422c-b5aa-1987a0728071

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~01c3743ad146431654
  • Upwork Job ID: 1828483486548366437
  • Last Price Increase: 2024-09-10
Issue OwnerCurrent Issue Owner: @dukenv0307
melvin-bot[bot] commented 2 weeks ago

Triggered auto assignment to @yuwenmemon (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

melvin-bot[bot] commented 2 weeks ago

Triggered auto assignment to @joekaufmanexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

github-actions[bot] commented 2 weeks ago

:wave: Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.
IuliiaHerets commented 2 weeks ago

We think that this bug might be related to #wave-collect - Release 1

melvin-bot[bot] commented 2 weeks ago

📣 @GoldenCaterpie! 📣 Hey, it seems we don’t have your contributor details yet! You'll only have to do this once, and this is how we'll hire you on Upwork. Please follow these steps:

  1. Make sure you've read and understood the contributing guidelines.
  2. Get the email address used to login to your Expensify account. If you don't already have an Expensify account, create one here. If you have multiple accounts (e.g. one for testing), please use your main account email.
  3. Get the link to your Upwork profile. It's necessary because we only pay via Upwork. You can access it by logging in, and then clicking on your name. It'll look like this. If you don't already have an account, sign up for one here.
  4. Copy the format below and paste it in a comment on this issue. Replace the placeholder text with your actual details. Screen Shot 2022-11-16 at 4 42 54 PM Format:
    Contributor details
    Your Expensify account email: <REPLACE EMAIL HERE>
    Upwork Profile Link: <REPLACE LINK HERE>
caineblood commented 2 weeks ago

The above comment asking you to download a file is malware to steal your account; do not under any circumstances download or run it. The post needs to be removed. If you have attempted to run it please have your system cleaned and your account secured immediately.

melvin-bot[bot] commented 2 weeks ago

📣 @caineblood! 📣 Hey, it seems we don’t have your contributor details yet! You'll only have to do this once, and this is how we'll hire you on Upwork. Please follow these steps:

  1. Make sure you've read and understood the contributing guidelines.
  2. Get the email address used to login to your Expensify account. If you don't already have an Expensify account, create one here. If you have multiple accounts (e.g. one for testing), please use your main account email.
  3. Get the link to your Upwork profile. It's necessary because we only pay via Upwork. You can access it by logging in, and then clicking on your name. It'll look like this. If you don't already have an account, sign up for one here.
  4. Copy the format below and paste it in a comment on this issue. Replace the placeholder text with your actual details. Screen Shot 2022-11-16 at 4 42 54 PM Format:
    Contributor details
    Your Expensify account email: <REPLACE EMAIL HERE>
    Upwork Profile Link: <REPLACE LINK HERE>
joekaufmanexpensify commented 2 weeks ago

@caineblood Thanks for flagging! We have removed that user from being able to interact with GH issues.

melvin-bot[bot] commented 2 weeks ago

Job added to Upwork: https://www.upwork.com/jobs/~01c3743ad146431654

melvin-bot[bot] commented 2 weeks ago

Triggered auto assignment to Contributor-plus team member for initial proposal review - @dukenv0307 (External)

bondydaa commented 2 weeks ago

@allroundexperts could you take a look here, we thought maybe it's related to this https://github.com/Expensify/App/pull/37174

we're having issues with some of our iOS sims locally so can you see if 1. you can reproduce on main and if so if 2. this revert fixes it? https://github.com/Expensify/App/pull/48117

bondydaa commented 2 weeks ago

oh I wonder if this is specific to dark mode? looking at the screenshots/video from https://github.com/Expensify/App/pull/37174#issuecomment-2309013800 thats in light mode 🤷

bondydaa commented 2 weeks ago

@IuliiaHerets can you re-test with light mode on and share the screenshots/videos?

IuliiaHerets commented 2 weeks ago

@bondydaa Done, issue also repro with a light mode, build v9.0.25-8 IMG_4689

https://github.com/user-attachments/assets/0ed04ca2-80c3-48d5-99b5-bf5f84d79a3a

yuwenmemon commented 2 weeks ago

Okay testing with the adhoc build in https://github.com/Expensify/App/pull/48117, the gradient does indeed go away:

Screenshot 1 Screenshot 2
IMG_5447 IMG_5449

Sorry folks, but it looks like we may need to revert, unless @IuliiaHerets or @brandonhenry want to take a stab at fixing it quick?

yuwenmemon commented 2 weeks ago

This has been deployed and is now fixed on staging.

lanitochka17 commented 2 weeks ago

Issue is still reproducible

https://github.com/user-attachments/assets/a2d52caa-08ab-4eaf-91a0-afbc0f2f7cc7

bondydaa commented 2 weeks ago

We're going to revert this revert PR since that didn't seem to actually fix this problem https://github.com/Expensify/App/pull/48117

I wonder if this is something related to the react native bump we had and a default style was updated?

I think we take this off of reviewing and see what contributors can figure out to fix this, though it seems it's hard to reproduce locally 🤷

bondydaa commented 1 week ago

curious @lanitochka17 is this only showing on Staging still? Or does it appear on production now?

I would assume it would be showing up on production by now if https://github.com/Expensify/App/pull/48117 wasn't the cause since we've done fully deploys since the revert anyways.

I wonder if this is something strange just happening on staging?

IuliiaHerets commented 1 week ago

@bondydaa Issue happens when the button has a dropdown. It requires different repro steps now. You can connect to QBO and disable Auto sync then it can repro with the Export button with dropdown. Stg and prod - the same. IMG_7FC5080A4C91-1 (1)

https://github.com/user-attachments/assets/a6915c4f-b2b6-4afc-a5fa-a1fcb068c5f0

melvin-bot[bot] commented 1 week ago

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

bondydaa commented 1 week ago

Ah thank you!

joekaufmanexpensify commented 4 days ago

Still waiting for proposals. Updated reproduction steps and posted in slack here!

melvin-bot[bot] commented 3 days ago

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

HezekielT commented 3 days ago

@joekaufmanexpensify I was not able to reproduce this issue on the latest main.

Screenshot 2024-09-10 at 7 19 22 in the evening
joekaufmanexpensify commented 3 days ago

Got it. @IuliiaHerets are you still able to reproduce this?

melvin-bot[bot] commented 3 days ago

@yuwenmemon @joekaufmanexpensify @dukenv0307 this issue was created 2 weeks ago. Are we close to approving a proposal? If not, what's blocking us from getting this issue assigned? Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!

yuwenmemon commented 3 days ago

I was not able to reproduce this time.

joekaufmanexpensify commented 3 days ago

Same, I can't reproduce either. Closing for now as this doesn't appear to be consistently reproducible any longer.