Closed IuliiaHerets closed 3 days ago
Triggered auto assignment to @yuwenmemon (DeployBlockerCash
), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.
Triggered auto assignment to @joekaufmanexpensify (Bug
), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.
:wave: Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
We think that this bug might be related to #wave-collect - Release 1
📣 @GoldenCaterpie! 📣 Hey, it seems we don’t have your contributor details yet! You'll only have to do this once, and this is how we'll hire you on Upwork. Please follow these steps:
Contributor details
Your Expensify account email: <REPLACE EMAIL HERE>
Upwork Profile Link: <REPLACE LINK HERE>
The above comment asking you to download a file is malware to steal your account; do not under any circumstances download or run it. The post needs to be removed. If you have attempted to run it please have your system cleaned and your account secured immediately.
📣 @caineblood! 📣 Hey, it seems we don’t have your contributor details yet! You'll only have to do this once, and this is how we'll hire you on Upwork. Please follow these steps:
Contributor details
Your Expensify account email: <REPLACE EMAIL HERE>
Upwork Profile Link: <REPLACE LINK HERE>
@caineblood Thanks for flagging! We have removed that user from being able to interact with GH issues.
Job added to Upwork: https://www.upwork.com/jobs/~01c3743ad146431654
Triggered auto assignment to Contributor-plus team member for initial proposal review - @dukenv0307 (External
)
@allroundexperts could you take a look here, we thought maybe it's related to this https://github.com/Expensify/App/pull/37174
we're having issues with some of our iOS sims locally so can you see if 1. you can reproduce on main
and if so if 2. this revert fixes it? https://github.com/Expensify/App/pull/48117
oh I wonder if this is specific to dark mode? looking at the screenshots/video from https://github.com/Expensify/App/pull/37174#issuecomment-2309013800 thats in light mode 🤷
@IuliiaHerets can you re-test with light mode on and share the screenshots/videos?
@bondydaa Done, issue also repro with a light mode, build v9.0.25-8
https://github.com/user-attachments/assets/0ed04ca2-80c3-48d5-99b5-bf5f84d79a3a
Okay testing with the adhoc build in https://github.com/Expensify/App/pull/48117, the gradient does indeed go away:
Screenshot 1 | Screenshot 2 |
---|---|
Sorry folks, but it looks like we may need to revert, unless @IuliiaHerets or @brandonhenry want to take a stab at fixing it quick?
This has been deployed and is now fixed on staging.
Issue is still reproducible
https://github.com/user-attachments/assets/a2d52caa-08ab-4eaf-91a0-afbc0f2f7cc7
We're going to revert this revert PR since that didn't seem to actually fix this problem https://github.com/Expensify/App/pull/48117
I wonder if this is something related to the react native bump we had and a default style was updated?
I think we take this off of reviewing
and see what contributors can figure out to fix this, though it seems it's hard to reproduce locally 🤷
curious @lanitochka17 is this only showing on Staging still? Or does it appear on production now?
I would assume it would be showing up on production by now if https://github.com/Expensify/App/pull/48117 wasn't the cause since we've done fully deploys since the revert anyways.
I wonder if this is something strange just happening on staging?
@bondydaa Issue happens when the button has a dropdown. It requires different repro steps now. You can connect to QBO and disable Auto sync then it can repro with the Export button with dropdown. Stg and prod - the same.
https://github.com/user-attachments/assets/a6915c4f-b2b6-4afc-a5fa-a1fcb068c5f0
📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸
Ah thank you!
Still waiting for proposals. Updated reproduction steps and posted in slack here!
📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸
@joekaufmanexpensify I was not able to reproduce this issue on the latest main.
Got it. @IuliiaHerets are you still able to reproduce this?
@yuwenmemon @joekaufmanexpensify @dukenv0307 this issue was created 2 weeks ago. Are we close to approving a proposal? If not, what's blocking us from getting this issue assigned? Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!
I was not able to reproduce this time.
Same, I can't reproduce either. Closing for now as this doesn't appear to be consistently reproducible any longer.
If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
Version Number: 9.0.25-3 Reproducible in staging?: Y Reproducible in production?: N If this was caught during regression testing, add the test name, ID and link from TestRail: Exp https://expensify.testrail.io/index.php?/tests/view/4895183 Email or phone of affected tester (no customers): applausetester+kh05081@applause.expensifail.com Issue reported by: Applause Internal Team
Action Performed:
Updated reproduction steps here and listed below:
Expected Result:
Export button will not have black gradient.
Actual Result:
Export button shows black gradient.
Workaround:
Unknown
Platforms:
Screenshots/Videos
https://github.com/user-attachments/assets/318ab224-279b-422c-b5aa-1987a0728071
View all open jobs on GitHub
Upwork Automation - Do Not Edit
Issue Owner
Current Issue Owner: @dukenv0307