[$250] iOS - Distance - Center button icon is not centered

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.0.25-3 Reproducible in staging?: Y Reproducible in production?: N If this was caught during regression testing, add the test name, ID and link from TestRail: N/A Email or phone of affected tester (no customers): applausetester+kh05081@applause.expensifail.com Issue reported by: Applause - Internal Team

Action Performed:

1. Launch New Expensify app
2. Go to FAB > Submit expense
3. Go to Distance

Expected Result:

Center button icon will be centered

Actual Result:

Center button icon is not centered

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• [ ] Android: Native
• [ ] Android: mWeb Chrome
• [x] iOS: Native
• [ ] iOS: mWeb Safari
• [ ] MacOS: Chrome / Safari
• [ ] MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~018cfba37db6e03a8f
• Upwork Job ID: 1828533917426975142
• Last Price Increase: 2024-08-27
• Automatic offers:
• Nodebrute | Contributor | 103709522

Issue Owner

Current Issue Owner: @CortneyOfstad

[melvin-bot[bot]]

Triggered auto assignment to @bondydaa (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[github-actions[bot]]

:wave: Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[melvin-bot[bot]]

Job added to Upwork: https://www.upwork.com/jobs/~018cfba37db6e03a8f

[melvin-bot[bot]]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @abdulrahuman5196 (External)

[Nodebrute]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Distance - Center button icon is not centered

What is the root cause of that problem?

We are adding extra margin here https://github.com/Expensify/App/blob/e5b6cef118381ce7eb273a722f45cca92e7010fd/src/components/MapView/MapView.tsx#L285C28-L285C52

What changes do you think we should make in order to solve the problem?

We should remove this extra margin https://github.com/Expensify/App/blob/e5b6cef118381ce7eb273a722f45cca92e7010fd/src/components/MapView/MapView.tsx#L285C28-L285C52 Result:

What alternative solutions did you explore? (Optional)

[bondydaa]

this is most likely caused b/c we updated RN versions which also bumped the mapbox version so not exactly sure if we have some custom styles being applied that just need modifying or what.

context pr https://github.com/Expensify/App/pull/45289/

[Nodebrute]

@bondydaa bump on this proposal: https://github.com/Expensify/App/issues/48120#issuecomment-2313504346

[melvin-bot[bot]]

📣 @Nodebrute 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!

Offer link Upwork job Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻 Keep in mind: Code of Conduct | Contributing 📖

[Nodebrute]

The Pr is ready for review https://github.com/Expensify/App/pull/48125

[Nodebrute]

This was deployed to production in v9.0.26-6. Payment is due 2024-09-06.

[bondydaa]

oh just realizing there is no Bug assignment here so adding that to get someone on it to pay out.

[melvin-bot[bot]]

Triggered auto assignment to @CortneyOfstad (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[bondydaa]

@CortneyOfstad believe payment is due tomorrow, i don't think the automation ran b/c bug was missing

[CortneyOfstad]

Payment Summary

@Nodebrute — paid $250 via Upwork @abdulrahuman5196 — to be paid $250 via NewDot