[HOLD for Payment 2024-09-19][Search v2.1] Set currently applied filters on Advanced Filters Page upon clicking Filters Button

[289Adam289]

Coming from here

Problem

• When clicking on a Filter Button currently applied filters are not maintained

• Type and Status filters are not accessible in Advanced filters Page

  Solution

  • Store filters present in url upon clicking Filters Button

cc @luacmartins @Kicu

Issue Owner

Current Issue Owner: @RachCHopkins

[melvin-bot[bot]]

Triggered auto assignment to @RachCHopkins (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[rayane-djouah]

Not overdue, PR in progress

[luacmartins]

PR merged

[rayane-djouah]

[!NOTE] The production deploy automation failed: This should be on [HOLD for Payment 2024-09-19] according to https://github.com/Expensify/App/issues/49025 production deploy checklist, confirmed in https://github.com/Expensify/App/pull/48312#issuecomment-2347262575

[RachCHopkins]

@rayane-djouah can I just confirm this is $250 each for you and @289Adam289, and there are no regression tests to add?

If so, I'll whip up Offers in Upwork tomorrow.

Edit: Looks like @289Adam289 is SWM, so just an offer for @rayane-djouah

[luacmartins]

@289Adam289 is from SWM and will get paid separately. No regressions tests to add this time, we'll handle it as part of the project wrap up.

[RachCHopkins]

Does that mean it's $250 for @rayane-djouah then @luacmartins ?

[luacmartins]

Yes

[RachCHopkins]

@rayane-djouah I've just sent you the offer!

[melvin-bot[bot]]

@luacmartins, @RachCHopkins, @rayane-djouah, @289Adam289 Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[rayane-djouah]

@RachCHopkins, I have reviewed two PRs linked to this issue: - https://github.com/Expensify/App/pull/47918 - https://github.com/Expensify/App/pull/48312

According to the process outlined here, the default payment for each PR review is $250. Therefore, the total for this issue should be $500.

I've accepted the offer, Thank you!

[RachCHopkins]

@luacmartins can you please just give that a 👍🏼 before I pay it? i.e. that the offer/payment total should be $500?

[luacmartins]

@rayane-djouah https://github.com/Expensify/App/pull/47918 is linked to https://github.com/Expensify/App/issues/47497 and payment for that issue was already processed. Did you mean to link a different PR above?

[rayane-djouah]

Oh my bad 🤦‍♂️ I apologize for the oversight. I mistakenly thought that https://github.com/Expensify/App/pull/47918 was related to this issue based on the issue references above.

Screenshot

I should have double-checked. Please ignore my previous comment; the payment should be a standard $250.

@luacmartins Thank you for correcting me!

[luacmartins]

Np! Just wanted to check in case you had an incorrect link. Thanks for confirming. @RachCHopkins seems like $250 it is.

[RachCHopkins]

Thanks team! Will handle that now.

Payment Summary:

Contributor: @289Adam289 - No external payment Contributor+: @rayane-djouah to be paid $250 via Upwork Upwork job here

[RachCHopkins]

Contributor has been paid, the contract has been completed, and the Upwork post has been closed.