search

Expensify / App

Welcome to New Expensify: a complete re-imagination of financial collaboration, centered around chat. Help us build the next generation of Expensify by sharing feedback and contributing to the code.
https://new.expensify.com
MIT License
3.33k stars 2.76k forks source link

[$250] [Android] When App is opened from notification the top safe area is missing #48190

Open mountiny opened 2 weeks ago

mountiny commented 2 weeks ago

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

Version Number: v9.0.25-11 Reproducible in staging?: Y Reproducible in production?: N If this was caught during regression testing, add the test name, ID and link from TestRail: Email or phone of affected tester (no customers): Logs: https://stackoverflow.com/c/expensify/questions/4856 Expensify/Expensify Issue URL: Issue reported by: @shubham1206agra Slack conversation:

Action Performed:

Break down in numbered steps

  1. [User A] Send a message to user B with chat history
  2. [User B] Open the notification received.

Expected Result:

Describe what you think should've happened

There is a safe padding at the top of the app for status bar

Actual Result:

Describe what actually happened

There is no safe padding

Workaround:

Can the user still use Expensify without this being fixed? Have you informed them of the workaround?

You have to close and reopen the app again

Platforms:

Which of our officially supported platforms is this issue occurring on?

Screenshots/Videos

Add any screenshot/video evidence

image

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~015d43274e3d80ec35
  • Upwork Job ID: 1828856156434772354
  • Last Price Increase: 2024-09-11
Issue OwnerCurrent Issue Owner: @jayeshmangwani
melvin-bot[bot] commented 2 weeks ago

Triggered auto assignment to @francoisl (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

melvin-bot[bot] commented 2 weeks ago

Triggered auto assignment to @puneetlath (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

github-actions[bot] commented 2 weeks ago

:wave: Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.
francoisl commented 2 weeks ago

I'm having a hard time running the app in an Android virtual device at the moment, going to open externally to see if anyone can figure it out.

melvin-bot[bot] commented 2 weeks ago

Job added to Upwork: https://www.upwork.com/jobs/~015d43274e3d80ec35

melvin-bot[bot] commented 2 weeks ago

Triggered auto assignment to Contributor-plus team member for initial proposal review - @jayeshmangwani (External)

francoisl commented 2 weeks ago

I'm now able to build the app locally in dev, but running into issues getting system notifications to show up at all.

One interesting thing I noticed with the app on my physical device is that I randomly opened it (manually, without tapping a notification), and the top padding was also missing until I killed and reopened the app.

I can't reproduce anymore after closing and reopening the app multiple times though, so I feel like there might be other conditions for this to happen.

francoisl commented 2 weeks ago

Going to demote as discussed in https://expensify.slack.com/archives/C01GTK53T8Q/p1724857609487429, since we can't consistently reproduce.

WoLewicki commented 2 weeks ago

I'm now able to build the app locally in dev, but running into issues getting system notifications to show up at all. One interesting thing I noticed with the app on my physical device is that I randomly opened it (manually, without tapping a notification), and the top padding was also missing until I killed and reopened the app.

@francoisl could you tell if this happened on dev or only on release? I was not able to reproduce it on dev.

francoisl commented 2 weeks ago

On my physical device? It was a staging release version, at the time 9.0.25-1 (the latest staging version was greater than that, but I guess my phone had not auto-updated the app yet)

melvin-bot[bot] commented 1 week ago

@puneetlath, @francoisl, @jayeshmangwani Whoops! This issue is 2 days overdue. Let's get this updated quick!

jayeshmangwani commented 1 week ago

Not Overdue, We're still awaiting proposals here

jayeshmangwani commented 1 week ago

@shubham1206agra since you originally reported this issue, I just want to confirm if it’s still happening for you on the latest version.

shubham1206agra commented 1 week ago

I am unable to use the notification. So I am not sure.

puneetlath commented 1 week ago

It seems to still be happening in some scenarios: https://github.com/Expensify/App/issues/48477. It doesn't seem to necessarily only have to do with notifications as @francoisl experienced it as well and it wasn't from a notification.

jayeshmangwani commented 1 week ago

It doesn't seem to necessarily only have to do with notifications

I haven't been able to reproduce this issue yet, even after trying with two Android devices (Samsung and Realme). Let's see if anyone can provide steps to consistently reproduce the issue.

melvin-bot[bot] commented 1 week ago

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

shubham1206agra commented 1 week ago

image

I just repro'd this accidentally again.

shubham1206agra commented 4 days ago

I am now able to consistently able to repro this issue as I got access to notification.

melvin-bot[bot] commented 4 days ago

@puneetlath, @francoisl, @jayeshmangwani Huh... This is 4 days overdue. Who can take care of this?

puneetlath commented 3 days ago

@shubham1206agra are there any specific steps to repro? Also, what device?

shubham1206agra commented 3 days ago

Also, what device?

Redmi K50i

shubham1206agra commented 3 days ago

are there any specific steps to repro?

Steps provided above only.

melvin-bot[bot] commented 2 days ago

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

puneetlath commented 2 days ago

@perunt has said he'll help look into this one.

melvin-bot[bot] commented 2 days ago

@puneetlath @francoisl @jayeshmangwani this issue was created 2 weeks ago. Are we close to approving a proposal? If not, what's blocking us from getting this issue assigned? Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!

melvin-bot[bot] commented 2 days ago

@puneetlath, @francoisl, @jayeshmangwani 6 days overdue. This is scarier than being forced to listen to Vogon poetry!

jayeshmangwani commented 2 days ago

Not overdue; the latest update is here

jayeshmangwani commented 2 days ago

I was also able to reproduce this issue using the description steps, but for some reason, I am not receiving notifications on my Android devices today