[READY FOR PAYMENT][$250] Can not select 'Payment account' in Workflow Page

[m-natarajan]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.0.25-14 Reproducible in staging?: Y Reproducible in production?: Y If this was caught during regression testing, add the test name, ID and link from TestRail: Email or phone of affected tester (no customers): Logs: https://stackoverflow.com/c/expensify/questions/4856 Expensify/Expensify Issue URL: Issue reported by: @dukenv0307 Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1724786774524009

Action Performed:

1. Go to a workspace
2. Enable Workflow
3. Connect bank account
4. Place the mouse cursor below the text 'Payment account'
5. Click 3 times to select

   Expected Result:

   Can select all 'Payment Account' text

   Actual Result:

   Text in bank account selected

   Workaround:

   Unknown

   Platforms:

   Which of our officially supported platforms is this issue occurring on?

   • [ ] Android: Native
   • [ ] Android: mWeb Chrome
   • [ ] iOS: Native
   • [ ] iOS: mWeb Safari
   • [x] MacOS: Chrome / Safari
   • [ ] MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

https://github.com/user-attachments/assets/5263ffd9-ad05-4145-bda5-7b68f310378c

https://github.com/user-attachments/assets/38405bc0-7863-44ba-a48f-26ecb1f131fa

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021831332987291555271
• Upwork Job ID: 1831332987291555271
• Last Price Increase: 2024-09-04
• Automatic offers:
• dukenv0307 | Reviewer | 103830400

Issue Owner

Current Issue Owner: @

Issue Owner

Current Issue Owner: @JmillsExpensify

[melvin-bot[bot]]

Triggered auto assignment to @JmillsExpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[daledah]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Text in bank account selected

What is the root cause of that problem?

Currently, we have styles with negative margins here, and the margin of the bank account is overlapping the text 'Payment account'.

What changes do you think we should make in order to solve the problem?

1. We should remove negative margins here

       <View style={[styles.sectionMenuItemTopDescription, styles.mt5, styles.pb1, styles.pt1]}>

2. And also remove extra margin top here

       wrapperStyle={[styles.sectionMenuItemTopDescription, styles.mbn3]}

What alternative solutions did you explore? (Optional)

Result:

https://github.com/user-attachments/assets/89f0b78e-cda9-4b59-9631-f7532c32550d

[dukenv0307]

I report this bug so I can take it as C+

[melvin-bot[bot]]

@JmillsExpensify Eep! 4 days overdue now. Issues have feelings too...

[melvin-bot[bot]]

Job added to Upwork: https://www.upwork.com/jobs/~021831332987291555271

[melvin-bot[bot]]

Current assignee @dukenv0307 is eligible for the External assigner, not assigning anyone new.

[JmillsExpensify]

Nice, I went ahead and opened it up.

[dukenv0307]

@daledah's proposal LGTM

🎀👀🎀 C+ reviewed

[melvin-bot[bot]]

Triggered auto assignment to @dangrous, see https://stackoverflow.com/c/expensify/questions/7972 for more details.

[dangrous]

Seems fine to me! I'll assign but also want to ping @Expensify/design for a quick look too to make sure we're not undoing some specific reasoning for the negative margin.

[melvin-bot[bot]]

📣 @dukenv0307 🎉 An offer has been automatically sent to your Upwork account for the Reviewer role 🎉 Thanks for contributing to the Expensify app!

Offer link Upwork job

[melvin-bot[bot]]

📣 @daledah You have been assigned to this job! Please apply to the Upwork job and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻 Once you apply to this job, your Upwork ID will be stored and you will be automatically hired for future jobs! Keep in mind: Code of Conduct | Contributing 📖

[dannymcclain]

I think as long as the spacing stays correct, and the hover state for the option row still works normally, I don't see any problem.

[shawnborton]

Works for me. I think we should drop the bounty down to $125 though, this is such an edge case bug that really impacts absolutely zero people or customers.

[daledah]

@dukenv0307 PR is ready

[JmillsExpensify]

Let's keep it at $250 since the proposal has already been reviewed/approved and this is the default price.

[dangrous]

This never got the "deployed to production" comment on the PR but it was in a checklist... It has to have been deployed by now, right? Were there some that were missing the automations recently? If so I think we must be almost ready for payment if not ready already. cc @JmillsExpensify

[dangrous]

~Oh actually weird, I just checked out the production branch and it's NOT there, nor is it on main. But it was definitely merged. Not sure what's up there~

EDIT: I was wrong, it IS on production, but half of it was undone by https://github.com/Expensify/App/pull/49024 . The bug still seems to be fixed though

[dangrous]

I'm going ahead and marking this as ready for payment, it's been at least 6 days and I'm like 95% sure it's been more like 2 weeks.