[$250] Tags - App closes RHP after upgrade and clicking back button in GL code page

IuliiaHerets commented 3 weeks ago

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

Version Number: v9.0.25-10 Reproducible in staging?: Y Reproducible in production?: Y Email or phone of affected tester (no customers): applausetester+kh050806@applause.expensifail.com Issue reported by: Applause Internal Team

Action Performed:

Go to staging.new.expensify.com
Create a Collect workspace.
Go to Categories.
Click on any category > GL code/Payroll code.
Click Upgrade > Click Got it, thanks.
On the code editor page, click on the app back button.
Note that app returns to category details RHP.
Create a Collect workspace.
Go to Tags.
Add a tag > Click on tag > GL code.
Click Upgrade > Click Got it, thanks.
On the code editor page, click on the app back button.

Expected Result:

App will return to tag details RHP after upgrade and clicking back button in GL code page.

Actual Result:

App closes RHP after upgrade and clicking back button in GL code page.

Workaround:

Unknown

Platforms:

[x] Android: Native
[x] Android: mWeb Chrome
[x] iOS: Native
[x] iOS: mWeb Safari
[x] MacOS: Chrome / Safari
[x] MacOS: Desktop

Screenshots/Videos

https://github.com/user-attachments/assets/56a2a78c-4564-4cd5-961a-d4cc2b8cccc6

View all open jobs on GitHub

Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~01b3d86efe655bb313
Upwork Job ID: 1829329439413113957
Last Price Increase: 2024-08-30
Automatic offers:

ZhenjaHorbach | Reviewer | 103806540
Krishna2323 | Contributor | 103806542

Issue Owner

Current Issue Owner: @ZhenjaHorbach

melvin-bot[bot] commented 3 weeks ago

Triggered auto assignment to @stephanieelliott (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

IuliiaHerets commented 3 weeks ago

We think that this bug might be related to #wave-control

IuliiaHerets commented 3 weeks ago

@stephanieelliott FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

Krishna2323 commented 3 weeks ago

Edited by proposal-police: This proposal was edited at 2023-10-17T11:45:00Z.

Proposal

Please re-state the problem that we are trying to solve in this issue.

Tags - App closes RHP after upgrade and clicking back button in GL code page

What is the root cause of that problem?

We aren't passing the fallback route to goBack. https://github.com/Expensify/App/blob/392da13fc53b82e1f83baf676a3dff7fc081c92e/src/pages/workspace/tags/TagGLCodePage.tsx#L68

What changes do you think we should make in order to solve the problem?

Pass ROUTES.WORKSPACE_TAG_SETTINGS.getRoute(route.params.policyID, orderWeight, tagName) as the fallback route to the goBack function.
We should also look for similar inconsistencies and should fix those as well.
What alternative solutions did you explore? (Optional)

Result

abzokhattab commented 3 weeks ago

Edited by proposal-police: This proposal was edited at 2023-10-11T13:45:00Z.

Proposal

Please re-state the problem that we are trying to solve in this issue.

App closes RHP after upgrade and clicking back button in GL code page

What is the root cause of that problem?

The fallback route is not passed to the goBack function in this https://github.com/Expensify/App/blob/392da13fc53b82e1f83baf676a3dff7fc081c92e/src/pages/workspace/tags/TagGLCodePage.tsx#L68
To resolve this, we should apply the same goBack logic in the submit logic

What changes do you think we should make in order to solve the problem?

To ensure consistency, since the back behavior is the same for both the submit and back buttons, we should create a goBack function and use it in both locations instead of duplicating the code.
This approach should also be applied to the CategoryPayrollCodePage.

What alternative solutions did you explore? (Optional)

N.A

melvin-bot[bot] commented 3 weeks ago

Job added to Upwork: https://www.upwork.com/jobs/~01b3d86efe655bb313

melvin-bot[bot] commented 3 weeks ago

Triggered auto assignment to Contributor-plus team member for initial proposal review - @ZhenjaHorbach (External)

ZhenjaHorbach commented 2 weeks ago

I will check proposals today or tomorrow !

ZhenjaHorbach commented 2 weeks ago

@Krishna2323 @abzokhattab

Thanks for your proposals ! Your proposals are correct but similar So I will choose first one

🎀👀🎀 C+ reviewed

melvin-bot[bot] commented 2 weeks ago

Triggered auto assignment to @MonilBhavsar, see https://stackoverflow.com/c/expensify/questions/7972 for more details.

trjExpensify commented 2 weeks ago

CC: @garrettmknight @allroundexperts upgrades related!

melvin-bot[bot] commented 2 weeks ago

@stephanieelliott, @MonilBhavsar, @ZhenjaHorbach Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

stephanieelliott commented 2 weeks ago

Hey @MonilBhavsar can you confirm the proposal selected here?

MonilBhavsar commented 2 weeks ago

Looks good!

melvin-bot[bot] commented 2 weeks ago

📣 @ZhenjaHorbach 🎉 An offer has been automatically sent to your Upwork account for the Reviewer role 🎉 Thanks for contributing to the Expensify app!

Offer link Upwork job

melvin-bot[bot] commented 2 weeks ago

📣 @Krishna2323 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!

Offer link Upwork job Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻 Keep in mind: Code of Conduct | Contributing 📖

Krishna2323 commented 2 weeks ago

@ZhenjaHorbach, PR ready for review ^

stephanieelliott commented 1 week ago

PR was merged to main 🎉

ZhenjaHorbach commented 2 days ago

Looks like automation failed here, and this PR was merged in Prod https://github.com/Expensify/App/issues/48664 on 09/09. So we are ready for payment !

ZhenjaHorbach commented 2 days ago

BugZero Checklist

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

[x] [@ZhenjaHorbach] The PR that introduced the bug has been identified. Link to the PR:

https://github.com/Expensify/App/pull/46617

[x] [ @ZhenjaHorbach] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:

https://github.com/Expensify/App/pull/46617/files#r1763836095

[x] [@ZhenjaHorbach] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:

NA

[x] [@ZhenjaHorbach] Determine if we should create a regression test for this bug.

[x] [@ZhenjaHorbach] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.

Regression Test Proposal

Create a Collect workspace.
Go to Tags.
Add a tag > Click on tag > GL code.
Click Upgrade > Click Got it, thanks.
On the code editor page, click on the app back button.
Verify app returns to tag details RHP after upgrade and clicking back button in GL code page.

Do we agree 👍 or 👎

Expensify / App