[$250] Track tax - Tax rate does not update when editing distance rate offline

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.0.26-2 Reproducible in staging?: Y Reproducible in production?: Y If this was caught during regression testing, add the test name, ID and link from TestRail: https://expensify.testrail.io/index.php?/tests/view/4902670 Email or phone of affected tester (no customers): applausetester+kh050806@applause.expensifail.com Issue reported by:Applause - Internal Team

Action Performed:

Precondition:

• Track tax is enabled.
• Workspace has at least two distance rates that have tax rate and tax reclaimable on
• Each distance rate has different tax rate
  1. Go to staging.new.expensify.com
  2. Go to workspace chat
  3. Submit a distance expense (for Step 8 )
  4. Go offline
  5. Start another submit distance flow and proceed to confirmation page
  6. Click Rate and select a different rate
  7. Note that Tax rate field still updates according to the selected distance rate in offline mode
  8. Go to the distance expense thread in Step 3
  9. Click Rate
  10. Select a different rate

Expected Result:

• Tax rate will update after changing distance rate offline in transaction thread, as it works on confirmation page (Step 7)
• Tax rate and tax amount field will gray out

Actual Result:

• Tax rate does not update after changing distance rate offline in transaction thread. The only thing that updates is the removal of "default" label in tax rate field
• Tax rate and tax amount field are not gray out

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• [x] Android: Native
• [x] Android: mWeb Chrome
• [x] iOS: Native
• [x] iOS: mWeb Safari
• [x] MacOS: Chrome / Safari
• [x] MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

https://github.com/user-attachments/assets/8b3c5a70-32ea-4bb2-bd98-bcbed30ee528

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01c25cfebc45c34fc3
• Upwork Job ID: 1830995712415705839
• Last Price Increase: 2024-09-10
• Automatic offers:
• Krishna2323 | Contributor | 103905995

Issue Owner

Current Issue Owner: @aimane-chnaif

[melvin-bot[bot]]

Triggered auto assignment to @bfitzexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[lanitochka17]

@bfitzexpensify FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

[Krishna2323]

Edited by proposal-police: This proposal was edited at 2024-08-30 00:03:36 UTC.

Proposal

Please re-state the problem that we are trying to solve in this issue.

Track tax - Tax rate does not update when editing distance rate offline

What is the root cause of that problem?

• We use getTaxName to get the tax and when distance transaction is created, the taxCode is filled by the backend. When we update the rate after the transaction is created, taxCode is used, which will be only updated the backend api call is successful. https://github.com/Expensify/App/blob/8c0386a562ac8ecdc0aa8e0496c8ed24971a5089/src/libs/TransactionUtils/index.ts#L885-L891
• This does not happen when we are creating a new distance request because in the transaction draft transaction?.taxCode is not present, so we are using the defaultTaxCode, getDefaultTaxCode will return the correct tax using the customUnitRateID. https://github.com/Expensify/App/blob/8c0386a562ac8ecdc0aa8e0496c8ed24971a5089/src/libs/TransactionUtils/index.ts#L836-L845

What changes do you think we should make in order to solve the problem?

• In selectDistanceRate, we are already calculating taxAmount and taxRateExternalID (taxCode), we can modify the updateMoneyRequestDistanceRate util function to accept 2 new parameters taxAmount and taxRateExternalID (taxCode). https://github.com/Expensify/App/blob/489312e0d75cbbbf5d0d78fae48bb37635f921d6/src/pages/iou/request/step/IOURequestStepDistanceRate.tsx#L88-L108
• Then from selectDistanceRate we will pass the taxAmount and taxRateExternalID (taxCode) to updateMoneyRequestDistanceRate.
• Update the transactionChanges object in updateMoneyRequestDistanceRate function to also include taxAmount & taxRate. https://github.com/Expensify/App/blob/489312e0d75cbbbf5d0d78fae48bb37635f921d6/src/libs/actions/IOU.ts#L3122-L3145
• This will also grey out the taxAmount & taxRate field without modifying the fields to look for change in customUnitRateID field.

Code changes

```javascript function selectDistanceRate(customUnitRateID: string) { let taxAmount; let taxRateExternalID; if (shouldShowTax) { const policyCustomUnitRate = getCustomUnitRate(policy, customUnitRateID); taxRateExternalID = policyCustomUnitRate?.attributes?.taxRateExternalID ?? '-1'; const taxableAmount = DistanceRequestUtils.getTaxableAmount(policy, customUnitRateID, TransactionUtils.getDistanceInMeters(transaction, unit)); const taxPercentage = TransactionUtils.getTaxValue(policy, transaction, taxRateExternalID) ?? ''; taxAmount = CurrencyUtils.convertToBackendAmount(TransactionUtils.calculateTaxAmount(taxPercentage, taxableAmount, rates[customUnitRateID].currency ?? CONST.CURRENCY.USD)); IOU.setMoneyRequestTaxAmount(transactionID, taxAmount); IOU.setMoneyRequestTaxRate(transactionID, taxRateExternalID); } if (currentRateID !== customUnitRateID) { IOU.setMoneyRequestDistanceRate(transactionID, customUnitRateID, policy?.id ?? '-1', !isEditing); if (isEditing) { IOU.updateMoneyRequestDistanceRate( transaction?.transactionID ?? '-1', reportID, customUnitRateID, policy, policyTags, policyCategories, shouldShowTax ? taxRateExternalID : transaction?.taxCode, shouldShowTax ? taxAmount : transaction?.taxAmount, ); } } navigateBack(); } function updateMoneyRequestDistanceRate( transactionID: string, transactionThreadReportID: string, rateID: string, policy: OnyxEntry, policyTagList: OnyxEntry, policyCategories: OnyxEntry, taxCode?: string, taxAmount?: number, ) { const transactionChanges: TransactionChanges = { customUnitRateID: rateID, ...(taxCode ? {taxCode} : {}), ...(taxAmount ? {taxAmount} : {}), }; // ... } ```

What alternative solutions did you explore? (Optional)



We can do few things here:

• If the transaction is a distance request then use defaultTaxCode as the primary value.
• If the transaction is a distance request and has pending action for customUnitRateID then use defaultTaxCode as the primary value..
• We can also create a function for the above steps.
• To grey out the taxRate and taxAmount fields we can check if the request is of type distance and if true we will also use customUnitRateID for pending action.

  <OfflineWithFeedback pendingAction={isDistanceRequest ? getPendingFieldAction('taxCode') ?? getPendingFieldAction('customUnitRateID') : getPendingFieldAction('taxCode')}>

  https://github.com/Expensify/App/blob/8c0386a562ac8ecdc0aa8e0496c8ed24971a5089/src/components/ReportActionItem/MoneyRequestView.tsx#L620-L651

Result

[Krishna2323]

Proposal Updated

• Added alternative

[nkdengineer]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Tax rate does not update after changing distance rate offline in transaction thread. The only thing that updates is the removal of "default" label in tax rate field Tax rate and tax amount field are not gray out

What is the root cause of that problem?

Tax rate does not update after changing distance rate offline in transaction thread. The only thing that updates is the removal of "default" label in tax rate field

1. We have the logic here to update the tax rate and tax amount when we update the distance rate if tax tracking is enabled. It updates the draft transaction data used in the create flow.

https://github.com/Expensify/App/blob/489312e0d75cbbbf5d0d78fae48bb37635f921d6/src/pages/iou/request/step/IOURequestStepDistanceRate.tsx#L88-L97

When we're in the edit flow, we don't update the tax rate and tax amount in optimistic data in getUpdateMoneyRequestParams function

Tax rate and tax amount field are not gray out

Tax rate/tax amount is only grayed out if we have pending action on tax rate/tax amount https://github.com/Expensify/App/blob/489312e0d75cbbbf5d0d78fae48bb37635f921d6/src/components/ReportActionItem/MoneyRequestView.tsx#L621

https://github.com/Expensify/App/blob/489312e0d75cbbbf5d0d78fae48bb37635f921d6/src/components/ReportActionItem/MoneyRequestView.tsx#L637

What changes do you think we should make in order to solve the problem?

Tax rate will update after changing distance rate offline in transaction thread, as it works on confirmation page (Step 7)

For this bug, we can follow the same way we do in IOURequestStepDistanceRate to update the tax rate and tax amount in optimistic data when we edit the distance rate after creating. We can create a util

function getTaxRateAndTaxAmountForTrackTax(transaction: OnyxInputOrEntry<Transaction>, policy: OnyxInputOrEntry<Policy>, isPolicyExpenseChat: boolean, customUnitRateID = '') {
    if (!transaction || !policy || !customUnitRateID || !PolicyUtils.isTaxTrackingEnabled(isPolicyExpenseChat, policy, true)) {
        return {
            taxCode: undefined,
            taxAmount: undefined,
        };
    }

    const mileageRates = DistanceRequestUtils.getMileageRates(policy, true);
    const {unit} = mileageRates[customUnitRateID] ?? DistanceRequestUtils.getDefaultMileageRate(policy);
    const policyCustomUnitRate = getCustomUnitRate(policy, customUnitRateID);
    const taxRateExternalID = policyCustomUnitRate?.attributes?.taxRateExternalID ?? '-1';
    const taxableAmount = DistanceRequestUtils.getTaxableAmount(policy, customUnitRateID, getDistanceInMeters(transaction, unit));
    const taxPercentage = getTaxValue(policy, transaction ?? undefined, taxRateExternalID) ?? '';
    const taxAmount = convertToBackendAmount(calculateTaxAmount(taxPercentage, taxableAmount, mileageRates[customUnitRateID].currency ?? CONST.CURRENCY.USD));
    return {taxCode: taxRateExternalID, taxAmount};
}

https://github.com/Expensify/App/blob/489312e0d75cbbbf5d0d78fae48bb37635f921d6/src/pages/iou/request/step/IOURequestStepDistanceRate.tsx#L88-L97

const {taxCode, taxAmount} = getTaxRateAndTaxAmountForTrackTax(transaction, policy, isFromExpenseReport, customUnitRateID);

if (hasModifiedRouteWithPendingWaypoints || hasModifiedRateWithPendingWaypoints) {
    return {
        amount: CONST.IOU.DEFAULT_AMOUNT,
        modifiedAmount: CONST.IOU.DEFAULT_AMOUNT,
        modifiedMerchant: Localize.translateLocal('iou.fieldPending'),
        ...(taxCode ? {taxCode} : {}),
        ...(taxAmount ? {taxAmount} : {}),
    };
}

...

return {
    amount: updatedAmount,
    modifiedAmount: updatedAmount,
    modifiedMerchant: updatedMerchant,
    modifiedCurrency: updatedCurrency,
    ...(taxCode ? {taxCode} : {}),
    ...(taxAmount ? {taxAmount} : {}),
};

and use this in calculateAmountForUpdatedWaypointOrRate function

Tax rate and tax amount field will gray out

For this bug, we can check if the request is distance request we will add the fallback pending action for tax rate and tax amount with the pending action of distance rate here

<OfflineWithFeedback pendingAction={isDistanceRequest ? getPendingFieldAction('taxCode') ?? getPendingFieldAction('customUnitRateID') : getPendingFieldAction('taxCode')}>

https://github.com/Expensify/App/blob/489312e0d75cbbbf5d0d78fae48bb37635f921d6/src/components/ReportActionItem/MoneyRequestView.tsx#L621

<OfflineWithFeedback pendingAction={isDistanceRequest ? getPendingFieldAction('taxAmount') ?? getPendingFieldAction('customUnitRateID') : getPendingFieldAction('taxAmount')}>

https://github.com/Expensify/App/blob/489312e0d75cbbbf5d0d78fae48bb37635f921d6/src/components/ReportActionItem/MoneyRequestView.tsx#L637

What alternative solutions did you explore? (Optional)

NA

[Krishna2323]

Proposal Updated

• Added new solution in the main solution section & moved the previous one in alternative section.

[melvin-bot[bot]]

@bfitzexpensify Whoops! This issue is 2 days overdue. Let's get this updated quick!

[melvin-bot[bot]]

Job added to Upwork: https://www.upwork.com/jobs/~01c25cfebc45c34fc3

[melvin-bot[bot]]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @aimane-chnaif (External)

[aimane-chnaif]

Thanks for the proposals. Can you please share demo videos after applying your solution? Please make sure that Tax rate and tax amount field are not gray out bug is also fixed.

[Krishna2323]

@aimane-chnaif, test branch.

https://github.com/user-attachments/assets/d76bdde3-1cac-4804-a963-249fe155ba92

[nkdengineer]

@aimane-chnaif The result here.

https://github.com/user-attachments/assets/c6d0e61c-f512-439f-bee5-edcd8df4e896

[bfitzexpensify]

I am heading out of office until September 21st, so assigning a buddy to watch over this in my absence.

Current status: working through proposals

[melvin-bot[bot]]

Triggered auto assignment to @lschurr (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[melvin-bot[bot]]

@lschurr, @bfitzexpensify, @aimane-chnaif Whoops! This issue is 2 days overdue. Let's get this updated quick!

[trjExpensify]

@aimane-chnaif what do you think of these proposals? CC: @MonilBhavsar for eyes.

[melvin-bot[bot]]

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

[aimane-chnaif]

@Krishna2323's main solution looks good. 🎀👀🎀 C+ reviewed

[melvin-bot[bot]]

Triggered auto assignment to @marcaaron, see https://stackoverflow.com/c/expensify/questions/7972 for more details.

[melvin-bot[bot]]

📣 @Krishna2323 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!

Offer link Upwork job Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻 Keep in mind: Code of Conduct | Contributing 📖

[melvin-bot[bot]]

@marcaaron @lschurr @bfitzexpensify @Krishna2323 @aimane-chnaif this issue was created 2 weeks ago. Are we close to approving a proposal? If not, what's blocking us from getting this issue assigned? Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!

[Krishna2323]

@aimane-chnaif, PR ready for review ^