Expensify / App

Welcome to New Expensify: a complete re-imagination of financial collaboration, centered around chat. Help us build the next generation of Expensify by sharing feedback and contributing to the code.
https://new.expensify.com
MIT License
3.57k stars 2.91k forks source link

[Medium][$250] Book Travel - Unable to continue setting up travel, error appears #48305

Open IuliiaHerets opened 2 months ago

IuliiaHerets commented 2 months ago

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: v9.0.26-4 Reproducible in staging?: Y Reproducible in production?: Y Issue was found when executing this PR: https://github.com/Expensify/App/pull/47809 Issue reported by: Applause Internal Team

Action Performed:

Go to https://staging.new.expensify.com/ Create a brand new account. Green + > Book Travel Enter a company address -> Press Save Press Book Travel -> Accept the terms of service -> Press Continue

Expected Result:

Expensify Travel page opens

Actual Result:

Error appears and Unable to continue setting

Workaround:

Unknown

Platforms:

Screenshots/Videos

https://github.com/user-attachments/assets/80ecf02c-f920-499c-acbe-926cbaae39a0

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~01d6db9f1e6d7f6503
  • Upwork Job ID: 1829616128762264680
  • Last Price Increase: 2024-08-30
IuliiaHerets commented 2 months ago

We think that this bug might be related to #vip-travel

melvin-bot[bot] commented 2 months ago

Triggered auto assignment to @joekaufmanexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

IuliiaHerets commented 2 months ago

@joekaufmanexpensify FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

Nodebrute commented 2 months ago

It's a backend error User is not on Travel Beta

joekaufmanexpensify commented 2 months ago

Can't reproduce, works totally fine for me. Seems like the issue was @IuliiaHerets account is not on the beta.

joekaufmanexpensify commented 2 months ago

Discussing more here

joekaufmanexpensify commented 2 months ago

@IuliiaHerets I got the applause.expensifail.com domain added to the beta. Going to close this for now as I don't think there is a bug here, but please reopen if you're still experiencing an issue after retesting!

IuliiaHerets commented 2 months ago

@joekaufmanexpensify Issue still reproducible. Build - v9.0.26-4, account - applausetester+ihchat4_3008_appa@applause.expensifail.com

https://github.com/user-attachments/assets/50b2cae0-9693-492d-9132-bd76e1764eb4

joekaufmanexpensify commented 2 months ago

@IuliiaHerets can you try again in ~30 minutes? It can sometimes take an hour+ for the beta to take effect.

IuliiaHerets commented 2 months ago

@joekaufmanexpensify QA team noticed that the issue can be reproduced with fresh accounts, after refreshing the page it works well. Build - v9.0.26-5, account - applausetester+ihchat4_3008_123@applause.expensifail.com.

https://github.com/user-attachments/assets/a306c4e4-4e21-4233-8067-3976e1f6cc41

joekaufmanexpensify commented 2 months ago

Ah, yeah. I can reproduce it when I do this with a brand new account. And then no longer can after refreshing. That said, we should still fix this as feels reasonable that some people will try to use travel soon after creating their accounts.

https://github.com/user-attachments/assets/05b574b5-d77a-4b5a-9392-087d9cf5930c

melvin-bot[bot] commented 2 months ago

Job added to Upwork: https://www.upwork.com/jobs/~01d6db9f1e6d7f6503

melvin-bot[bot] commented 2 months ago

Triggered auto assignment to Contributor-plus team member for initial proposal review - @mananjadhav (External)

joekaufmanexpensify commented 2 months ago

@Nodebrute are you thinking the issue here is that the beta isn't kicking in for a new account right away or something like that? As i experienced this issue, but my account is on the beta.

Nodebrute commented 2 months ago

@joekaufmanexpensify This was the backend response User is not on Travel Beta. I’ll retest it to confirm.

Nodebrute commented 2 months ago

@joekaufmanexpensify I’m not on the beta, so the response remains the same even after refreshing the page.

Screenshot 2024-08-31 at 1 56 00 AM
joekaufmanexpensify commented 2 months ago

@mananjadhav curious if you agree that this is likely a backend issue?

joekaufmanexpensify commented 2 months ago

Bump @mananjadhav

mananjadhav commented 2 months ago

Sorry I missed this one. I'll check this in a few hours.

mananjadhav commented 2 months ago

@joekaufmanexpensify I am not on beta. I've requested for the access. @joekaufmanexpensify can you confirm if the user is on the beta and you attempted to book travel? What is the API error you see for AcceptSpotnanaTerms.

joekaufmanexpensify commented 2 months ago

@mananjadhav yep, my account is on the beta. Internal logs for it are here.

Error I see is 412 Can't provision Travel for the default workspace.

joekaufmanexpensify commented 2 months ago

Thinking this is an internal bug, but LMK if you disagree

mananjadhav commented 2 months ago

Yeah that looks like an internal bug.

joekaufmanexpensify commented 2 months ago

Searching for a volunteer here.

joekaufmanexpensify commented 2 months ago

Pending volunteer

joekaufmanexpensify commented 2 months ago

Still pending internal volunteer

joekaufmanexpensify commented 2 months ago

Same. This is High in the project, so I expect it will get a volunteer fairly soon

joekaufmanexpensify commented 2 months ago

Same

joekaufmanexpensify commented 2 months ago

Still pending internal volunteer

melvin-bot[bot] commented 2 months ago

@mananjadhav @joekaufmanexpensify this issue was created 2 weeks ago. Are we close to a solution? Let's make sure we're treating this as a top priority. Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!

joekaufmanexpensify commented 2 months ago

Still pending internal volunteer. Not too many high issues, so I expect it should get someone soon

joekaufmanexpensify commented 2 months ago

Same

joekaufmanexpensify commented 2 months ago

Same

joekaufmanexpensify commented 2 months ago

Pending internal volunteer

joekaufmanexpensify commented 2 months ago

Same

joekaufmanexpensify commented 2 months ago

Raised in slack again

joekaufmanexpensify commented 2 months ago

Changing to monthly as NewDot travel is not the priority right now.

joekaufmanexpensify commented 1 month ago

Held

joekaufmanexpensify commented 4 days ago

Same