Expensify / App

Welcome to New Expensify: a complete re-imagination of financial collaboration, centered around chat. Help us build the next generation of Expensify by sharing feedback and contributing to the code.
https://new.expensify.com
MIT License
3.56k stars 2.9k forks source link

[HOLD #428467] Workspace Chat - "Not Here" page displayed when invited user clicks on expense preview #48359

Open IuliiaHerets opened 2 months ago

IuliiaHerets commented 2 months ago

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 9.0.26-4 Reproducible in staging?: Y Reproducible in production?: Y Email or phone of affected tester (no customers): biruknew45+417@gmail.com Issue reported by: Applause Internal Team

Action Performed:

  1. Navigate to https://staging.new.expensify.com/
  2. Create a new workspace.
  3. Go to the workspace chat.
  4. Click on the header and invite a member (User B).
  5. Submit an expense.
  6. Log in as User B.
  7. Click on the expense preview.

Expected Result:

The invited user should be directed to the expense details page. The "Not Here" page should not appear.

Actual Result:

When clicking the expense preview, the invited user is taken to a "Not Here" page.

Workaround:

Unknown

Platforms:

Screenshots/Videos

https://github.com/user-attachments/assets/524a791d-1ac6-4183-8309-86aa90b2b97f

Bug6587859_1725030195228!1

View all open jobs on GitHub

melvin-bot[bot] commented 2 months ago

Triggered auto assignment to @puneetlath (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

IuliiaHerets commented 2 months ago

We think that this bug might be related to #wave-collect - Release 1

IuliiaHerets commented 2 months ago

@puneetlath FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

FitseTLT commented 2 months ago

This is definitely a BE issue. It sends Workspace chat report of the admin to a non-admin user so the expense displays not found because canUserAccess is false.

melvin-bot[bot] commented 2 months ago

@puneetlath Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

puneetlath commented 2 months ago

Interesting, thanks for that lead @FitseTLT. I'll look into it.

melvin-bot[bot] commented 2 months ago

@puneetlath this issue was created 2 weeks ago. Are we close to a solution? Let's make sure we're treating this as a top priority. Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!

puneetlath commented 1 month ago

Haven't had a chance to look into this yet.

puneetlath commented 1 month ago

It seems like @deetergp will likely be handling this in https://github.com/Expensify/Expensify/issues/428467

melvin-bot[bot] commented 1 week ago

This issue has not been updated in over 15 days. @puneetlath eroding to Monthly issue.

P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do!

puneetlath commented 1 week ago

Still on hold.