Closed m-natarajan closed 1 month ago
Triggered auto assignment to @bfitzexpensify (Bug
), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.
This has been labelled "Needs Reproduction". Follow the steps here: https://stackoverflowteams.com/c/expensify/questions/16989
@shawnborton the option will be bold when the report linked to it is unread. This is intentional. If I have understood the issue. 🤷
The money request participant title isn't using bold style.
The title text will be bold if the isBold
property of the item is not false.
https://github.com/Expensify/App/blob/117b96112b4b2de8ead192c9c1da619edb9860fa/src/components/SelectionList/InviteMemberListItem.tsx#L101
The isBold
logic was first added in https://github.com/Expensify/App/pull/37306 and we want all list by default has a bold text, except for LHN and chat finder page where it will be bold based on the unread status.
Previously, isBold
was only added to ChatFinderPage list, but now, we added it to all lists by adding it in getOptions
.
https://github.com/Expensify/App/blob/117b96112b4b2de8ead192c9c1da619edb9860fa/src/libs/OptionsListUtils.ts#L1968
So, all user lists will follow the LHN unread logic to bold the title, including personal details which don't have an unread status, so it will always be false. https://github.com/Expensify/App/blob/117b96112b4b2de8ead192c9c1da619edb9860fa/src/libs/OptionsListUtils.ts#L1992
We can add a new param to getOptions
called shouldBoldTitleByDefault
which has a default value of true. Then, pass it as false
from getSearchOptions
.
The new isBold
condition will be.
reportOption.isBold = shouldBoldTitleByDefault || shouldUseBoldText(reportOption);
We can do the same for the personal details, but since shouldUseBoldText
is always false for personal detail, we can just simplify the condition to:
https://github.com/Expensify/App/blob/117b96112b4b2de8ead192c9c1da619edb9860fa/src/libs/OptionsListUtils.ts#L1992
personalDetailOption.isBold = shouldBoldTitleByDefault;
Or just remove it so personal detail will always be in bold just like before in https://github.com/Expensify/App/pull/37306, even in chat finder page.
the option will be bold when the report linked to it is unread. This is intentional. If I have understood the issue. 🤷
I think this is a bug. We only want the read/unread styles to be applied when you use the Find chat page. Otherwise any time we just list out members/contacts, the names should be bold and in our normal text color. cc @Expensify/design @trjExpensify @JmillsExpensify for the gut check there.
@shawnborton definitely agree.
We only want the read/unread styles to be applied when you use the Find chat page
why do I have a recollection that we decided to not use bold for unread at all on this page, did we walk back from that? 🤔
I feel like I recall a similar conversation but I had the same exact opinion/feedback as I do today and I could have sworn we implemented it correctly, hence why I was pretty convinced this was a regression.
Job added to Upwork: https://www.upwork.com/jobs/~0159f84c9f700169cc
Triggered auto assignment to Contributor-plus team member for initial proposal review - @jayeshmangwani (External
)
@bernhardoj since we determine the bold text status from the shouldUseBoldText
fucntion's output, what do you think about making default bold text changes to the shouldUseBoldText
function?
Hmm, I think it's a bit weird to see the function accepting a boolean just to return the boolean.
function shouldUseBoldText(report, shouldBoldTitleByDefault) {
return shouldBoldTitleByDefault || (report.isUnread === true && report.notificationPreference !== CONST.REPORT.NOTIFICATION_PREFERENCE.MUTE);
}
shouldUseBoldText(report, shouldBoldTitleByDefault);
I prefer to keep shouldBoldTitleByDefault
outside the function.
I prefer to keep shouldBoldTitleByDefault outside the function.
Thanks for the explanation. I was thinking about using it in the function itself, but I also think we can keep the default bold parameter outside.
We can go with @bernhardoj 's Proposal of keeping bold text default to true and making it false for search options using the new parameter.
🎀 👀 🎀 C+ reviewed
Triggered auto assignment to @carlosmiceli, see https://stackoverflow.com/c/expensify/questions/7972 for more details.
PR is ready
cc: @jayeshmangwani
I am heading out of office until September 21st, so assigning a buddy to watch over this in my absence.
Current status: PR in review
Current assignee @bfitzexpensify is eligible for the Bug assigner, not assigning anyone new.
Triggered auto assignment to @jliexpensify (Bug
), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.
@jliexpensify Automation failed here; PR was deployed to production 4 days ago with the following checklist https://github.com/Expensify/App/issues/48664
Thanks @jayeshmangwani - will note it down!
Payment Summary
Is a checklist needed?
Is a checklist needed?
Yes, I'll complete the checklist today
Requested in ND.
Do we agree 👍 or 👎
Cheers, closing!
$250 approved for @bernhardoj
$250 approved for @jayeshmangwani
If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
Version Number: Reproducible in staging?: Needs reproduction Reproducible in production?: Needs reproduction If this was caught during regression testing, add the test name, ID and link from TestRail: Email or phone of affected tester (no customers): Logs: https://stackoverflow.com/c/expensify/questions/4856 Expensify/Expensify Issue URL: Issue reported by: @shawnborton Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1724943353451769
Action Performed:
Expected Result:
Member names in member selection views are bold and using correct text color and styles
Actual Result:
Member names in member selection views are not bold or using correct text color and styles
Workaround:
Unknown
Platforms:
Which of our officially supported platforms is this issue occurring on?
Screenshots/Videos
Add any screenshot/video evidence
View all open jobs on GitHub
Upwork Automation - Do Not Edit
Issue Owner
Current Issue Owner: @jayeshmangwani