Expensify / App

Welcome to New Expensify: a complete re-imagination of financial collaboration, centered around chat. Help us build the next generation of Expensify by sharing feedback and contributing to the code.
https://new.expensify.com
MIT License
3.52k stars 2.88k forks source link

HOLD #48400 [$250] Red dot (RBR) doesn't go away even though this split expense has been paid/settled ("paid elsewhere") by all parties #48423

Open m-natarajan opened 2 months ago

m-natarajan commented 2 months ago

If you havenโ€™t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: Reproducible in staging?: Needs Reproduction Reproducible in production?: Needs Reproduction If this was caught during regression testing, add the test name, ID and link from TestRail: Email or phone of affected tester (no customers): Logs: https://stackoverflow.com/c/expensify/questions/4856 Expensify/Expensify Issue URL: Issue reported by: @jamesdeanexpensify Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1724971827199829

Action Performed:

  1. Create a split expense in a group chat
  2. Settle the expense (Paid elsewhere) by all the members the expense was split

    Expected Result:

    No RBR in LHN

    Actual Result:

    RBR displayed in LHN and unable to dismiss it.

    Workaround:

    Can the user still use Expensify without this being fixed? Have you informed them of the workaround?

Platforms:

Which of our officially supported platforms is this issue occurring on?

Screenshots/Videos

image

Onyx Data:

{
    "chatType": "group",
    "lastActorAccountID": "1520269",
    "lastMessageText": "Yup",
    "lastVisibleActionCreated": "2024-08-28 18:45:43.504",
    "ownerAccountID": 0,
    "participants": {
        "1381556": {
            "hidden": false,
            "notificationPreference": "always",
            "role": "member"
        },
        "1520269": {
            "hidden": false,
            "notificationPreference": "always",
            "role": "member"
        },
        "4037741": {
            "hidden": false,
            "notificationPreference": "always",
            "role": "admin"
        }
    },
    "policyID": "_FAKE_",
    "reportID": "4421636436784885",
    "reportName": "",
    "stateNum": 0,
    "statusNum": 0,
    "type": "chat",
    "isEdited": true,
    "lastMessageHtml": "Yup",
    "currency": "USD",
    "description": "",
    "errorFields": {},
    "hasOutstandingChildRequest": false,
    "hasOutstandingChildTask": false,
    "isCancelledIOU": false,
    "isOwnPolicyExpenseChat": false,
    "isPinned": true,
    "isWaitingOnBankAccount": false,
    "lastActionType": "ADDCOMMENT",
    "lastReadSequenceNumber": 0,
    "lastReadTime": "2024-08-28 18:45:43.504",
    "lastVisibleActionLastModified": "2024-08-28 18:45:43.504",
    "nonReimbursableTotal": 0,
    "notificationPreference": "always",
    "oldPolicyName": "",
    "permissions": [
        "read",
        "write",
        "share"
    ],
    "private_isArchived": "",
    "total": 0,
    "unheldTotal": 0,
    "welcomeMessage": "",
    "writeCapability": "all",
    "lastMessageTranslationKey": "",
    "maxSequenceNumber": 0,
    "isLoadingPrivateNotes": false,
    "privateNotes": {
        "1520269": {
            "note": ""
        }
    },
    "managerID": 0
}

Add any screenshot/video evidence

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~021833077301118863367
  • Upwork Job ID: 1833077301118863367
  • Last Price Increase: 2024-11-04
Issue OwnerCurrent Issue Owner: @ikevin127
melvin-bot[bot] commented 2 months ago

Triggered auto assignment to @muttmuure (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

MelvinBot commented 2 months ago

This has been labelled "Needs Reproduction". Follow the steps here: https://stackoverflowteams.com/c/expensify/questions/16989

muttmuure commented 2 months ago

tomorrow

melvin-bot[bot] commented 1 month ago

Job added to Upwork: https://www.upwork.com/jobs/~021833077301118863367

melvin-bot[bot] commented 1 month ago

Triggered auto assignment to Contributor-plus team member for initial proposal review - @ikevin127 (External)

muttmuure commented 1 month ago

I think it's likely this needs to go into #newdot-quality.

Vicolas11 commented 1 month ago

Hello, has this issue been assigned to any Upwork freelancer?

melvin-bot[bot] commented 1 month ago

๐Ÿ“ฃ @Vicolas11! ๐Ÿ“ฃ Hey, it seems we donโ€™t have your contributor details yet! You'll only have to do this once, and this is how we'll hire you on Upwork. Please follow these steps:

  1. Make sure you've read and understood the contributing guidelines.
  2. Get the email address used to login to your Expensify account. If you don't already have an Expensify account, create one here. If you have multiple accounts (e.g. one for testing), please use your main account email.
  3. Get the link to your Upwork profile. It's necessary because we only pay via Upwork. You can access it by logging in, and then clicking on your name. It'll look like this. If you don't already have an account, sign up for one here.
  4. Copy the format below and paste it in a comment on this issue. Replace the placeholder text with your actual details. Screen Shot 2022-11-16 at 4 42 54 PM Format:
    Contributor details
    Your Expensify account email: <REPLACE EMAIL HERE>
    Upwork Profile Link: <REPLACE LINK HERE>
ikevin127 commented 1 month ago

Hello, has this issue been assigned to any Upwork freelancer?

Not yet, looking for proposals (if the issue is reproducible).

melvin-bot[bot] commented 1 month ago

๐Ÿ“ฃ It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? ๐Ÿ’ธ

melvin-bot[bot] commented 1 month ago

@muttmuure @ikevin127 this issue was created 2 weeks ago. Are we close to approving a proposal? If not, what's blocking us from getting this issue assigned? Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!

melvin-bot[bot] commented 1 month ago

@muttmuure, @ikevin127 Huh... This is 4 days overdue. Who can take care of this?

ikevin127 commented 1 month ago

๐Ÿ’ฐ Looking for proposals (if the issue is reproducible).

melvin-bot[bot] commented 1 month ago

@muttmuure, @ikevin127 Whoops! This issue is 2 days overdue. Let's get this updated quick!

melvin-bot[bot] commented 1 month ago

๐Ÿ“ฃ It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? ๐Ÿ’ธ

ikevin127 commented 1 month ago

@muttmuure I'd suggest to put this one on [HOLD #48400] until that one is fixed then we can re-test and look for proposals if the PR for the first one did not fix this issue.

melvin-bot[bot] commented 1 month ago

๐Ÿ“ฃ It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? ๐Ÿ’ธ

mvtglobally commented 1 month ago

Issue not reproducible during KI retests. (First week)

melvin-bot[bot] commented 1 month ago

๐Ÿ“ฃ It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? ๐Ÿ’ธ

ikevin127 commented 1 month ago

Still on hold.

melvin-bot[bot] commented 3 weeks ago

๐Ÿ“ฃ It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? ๐Ÿ’ธ

melvin-bot[bot] commented 2 weeks ago

๐Ÿ“ฃ It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? ๐Ÿ’ธ

ikevin127 commented 2 weeks ago

Not overdue, on hold.

melvin-bot[bot] commented 1 week ago

๐Ÿ“ฃ It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? ๐Ÿ’ธ

melvin-bot[bot] commented 2 days ago

๐Ÿ“ฃ It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? ๐Ÿ’ธ

ikevin127 commented 2 days ago

Coming from the HOLD issue https://github.com/Expensify/App/issues/48400#issuecomment-2390337662:

From this https://github.com/Expensify/App/issues/48400#issuecomment-2367773018, seems part of the behavior is expected. Closing it out for now, but we can re-open if it's reported again as an issue

@muttmuure I think we're good to close out this one based on the same logic / reasoning mentioned in https://github.com/Expensify/App/issues/48400#issuecomment-2367773018.