Expensify / App

Welcome to New Expensify: a complete re-imagination of financial collaboration, centered around chat. Help us build the next generation of Expensify by sharing feedback and contributing to the code.
https://new.expensify.com
MIT License
3.33k stars 2.76k forks source link

[$250] iOS - 2FA code input is hidden by keyboard when disabling 2FA #48461

Open izarutskaya opened 1 week ago

izarutskaya commented 1 week ago

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 9.0.28-0 Reproducible in staging?: Y Reproducible in production?: N Found when validation PR https://github.com/Expensify/App/pull/48030 Email or phone of affected tester (no customers): applausetester+kh010901@applause.expensifail.com Logs: https://stackoverflow.com/c/expensify/questions/4856 Issue reported by: Applause-Internal team

Action Performed:

  1. Launch New Expensify app.
  2. Go to Account settings > Security,
  3. Tap Disable 2FA.

Expected Result:

2FA code input will not be hidden by keyboard when disabling 2FA

Actual Result:

2FA code input is hidden by keyboard when disabling 2FA

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

Screenshots/Videos

https://github.com/user-attachments/assets/bb4e0e29-4a4f-497c-a57e-ab88c4b532fd

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~021831813205395072237
  • Upwork Job ID: 1831813205395072237
  • Last Price Increase: 2024-09-05
  • Automatic offers:
    • alitoshmatov | Reviewer | 103915601
Issue OwnerCurrent Issue Owner: @alitoshmatov
melvin-bot[bot] commented 1 week ago

Triggered auto assignment to @Julesssss (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

melvin-bot[bot] commented 1 week ago

Triggered auto assignment to @abekkala (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

github-actions[bot] commented 1 week ago

:wave: Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.
Julesssss commented 1 week ago

This is a new step in the process and shouldn't block deployment, as users can still enter the code (without visible confirmation).

bernhardoj commented 1 week ago

Proposal

Please re-state the problem that we are trying to solve in this issue.

2FA code is behind the keyboard.

What is the root cause of that problem?

In the code page, we disable the keyboard avoiding view which is required for iOS to push up the button. https://github.com/Expensify/App/blob/aa693719e19c468983a090e0c8a7bb2cec8ee76c/src/pages/settings/Security/TwoFactorAuth/Steps/GetCode.tsx#L29-L31

What changes do you think we should make in order to solve the problem?

Enable the keyboard avoiding view by removing the shouldEnableKeyboardAvoidingView prop.

Julesssss commented 1 week ago

In the code page, we disable the keyboard avoiding view which is required for iOS to push up the button.

It would be good to confirm there wasn't a specific reason for this before moving forward.

parasharrajat commented 1 week ago

I don't think there was a reason for this. Looks like a simple mistake.

tgolen commented 1 week ago

Ah yeah, that was just a mistake. I wasn't aware of it and it just came over with some copy/paste from one of the other views.

melvin-bot[bot] commented 1 week ago

Job added to Upwork: https://www.upwork.com/jobs/~021831813205395072237

melvin-bot[bot] commented 1 week ago

Triggered auto assignment to Contributor-plus team member for initial proposal review - @alitoshmatov (External)

ItxAltaf commented 1 week ago
<KeyboardAvoidingView
        behavior={Platform.OS === 'ios' ? 'padding' : null}
      >
<TextInput>
</KeyboardAvoidingView>
melvin-bot[bot] commented 6 days ago

@Julesssss, @abekkala, @alitoshmatov Whoops! This issue is 2 days overdue. Let's get this updated quick!

Julesssss commented 5 days ago

Awiating proposals and review

alitoshmatov commented 4 days ago

Looks straightforward fix, we can go with @bernhardoj 's proposal here

C+ reviewed 🎀 👀 🎀

melvin-bot[bot] commented 4 days ago

Current assignee @Julesssss is eligible for the choreEngineerContributorManagement assigner, not assigning anyone new.

melvin-bot[bot] commented 4 days ago

📣 @alitoshmatov 🎉 An offer has been automatically sent to your Upwork account for the Reviewer role 🎉 Thanks for contributing to the Expensify app!

Offer link Upwork job

bernhardoj commented 4 days ago

PR is ready

cc: @alitoshmatov