Open izarutskaya opened 2 weeks ago
Triggered auto assignment to @Julesssss (DeployBlockerCash
), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.
Triggered auto assignment to @abekkala (Bug
), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.
:wave: Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
This is a new step in the process and shouldn't block deployment, as users can still enter the code (without visible confirmation).
2FA code is behind the keyboard.
In the code page, we disable the keyboard avoiding view which is required for iOS to push up the button. https://github.com/Expensify/App/blob/aa693719e19c468983a090e0c8a7bb2cec8ee76c/src/pages/settings/Security/TwoFactorAuth/Steps/GetCode.tsx#L29-L31
Enable the keyboard avoiding view by removing the shouldEnableKeyboardAvoidingView
prop.
In the code page, we disable the keyboard avoiding view which is required for iOS to push up the button.
It would be good to confirm there wasn't a specific reason for this before moving forward.
I don't think there was a reason for this. Looks like a simple mistake.
Ah yeah, that was just a mistake. I wasn't aware of it and it just came over with some copy/paste from one of the other views.
Job added to Upwork: https://www.upwork.com/jobs/~021831813205395072237
Triggered auto assignment to Contributor-plus team member for initial proposal review - @alitoshmatov (External
)
<KeyboardAvoidingView
behavior={Platform.OS === 'ios' ? 'padding' : null}
>
<TextInput>
</KeyboardAvoidingView>
@Julesssss, @abekkala, @alitoshmatov Whoops! This issue is 2 days overdue. Let's get this updated quick!
Awiating proposals and review
Looks straightforward fix, we can go with @bernhardoj 's proposal here
C+ reviewed 🎀 👀 🎀
Current assignee @Julesssss is eligible for the choreEngineerContributorManagement assigner, not assigning anyone new.
📣 @alitoshmatov 🎉 An offer has been automatically sent to your Upwork account for the Reviewer role 🎉 Thanks for contributing to the Expensify app!
PR is ready
cc: @alitoshmatov
Deployed to production on 16th
If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
Version Number: 9.0.28-0 Reproducible in staging?: Y Reproducible in production?: N Found when validation PR https://github.com/Expensify/App/pull/48030 Email or phone of affected tester (no customers): applausetester+kh010901@applause.expensifail.com Logs: https://stackoverflow.com/c/expensify/questions/4856 Issue reported by: Applause-Internal team
Action Performed:
Expected Result:
2FA code input will not be hidden by keyboard when disabling 2FA
Actual Result:
2FA code input is hidden by keyboard when disabling 2FA
Workaround:
Unknown
Platforms:
Which of our officially supported platforms is this issue occurring on?
Screenshots/Videos
https://github.com/user-attachments/assets/bb4e0e29-4a4f-497c-a57e-ab88c4b532fd
View all open jobs on GitHub
Upwork Automation - Do Not Edit
Issue Owner
Current Issue Owner: @alitoshmatov