Expensify / App

Welcome to New Expensify: a complete re-imagination of financial collaboration, centered around chat. Help us build the next generation of Expensify by sharing feedback and contributing to the code.
https://new.expensify.com
MIT License
3.52k stars 2.87k forks source link

[HOLD for Payment 2024-09-18] [$125] [Search v2.1] Fix Text component styles on Android #48509

Closed luacmartins closed 1 month ago

luacmartins commented 2 months ago

Problem

Coming from this comment, the Text component is truncating text even though there's available space to display more text in it.

Solution

Fix the styles for the Text component

cc @Guccio163

Issue OwnerCurrent Issue Owner: @kadiealexander
Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~021831356735046116589
  • Upwork Job ID: 1831356735046116589
  • Last Price Increase: 2024-09-19
  • Automatic offers:
    • rayane-djouah | Contributor | 103815305
melvin-bot[bot] commented 2 months ago

Triggered auto assignment to @kadiealexander (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

melvin-bot[bot] commented 1 month ago

Job added to Upwork: https://www.upwork.com/jobs/~021831356735046116589

melvin-bot[bot] commented 1 month ago

Triggered auto assignment to Contributor-plus team member for initial proposal review - @s77rt (External)

melvin-bot[bot] commented 1 month ago

📣 @rayane-djouah 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!

Offer link Upwork job Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻 Keep in mind: Code of Conduct | Contributing 📖

melvin-bot[bot] commented 1 month ago

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

melvin-bot[bot] commented 1 month ago

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

rayane-djouah commented 1 month ago

We've addressed the above bug in a follow-up PR: https://github.com/Expensify/App/pull/48975

rayane-djouah commented 1 month ago

[!NOTE] The production deploy automation failed: This should be on [HOLD for Payment 2024-09-18] according to https://github.com/Expensify/App/issues/48954 production deploy checklist, confirmed in https://github.com/Expensify/App/issues/48954#issuecomment-2344664217

kadiealexander commented 1 month ago

@luacmartins was this a regression that would affect payment?

luacmartins commented 1 month ago

Yes

melvin-bot[bot] commented 1 month ago

Upwork job price has been updated to $125

kadiealexander commented 1 month ago

Payouts due:

Upwork job is here.

rayane-djouah commented 1 month ago

@kadiealexander - Offer accepted thanks