Expensify / App

Welcome to New Expensify: a complete re-imagination of financial collaboration, centered around chat. Help us build the next generation of Expensify by sharing feedback and contributing to the code.
https://new.expensify.com
MIT License
3.34k stars 2.77k forks source link

iOS - More features - Word is too close to the page border #48565

Open IuliiaHerets opened 2 weeks ago

IuliiaHerets commented 2 weeks ago

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 9.0.29-0 Reproducible in staging?: Y Reproducible in production?: N Email or phone of affected tester (no customers): applausetester+kh010901@applause.expensifail.com Issue reported by: Applause Internal Team

Action Performed:

Precondition:

  1. Launch New Expensify app.
  2. Go to workspace settings > More features.

Expected Result:

"Each" in More features introduction sentence will not be too close to the page border.

Actual Result:

"Each" in More features introduction sentence is too close to the page border.

This issue is also reproducible on iPhone 14 with the second smallest font size (screenshot attached).

Workaround:

Unknown

Platforms:

Screenshots/Videos

Bug6592730_1725445557531!15_Pro_Max_font_size

Bug6592730_1725445557540!iPhone_15_Pro_Max_bug Bug6592730_1725445557548!iPhone14__bug

https://github.com/user-attachments/assets/23ab1917-9df8-47d8-9253-d552861fbcb7

View all open jobs on GitHub

Issue OwnerCurrent Issue Owner: @neil-marcellini
melvin-bot[bot] commented 2 weeks ago

Triggered auto assignment to @neil-marcellini (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

melvin-bot[bot] commented 2 weeks ago

Triggered auto assignment to @RachCHopkins (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

github-actions[bot] commented 2 weeks ago

:wave: Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.
shubham1206agra commented 2 weeks ago

Offending PR https://github.com/Expensify/App/pull/48389

shubham1206agra commented 2 weeks ago

@Krishna2323 @rayane-djouah

Krishna2323 commented 2 weeks ago

thanks @shubham1206agra, I will take a look in few minutes.

rayane-djouah commented 2 weeks ago

Let’s handle this in a follow-up PR. I don’t think it’s a blocker, as the issue is minor styling and only occurs on iOS native with specific font size settings.

Krishna2323 commented 2 weeks ago

@rayane-djouah, raising PR in few minutes.

neil-marcellini commented 2 weeks ago

I agree this is not a blocker since it's a very small regression.

RachCHopkins commented 5 days ago

@neil-marcellini automation is broken - does anyone here need to be paid, or can this be closed?