Open lanitochka17 opened 1 week ago
Triggered auto assignment to @kevinksullivan (Bug
), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.
The removed member system message shows Hidden.
When we invite an unknown user, we generate a random accountID for that user and if we add and delete it while offline, we send the random accountID to the delete request. The BE will eventually invite the user and return a newly created accountID for that user. We basically trying to delete the random accountID that doesn't exist on the BE, so the new member will show again on the list and the system message show Hidden because personal detail data for the random accountID is already cleared.
We need to disable the item when it's an optimistic user, just like we did in https://github.com/Expensify/App/issues/47686. https://github.com/Expensify/App/blob/c885f96f66f4c552308fafb81b6251daf1fb4136/src/pages/RoomMembersPage.tsx#L183-L187
|| details.isOptimisticPersonalDetail
We can apply the same fix on other pages if exist.
@kevinksullivan Huh... This is 4 days overdue. Who can take care of this?
@kevinksullivan 6 days overdue. This is scarier than being forced to listen to Vogon poetry!
Job added to Upwork: https://www.upwork.com/jobs/~021834201133902466392
Triggered auto assignment to Contributor-plus team member for initial proposal review - @aimane-chnaif (External
)
Moving forward for proposal review and looping in another BZ as I'm going OOO
Triggered auto assignment to @lschurr (Bug
), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.
@bernhardoj's proposal looks good to me. 🎀👀🎀 C+ reviewed
Triggered auto assignment to @arosiclair, see https://stackoverflow.com/c/expensify/questions/7972 for more details.
PR is ready
cc: @aimane-chnaif
If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
Version Number: 9.0.29 Reproducible in staging?: Y Reproducible in production?: Y If this was caught during regression testing, add the test name, ID and link from TestRail: N/A Issue reported by: Applause - Internal Team
Action Performed:
Expected Result:
For new user, invited member is shown with email ig but removed user must not be shown as hidden.
Actual Result:
For new user, invited member is shown with email id but removed user shown as hidden
Workaround:
Unknown
Platforms:
Which of our officially supported platforms is this issue occurring on?
Screenshots/Videos
Add any screenshot/video evidence
https://github.com/user-attachments/assets/8726e780-f633-4638-8c55-ff653a59c24b
View all open jobs on GitHub
Upwork Automation - Do Not Edit
Issue Owner
Current Issue Owner: @aimane-chnaif