Expensify / App

Welcome to New Expensify: a complete re-imagination of financial collaboration, centered around chat. Help us build the next generation of Expensify by sharing feedback and contributing to the code.
https://new.expensify.com
MIT License
3.47k stars 2.82k forks source link

[$250] Sending invoice to a non-existing account sometimes sends it to a wrong email #48606

Open m-natarajan opened 1 month ago

m-natarajan commented 1 month ago

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 9.0.29-6 Reproducible in staging?: y Reproducible in production?: y If this was caught during regression testing, add the test name, ID and link from TestRail: Email or phone of affected tester (no customers): Logs: https://stackoverflow.com/c/expensify/questions/4856 Expensify/Expensify Issue URL: Issue reported by: @CyberAndrii Slack conversation: https://expensify.slack.com/archives/C01GTK53T8Q/p1725470168205369?thread_ts=1725439143.231259&cid=C01GTK53T8Q

Action Performed:

  1. Open new.expensify.com and log in
  2. Create a new workspace
  3. Send an invoice to an email that is not yet registered
  4. You may need to repeat step 3 multiple times

Expected Result:

The invoice is sent to the specified email.

Actual Result:

The invoice is sent to an unfamiliar email address.

Workaround:

unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

Screenshots/Videos

https://github.com/user-attachments/assets/2df0d082-031d-42ec-9188-92210059f246

https://github.com/user-attachments/assets/6b864436-fb11-4dab-a112-b914659ab3ae

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~021831749834722513133
  • Upwork Job ID: 1831749834722513133
  • Last Price Increase: 2024-09-19
melvin-bot[bot] commented 1 month ago

Triggered auto assignment to @sakluger (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

sakluger commented 1 month ago

This is super weird. This feels like it may be a BE issue, but I'll add the External label to start so we can get some eyes on it.

melvin-bot[bot] commented 1 month ago

Job added to Upwork: https://www.upwork.com/jobs/~021831749834722513133

melvin-bot[bot] commented 1 month ago

Triggered auto assignment to Contributor-plus team member for initial proposal review - @ahmedGaber93 (External)

melvin-bot[bot] commented 1 month ago

@sakluger, @ahmedGaber93 Huh... This is 4 days overdue. Who can take care of this?

ahmedGaber93 commented 1 month ago

Not overdue, No proposals yet.

melvin-bot[bot] commented 1 month ago

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

sakluger commented 1 month ago

@ahmedGaber93 do you have any sense if this is an external or BE issue?

ahmedGaber93 commented 1 month ago

@sakluger Yes, I think that. I see the report action invited @user to chat and the personal details for the non-exist user is created by the backend side and not set optimistically, and the frontend sending the related parameter receiverEmail: weweweweerr12@wewe.com correctly to the api/SendInvoice, and the wrong data come in api/openReport when opening the admin room report.

melvin-bot[bot] commented 3 weeks ago

@sakluger, @ahmedGaber93 Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

ahmedGaber93 commented 3 weeks ago

@sakluger bump https://github.com/Expensify/App/issues/48606#issuecomment-2347879018

sakluger commented 3 weeks ago

@ahmedGaber93 thanks for responding. Just to confirm, you are saying this is a BE issue? I couldn't tell from you response.

ahmedGaber93 commented 3 weeks ago

@sakluger Yes, this is a BE issue.

melvin-bot[bot] commented 3 weeks ago

@sakluger @ahmedGaber93 this issue was created 2 weeks ago. Are we close to approving a proposal? If not, what's blocking us from getting this issue assigned? Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!

ahmedGaber93 commented 3 weeks ago

@sakluger this is a BE issue. What's next?

melvin-bot[bot] commented 3 weeks ago

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

sakluger commented 3 weeks ago

I asked for volunteers in Slack: https://expensify.slack.com/archives/CSL3XBCCR/p1726761957350089

sakluger commented 2 weeks ago

Bumped in Slack.

sakluger commented 2 weeks ago

Thanks @madmax330 for taking a look!

melvin-bot[bot] commented 2 weeks ago

@sakluger, @madmax330, @ahmedGaber93 Whoops! This issue is 2 days overdue. Let's get this updated quick!

ahmedGaber93 commented 2 weeks ago

The issue has just moved to the internal, and we are waiting for the investigation result

sakluger commented 1 week ago

@madmax330 have you had a chance to look at this one?

madmax330 commented 1 week ago

No not yet, I will look tomorrow since I'm headed out for today

sakluger commented 1 week ago

@madmax330 any updates?

madmax330 commented 1 week ago

i looked in the code, but I didn't find anything obvious. I will have to try to reproduce it locally to see what's happening

sakluger commented 3 days ago

Hey @madmax330 have you had any more time to look into this one?