[$250] [Advanced Approval Workflows] Remove advanced approval beta, clean the logic, add explanations in comments

[blazejkustra]

We are slowly finishing the project, as the last polish PRs are getting merged we can finally remove the beta flag for advanced approvals. Apart from just removing the beta we want to clean the logic a little bit if possible and add detailed comments as per this comment.

cc @tgolen @DylanDylann

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021835694296887312745
• Upwork Job ID: 1835694296887312745
• Last Price Increase: 2024-09-16

Issue Owner

Current Issue Owner: @

[melvin-bot[bot]]

Triggered auto assignment to @alexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[DylanDylann]

@blazejkustra Please ping me when the PR is ready

[blazejkustra]

@DylanDylann PR is up, but @suneox was assigned, not sure how to proceed 😄

[DylanDylann]

@suneox Please allow me to take over this issue, I followed with this feature from scratch

cc @tgolen

[suneox]

@suneox Please allow me to take over this issue, I followed with this feature from scratch

cc @tgolen

Ah sure, I got it

[melvin-bot[bot]]

Triggered auto assignment to @roryabraham, see https://stackoverflow.com/c/expensify/questions/7972 for more details.

[roryabraham]

@tgolen reassigning to you as you reviewed the PR. Looks like all that remains here is C+ payment

[alexpensify]

Waiting for this one to go to prod and the 7 day hold before going through the payment process.

[alexpensify]

Not in Prod yet

[roryabraham]

Sorry for the confusion due to lack of deploy comments @alexpensify, we experienced some bugs with deploy refactors. The PR was deployed to prod on 2024-09-10

[alexpensify]

I based my previous comment on the state of this PR: https://github.com/Expensify/App/pull/48706. Is that the wrong one?

[roryabraham]

Yep, same one. Sorry I tacked a 0 at the end of the URL

[alexpensify]

Wow, this is the first time I don't see a production notice in a PR. I've seen automation failures for payment updates, but this one is wild. Thanks for flagging, I'll work on the payment process later today since I've already gone through my payment tasks for the day.

[melvin-bot[bot]]

Job added to Upwork: https://www.upwork.com/jobs/~021835694296887312745

[melvin-bot[bot]]

Current assignee @DylanDylann is eligible for the External assigner, not assigning anyone new.

[alexpensify]

Payouts due: 2024-09-10

• [ ] Contributor: N/A @blazejkustra payment will be handled via the vendor
• [x] Contributor+: $250 @DylanDylann

Upwork job is here.

---

@DylanDylann I sent an offer via Upwork. Please accept and I can complete the payment process. Thanks!

[DylanDylann]

@alexpensify Thanks I accepted

[alexpensify]

Closing - I completed the payment process in Upwork.