search

Expensify / App

Welcome to New Expensify: a complete re-imagination of financial collaboration, centered around chat. Help us build the next generation of Expensify by sharing feedback and contributing to the code.
https://new.expensify.com
MIT License
3.36k stars 2.78k forks source link

Split - Duplicate group is created when creating same split with different devices #48658

Closed IuliiaHerets closed 2 weeks ago

IuliiaHerets commented 3 weeks ago

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

Version Number: 9.0.29-10 Reproducible in staging?: Y Reproducible in production?: Y Email or phone of affected tester (no customers): nathanmulugetatesting+1366@gmail.com Issue reported by: Applause Internal Team

Action Performed:

  1. [Device 1] Sign in to staging.new.expensify.com and validate the email address
  2. [Device 1] Go offline
  3. [Device 2] Sign in with the same account as step 1
  4. [Device 2] Create a group with two users
  5. [Device 2] Create a split bill with the two users inside the group
  6. [Device 1] Re do step 4 and 5 but while offline
  7. [Device 1] Go online

Expected Result:

The two expenses get created and gets split among the group members, only one group gets created

Actual Result:

Duplicate group gets created but the split gets sent to the individuals successfully with the correct amount shown. When the duplicate group and chat is opened as device 1 it disappears but it doesn't disappear when viewed from device 2.

Workaround:

Unknown

Platforms:

Screenshots/Videos

https://github.com/user-attachments/assets/c48fd823-2f50-451f-bd53-4682d5049fac

View all open jobs on GitHub

melvin-bot[bot] commented 3 weeks ago

Triggered auto assignment to @zanyrenney (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

IuliiaHerets commented 3 weeks ago

@zanyrenney FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

zanyrenney commented 2 weeks ago

Seeing as we aren't prioritising split at the moment and this seems like a complex, multi-device, multi-state (online/offline) flow that would not naturally be taken by a real-user, I can going to close this for #focus.