search

Expensify / App

Welcome to New Expensify: a complete re-imagination of financial collaboration, centered around chat. Help us build the next generation of Expensify by sharing feedback and contributing to the code.
https://new.expensify.com
MIT License
3.34k stars 2.77k forks source link

Multi tags - App freezes when clicking checkbox in subtag list #48675

Closed IuliiaHerets closed 1 week ago

IuliiaHerets commented 2 weeks ago

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

Version Number: 9.0.30-4 Reproducible in staging?: Y Reproducible in production?: N Email or phone of affected tester (no customers): applausetester+kh010901@applause.expensifail.com Issue reported by: Applause Internal Team

Action Performed:

Precondition:

  1. Go to staging.new.expensify.com
  2. Go to workspace settings > Tags.
  3. Click on any main tag.
  4. Click Select all checkbox.

Expected Result:

App will not freeze.

Actual Result:

App freezes when clicking checkbox in subtag list.

Workaround:

Unknown

Platforms:

Screenshots/Videos

https://github.com/user-attachments/assets/76ba7188-5107-4f18-a22d-de6a6eb4d942

View all open jobs on GitHub

melvin-bot[bot] commented 2 weeks ago

Triggered auto assignment to @techievivek (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

melvin-bot[bot] commented 2 weeks ago

Triggered auto assignment to @slafortune (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

github-actions[bot] commented 2 weeks ago

:wave: Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.
IuliiaHerets commented 2 weeks ago

We think that this bug might be related to #wave-collect - Release 1

hoangzinh commented 2 weeks ago

This might be a regression from https://github.com/Expensify/App/pull/46788. This change caused this regression issue https://github.com/Expensify/App/blob/812fc316a007b711d62a986582d19440c2c1dad8/src/components/SelectionListWithModal/index.tsx#L26

cc @rayane-djouah @getusha

rayane-djouah commented 2 weeks ago

Thanks @hoangzinh, I will raise a follow-up PR to fix it

rayane-djouah commented 2 weeks ago

@getusha PR ready for review

melvin-bot[bot] commented 2 weeks ago

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

rayane-djouah commented 1 week ago

The fix was CPed to staging

techievivek commented 1 week ago

Closing this since it was a regression and is fixed and CPed.