[HOLD for payment 2024-09-16] Categories - Unable to select subcategory as the default spend category

[IuliiaHerets]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.0.30-7 Reproducible in staging?: Y Reproducible in production?: N Email or phone of affected tester (no customers): applausetester+kh010901@applause.expensifail.com Issue reported by: Applause Internal Team

Action Performed:

1. Go to staging.new.expensify.com
2. Go to workspace settings > Categories.
3. Add a category in X: Y format.
4. Click Settings.
5. Click on any spend category.
6. Select the subcategory (Y).

Expected Result:

Subcategory can be selected as the default spend category.

Actual Result:

Subcategory cannot be selected as the default spend category. It reverts to the previous category after selecting the subcategory.

RBR is shown next to the workspace but there is no error message after selecting the subcategory as the default category.

Workaround:

Unknown

Platforms:

• [x] Android: Native
• [x] Android: mWeb Chrome
• [x] iOS: Native
• [x] iOS: mWeb Safari
• [x] MacOS: Chrome / Safari
• [x] MacOS: Desktop

Screenshots/Videos

https://github.com/user-attachments/assets/3c331b38-4af1-47ed-978f-9b380fd0fcdc

View all open jobs on GitHub

Issue Owner

Current Issue Owner: @twisterdotcom

[melvin-bot[bot]]

Triggered auto assignment to @twisterdotcom (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[melvin-bot[bot]]

Triggered auto assignment to @lakchote (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[github-actions[bot]]

:wave: Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[twisterdotcom]

Don't need another recording to show this one. Very obvious.

8bede96a787452b4-LHR

previous exception InvalidArgumentException - fab9bc9a701be21ffce3c1fe9262a5ba ~~ exceptionMessage: 'MCC group category need to be on the policy' exceptionFile: '/git/releases/expensify.com/95742ca/lib/PolicyAPI.php' exceptionLine: '6092' exceptionCode: '402'

@lakchote is this an easy fix? Can we make it external?

[twisterdotcom]

I can't find an offending PR here tbh.

[lakchote]

The offending PR is https://github.com/Expensify/App/pull/48391 (cc @BartoszGrajdek @marcaaron)

It adds the category spend selector, without it Settings are empty which means the offending code is in the PR:

[lakchote]

CP requested here

[lakchote]

QA tests passed since CP (link).

Removing the deploy blocker label.

[melvin-bot[bot]]

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

[twisterdotcom]

Can we close this now @lakchote?

[lakchote]

Can we close this now @lakchote?

Yes, closing!

[ishpaul777]

Hey can we please reopen to process payment here for https://github.com/Expensify/App/pull/48708, cc @lakchote @twisterdotcom

[twisterdotcom]

Ah, okay. When did it hit prod?

[ishpaul777]

Deployed 9 sept. with this checklist https://github.com/Expensify/App/issues/48664, should be ready for payment

[twisterdotcom]

Payment Summary:

• @ishpaul777 paid $250 via Upworkhere (C+)

[ishpaul777]

Accepted Thanks!

[ishpaul777]

@twisterdotcom Could you please release payment https://www.upwork.com/nx/wm/workroom/38389275/overview