Expensify / App

Welcome to New Expensify: a complete re-imagination of financial collaboration, centered around chat. Help us build the next generation of Expensify by sharing feedback and contributing to the code.
https://new.expensify.com
MIT License
3.52k stars 2.87k forks source link

[Attendee Tracking] Start using the correct nameValuePairs param for Create/Edit #48692

Open Julesssss opened 2 months ago

Julesssss commented 2 months ago

The EditMoneyRequest command has now been replaced by a new UpdateMoneyRequestAttendees command.

We need to update App to use this command with the correct param names (see below). And we also need to update Web-E to expose the command and pass on the params from App. We also need to ensure recent attendee logic is passed payerAccountID from front-end

The new command requires that we pass a nameValuePairs object and not just the attendees array. To do this we will wrap theattendees object in anameValuePairs param:

{"nameValuePairs": {
    "attendees": [
        { // attendee
            "email": "jules@expensify.com",
            "displayName": "Jules",
            "avatarUrl": "https://abcd.cloudfront.net/avatar_5.png"
        },
        {  // external attendee
            "email": "tom@myspace.com",
            "displayName": "tom@myspace.com",
            "avatarUrl": "https://abcd.cloudfront.net/avatar_6.png"
        },
        {  // external attendee
            "email": "pearl",
            "displayName": "pearl",
            "avatarUrl": "https://abcd.cloudfront.net/avatar_7.png"
        },
        {  // external attendee
            "email": "+447403664666",
            "displayName": "447403664666",
            "avatarUrl": "https://abcd.cloudfront.net/avatar_8.png"
        }
    ]
}}

Requirements

_More details here in the Attendee tracking design doc._

melvin-bot[bot] commented 2 months ago

Triggered auto assignment to @miljakljajic (NewFeature), see https://stackoverflowteams.com/c/expensify/questions/14418#:~:text=BugZero%20process%20steps%20for%20feature%20requests for more details. Please add this Feature request to a GH project, as outlined in the SO.

miljakljajic commented 1 month ago

Anything you need from me on this one @Julesssss or will it all be handled internally?

Julesssss commented 1 month ago

Hey @miljakljajic, this will be handled by SWM hopefully so feel free to unassign.

miljakljajic commented 1 month ago

Thank you!

Julesssss commented 1 month ago

Blocked by this issue

Julesssss commented 3 weeks ago

Still blocked, but not for much longer.

Julesssss commented 1 week ago

Project is held