search

Expensify / App

Welcome to New Expensify: a complete re-imagination of financial collaboration, centered around chat. Help us build the next generation of Expensify by sharing feedback and contributing to the code.
https://new.expensify.com
MIT License
3.55k stars 2.89k forks source link

Update QBO/Xero connection to use standard external link pattern #48720

Open joekaufmanexpensify opened 2 months ago

joekaufmanexpensify commented 2 months ago

Problem

Coming from here, the QBO/Xero connection flows don't use the standard external linking pattern we recently decided on. This hinders a consistent product experience to the customer throughout the application.

Solution

Update the QBO/Xero connection UI use the new standard external linking pattern. This means instead of linking out to a new browser tab to connect to QBO/Xero, we'll open the QBO/Xero connection as a new small-centered window overlaying New Expensify, and display a RHP page that tells you to check your browser window, and offers the opportunity to open another connection window (if the first one didn't open), similar to what we're planning with cards.

Here's an example of what we'd be trying to do with QBO/Xero:

image

Vs what we do now:

https://github.com/user-attachments/assets/ae09e05e-9599-4c86-a1ee-d91b0314d2ac

We also decided to update the mobile view for QBO/Xero to match the stacking design we're using to link out to banks for third party direct workspace feeds, like this:

CleanShot 2024-09-12 at 15 32 04@2x

cc @Expensify/design @trjExpensify

joekaufmanexpensify commented 2 months ago

Leaving this in planning until we finish the card implementation. Will make this external then!

dubielzyk-expensify commented 2 months ago

Like this? image

Btw, this would only work on desktop right cause on mobile it has to open the link in the app of the external browser?

joekaufmanexpensify commented 2 months ago

Looks solid. Though I think we still want to show the RHP for consistency, no?

Btw, this would only work on desktop right cause on mobile it has to open the link in the app of the external browser?

Yep, this is only for web/desktop. We wouldn't change the behavior for mobile because we don't link out to the mobile browser or anything like that.

joekaufmanexpensify commented 2 months ago

There is actually a slight difference between what we were planning for cards on mobile and the accounting integration behavior here on mobile now. Discussing here.

dubielzyk-expensify commented 2 months ago

Updated mocks for desktop:

image

joekaufmanexpensify commented 2 months ago

Looks great to me!

dubielzyk-expensify commented 2 months ago

Sweet. Let me know if you need any changes down the line 👍