[$500] Hold - Approved reports change currency when owner change the approver and return it back

[IuliiaHerets]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.0.30-2 Reproducible in staging?: Y Reproducible in production?: Y If this was caught during regression testing, add the test name, ID and link from TestRail: https://expensify.testrail.io/index.php?/tests/view/4937429&group_by=cases:section_id&group_order=asc&group_id=309128 Email or phone of affected tester (no customers): gocemate+workspaceapprover177@gmail.com Issue reported by: Applause Internal Team

Action Performed:

Precondition:

1. Login as the owner of the workspace
2. Create a workspace
3. Invite the approver and employee
4. Navigate to more features
5. Enable "workflows"
6. On the "Workflow" editor - enable "Add Approvals"
7. Set the Approver account as the Approver

Steps:

1. As employee submit 2 expenses to the workspace chat ( using MKD currency for example)
2. As Approver Hold one of the expenses and fully approve the report
3. As Owner, go to Workflows> Assign yourself as Approver
4. Verify that Workspace chat disappears from Approver's LHN
5. As Owner, go to Workflows> Assign Approver as Approver again
6. As Approver, open the Workspace chat> Take a look at the currency of approved report

Expected Result:

Approved report should remains with same currency as created

Actual Result:

Approved reports change currency ( from MKD to USD) when owner change the approver and give the same role to the approver again. Issue repro for Gmail account.

Workaround:

Unknown

Platforms:

• [x] Android: Native
• [x] Android: mWeb Chrome
• [ ] iOS: Native
• [ ] iOS: mWeb Safari
• [x] MacOS: Chrome / Safari
• [ ] MacOS: Desktop

Screenshots/Videos

https://github.com/user-attachments/assets/f47bffa4-59c3-4dbf-97b0-662a35b779e8

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021833692522883497533
• Upwork Job ID: 1833692522883497533
• Last Price Increase: 2024-09-24

Issue Owner

Current Issue Owner: @paultsimura

[melvin-bot[bot]]

Triggered auto assignment to @stephanieelliott (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[IuliiaHerets]

We think that this bug might be related to #wave-collect - Release 1

[IuliiaHerets]

@stephanieelliott FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

[melvin-bot[bot]]

@stephanieelliott Whoops! This issue is 2 days overdue. Let's get this updated quick!

[stephanieelliott]

This is strange, I do thing it should be fixed.

[melvin-bot[bot]]

Job added to Upwork: https://www.upwork.com/jobs/~021833692522883497533

[melvin-bot[bot]]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @paultsimura (External)

[stephanieelliott]

Waiting on some proposals

[melvin-bot[bot]]

@paultsimura, @stephanieelliott Eep! 4 days overdue now. Issues have feelings too...

[stephanieelliott]

Upping the price on this to generate some proposals

[melvin-bot[bot]]

Upwork job price has been updated to $500

[abhinaybathina]

Hi team, I am able to reproduce this even without the need of changing the approver and I think this issue is in the backend itself. Once the report was created with a currency (let's say USD), all the expenses in that report even with other currency (let's say MKD) all these expenses gets converted into report's currency (i.e. USD). Once the expected behaviour is confirmed from the team, please let me know. I can pick this issue. Thanks!

[melvin-bot[bot]]

@paultsimura, @stephanieelliott 6 days overdue. This is scarier than being forced to listen to Vogon poetry!

[paultsimura]

Not overdue – waiting for proposals.

[melvin-bot[bot]]

@paultsimura, @stephanieelliott Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[melvin-bot[bot]]

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

[stephanieelliott]

Once the report was created with a currency (let's say USD), all the expenses in that report even with other currency (let's say MKD) all these expenses gets converted into report's currency (i.e. USD).

I thought I was having trouble reproing this and now I see why -- this is actually expected behavior for the currency to update to the report currency. Gonna close.