Open m-natarajan opened 2 weeks ago
Triggered auto assignment to @kadiealexander (Bug
), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.
@kadiealexander I report this bug so I can help take it as C+
No response when clicking back button and link on not found page
Currently, we are setting 2 functions onBackButtonPress
and onLinkPress
which are empty here
We just need to remove the 2 props onBackButtonPress
and onLinkPress
because we already have the default values here
No response when clicking back button and link on not found page
https://github.com/Expensify/App/blob/4af620b439636f714ff72a26320ed57f9d2faac3/src/pages/EditReportFieldPage.tsx#L70-L71 We assign empty functions to onBackButtonPress and onLinkPress
To fix this bug, we should simply remove the onBackButtonPress and onLinkPress props, as default values have already been set for them.
Additionally, for clarity and simplicity, I recommend removing this section entirely
And using FullPageNotFoundView as a wrapper
<FullPageNotFoundView shouldShow={!reportFieldsEnabled || !reportField || !report || isDisabled}>
This way is used widely in many other places
Job added to Upwork: https://www.upwork.com/jobs/~021832973509277607149
Triggered auto assignment to Contributor-plus team member for initial proposal review - @DylanDylann (External
)
Report field config was added in #wave-control, moving this to that project.
Triggered auto assignment to @puneetlath, see https://stackoverflow.com/c/expensify/questions/7972 for more details.
π£ @DylanDylann π An offer has been automatically sent to your Upwork account for the Reviewer role π Thanks for contributing to the Expensify app!
π£ @nkdengineer π An offer has been automatically sent to your Upwork account for the Contributor role π Thanks for contributing to the Expensify app!
Offer link Upwork job Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review π§βπ» Keep in mind: Code of Conduct | Contributing π
If you havenβt already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
Version Number: 9.0.30-15 Reproducible in staging?: Y Reproducible in production?: Y If this was caught during regression testing, add the test name, ID and link from TestRail: Email or phone of affected tester (no customers): Logs: https://stackoverflow.com/c/expensify/questions/4856 Expensify/Expensify Issue URL: Issue reported by: @dukenv0307 Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1725706526160129
Action Performed:
Expected Result:
Can click the back button and link to go back.
Actual Result:
Can't click the back button and link to go back.
Workaround:
Unknown
Platforms:
Which of our officially supported platforms is this issue occurring on?
Screenshots/Videos
https://github.com/user-attachments/assets/7df94954-4c6f-4e80-8333-a18c023baab5
https://github.com/user-attachments/assets/a6c99ba3-db1c-4854-b7f5-40d3842e9ec0
Add any screenshot/video evidence
View all open jobs on GitHub
Upwork Automation - Do Not Edit
Issue Owner
Current Issue Owner: @DylanDylann