search

Expensify / App

Welcome to New Expensify: a complete re-imagination of financial collaboration, centered around chat. Help us build the next generation of Expensify by sharing feedback and contributing to the code.
https://new.expensify.com
MIT License
3.52k stars 2.87k forks source link

Expense - Second expense shows error when submitting two expenses to workspace chat #48763

Closed IuliiaHerets closed 1 month ago

IuliiaHerets commented 1 month ago

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

Version Number: 9.0.30-15 Reproducible in staging?: Yes Reproducible in production?: No Issue reported by: Applause Internal Team

Action Performed:

  1. Go to staging.new.expensify.com
  2. Log in with a new Gmail account.
  3. On Onboarding flow, choose "Something else" and complete the flow (Important).
  4. Create a new workspace.
  5. Go to workspace chat.
  6. Submit two expenses from the main chat.
  7. Click on the expense preview.

Expected Result:

Describe what you think should've happened

Actual Result:

The second expense throws unexpected error. After dismissing the error for the second expense, the expense remains but the composer is hidden in the transaction thread.

Workaround:

Unknown

Platforms:

Screenshots/Videos

https://github.com/user-attachments/assets/e648fb44-8f5f-45ad-9e87-4116f93bac87

View all open jobs on GitHub

melvin-bot[bot] commented 1 month ago

Triggered auto assignment to @VictoriaExpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

Shahidullah-Muffakir commented 1 month ago

@IuliiaHerets I was able to reproduce the issue as described. However, I’m not sure if the video included in the OP is directly related to the issue.

IuliiaHerets commented 1 month ago

@Shahidullah-Muffakir Sorry, I attached the wrong video, fixed it now

melvin-bot[bot] commented 1 month ago

Triggered auto assignment to @madmax330 (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

github-actions[bot] commented 1 month ago

:wave: Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.
mountiny commented 1 month ago

Not and app blocker, this works when you use staging app and production be

production App and Web: https://github.com/user-attachments/assets/071f83ee-3033-4086-bd26-035dcf9afc61

Staging App and production Web:

https://github.com/user-attachments/assets/2fb6d67a-a328-4021-94a1-92f2b07cdd5c

This is the failing issue in the BE, logs:

TransactionAPI - Error thrown in requestMoney TypeError - 7efcf0a28c9b01b8efd428250568042b ~~ iouReportID: '5748743523017947' chatReportID: '2345769329381682' transactionID: '6296389466609649841' exceptionMessage: 'Report_Action_Collection::buildAction(): Argument #1 ($actionArray) must be of type array, int given, called in /git/releases/expensify.com/2accc07/lib/TransactionUtils.php on line 1237' exceptionFile: '/git/releases/expensify.com/2accc07/lib/Report/Action/Collection.php' exceptionLine: '13' exceptionCode: '0'
iwiznia commented 1 month ago

This was fixed by https://github.com/Expensify/Web-Expensify/pull/43429 and tested by @madmax330 in staging