[HOLD for payment 2024-10-10] [A/B Testing - Create Expense] Implement Create Expense Flow under hidden Beta

[grgia]

Project

https://github.com/Expensify/App/issues/47598

Proposal

https://github.com/Expensify/App/issues/47598#issuecomment-2327504535

Issue Owner

Current Issue Owner: @abekkala

[melvin-bot[bot]]

Triggered auto assignment to @slafortune (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[melvin-bot[bot]]

Triggered auto assignment to @abekkala (NewFeature), see https://stackoverflowteams.com/c/expensify/questions/14418#:~:text=BugZero%20process%20steps%20for%20feature%20requests for more details. Please add this Feature request to a GH project, as outlined in the SO.

[melvin-bot[bot]]

:warning: It looks like this issue is labelled as a New Feature but not tied to any GitHub Project. Keep in mind that all new features should be tied to GitHub Projects in order to properly track external CAP software time :warning:

[melvin-bot[bot]]

Triggered auto assignment to Design team member for new feature review - @shawnborton (NewFeature)

[fabioh8010]

Hey, I'm Fabio from Callstack, expert agency, and I would like to work on this issue.

[fabioh8010]

Update: Created a Draft PR that is still WIP.

[fabioh8010]

Update: Feature is almost ready, will test it tomorrow and take screenshoots / videos.

[fabioh8010]

Update: I had to switch to other task with higher priority, tomorrow will focus on this one to take the screenshoots / videos and open it to review.

[grgia]

Thanks for the updates @fabioh8010, let me know when your PR is ready for a test build

[fabioh8010]

@grgia I've opened the PR to review and attached videos / test steps. You'll notice that the Changed files ESLint check is failing -- I will need to convert some files to useOnyx. I will do it in the next days.

[grgia]

Update: Chatted with @fabioh8010 in the PR and we will be doing the following:

• Add the Create Option to ALL menus, not only the global create menu

[slack]

[melvin-bot[bot]]

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

[melvin-bot[bot]]

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

[melvin-bot[bot]]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot[bot]]

The solution for this issue has been :rocket: deployed to production :rocket: in version 9.0.43-6 and is now subject to a 7-day regression period :calendar:. Here is the list of pull requests that resolve this issue:

• https://github.com/Expensify/App/pull/49007

If no regressions arise, payment will be issued on 2024-10-10. :confetti_ball:

For reference, here are some details about the assignees on this issue:

• @fabioh8010 does not require payment (Contractor)

[melvin-bot[bot]]

BugZero Checklist: The PR adding this new feature has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [ ] [@fabioh8010] Please propose regression test steps to ensure the new feature will work correctly on production in further releases.
• [ ] [@abekkala] Link the GH issue for creating/updating the regression test once above steps have been agreed upon.

[abekkala]

PAYMENTS SUMMARY FOR OCT 10

• FIX: @fabioh8010 does not require payment (Contractor)
• PR REVIEW: @fedirjh [$250, if no regressions] payment via NewDot

[abekkala]

@fabioh8010, can you please propose a regression test for the one? thanks!

[melvin-bot[bot]]

Skipping the payment summary for this issue since all the assignees are employees or vendors. If this is incorrect, please manually add the payment summary SO.

[abekkala]

@fabioh8010 before I can close this can you please propose regression test steps to ensure the new feature will work correctly on production in further releases. Thanks!

[fabioh8010]

Hi @abekkala , sorry but I'm not sure if I understand what I am being asked to do. I'm employee from expert agency and this issue was for feature implementation, so I can provide test steps for the feature, is that what you need?

1. Verify you have the combinedTrackSubmit beta enabled in your account.
2. Click the FAB to open the Global Create menu, verify there is a Create expense option and there are no Track expense and Submit expense options.
3. Click the Create expense option to open the page, verify the page's title is Create expense.
4. Click the Manual tab, insert an amount and click Next to navigate to the next page. Verify the page's title is Submit expense and there is a Just track it button.
5. Click the Just track it button to navigate to the Track expense confirmation page. Verify the page's title is Track expense. Confirm and verify the expense was tracked.
6. Repeat steps 4 and 5 for Scan and Distance requests.
7. Repeat steps 4, 5 and 6 for Manual, Scan and Distance requests, but now submit the expense to someone else instead of tracking it. Verify the confirmation page's title is Submit expense.

cc @grgia

[abekkala]

yes, that's perfect @fabioh8010

[garrettmknight]

$250 approved for @fedirjh