[Native Share] Implement Native Share for Android - Githubissues

Expensify / App

Welcome to New Expensify: a complete re-imagination of financial collaboration, centered around chat. Help us build the next generation of Expensify by sharing feedback and contributing to the code.

https://new.expensify.com

MIT License

3.58k stars 2.92k forks source link

[Native Share] Implement Native Share for Android #48789

Open grgia opened 2 months ago

grgia commented 2 months ago

Description

This is a tracking issue for the Android implementation of the Native Share project. This section of the project will be handled separately but merged alongside the IOS issue.

Project

https://docs.google.com/document/d/14C1VifxvIXeyLAf0XstbC-wvyAb5SQZ0AOw0-jLRyZs/edit

Tracking

https://github.com/Expensify/App/issues/36613

Issue Owner

Current Issue Owner: @filip-solecki

melvin-bot[bot] commented 2 months ago

Triggered auto assignment to @JmillsExpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

BrtqKr commented 2 months ago

Hey, I'm from SWM, I'd like to take care of this issue.

melvin-bot[bot] commented 2 months ago

@JmillsExpensify, @grgia, @BrtqKr Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

melvin-bot[bot] commented 2 months ago

@JmillsExpensify, @grgia, @BrtqKr 6 days overdue. This is scarier than being forced to listen to Vogon poetry!

JmillsExpensify commented 2 months ago

Going through the process.

melvin-bot[bot] commented 2 months ago

@JmillsExpensify, @grgia, @BrtqKr 8 days overdue is a lot. Should this be a Weekly issue? If so, feel free to change it!

melvin-bot[bot] commented 2 months ago

@JmillsExpensify, @grgia, @BrtqKr 10 days overdue. I'm getting more depressed than Marvin.

grgia commented 2 months ago

Bumped for update / steps for unblocking permissions

BrtqKr commented 2 months ago

I am focusing on split navigation atm. I'll try to complete the flow whenever I'm done with the nav.

melvin-bot[bot] commented 2 months ago

@JmillsExpensify, @grgia, @BrtqKr Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

BrtqKr commented 2 months ago

We've split the work with @filip-solecki and he's taking care of the android atm. We're implementing both platforms in parallel

filip-solecki commented 2 months ago

Hi! Yes, I am working on this issue right now

grgia commented 2 months ago

Thanks @filip-solecki and @BrtqKr !

grgia commented 1 month ago

Hey, @filip-solecki, do you have a draft PR up for this?

filip-solecki commented 1 month ago

Yes, it was created a long time ago. I've updated it and working on it! Here it is

grgia commented 1 month ago

@filip-solecki Would you post a quick daily update in this issue 🙏

filip-solecki commented 1 month ago

Sure! Right now looks like we have probably everything done on the native side - currently I am working on saving data in Onyx and preparing screens for Sharing the image

filip-solecki commented 1 month ago

Hi! Yesterday I was working on Submit page

grgia commented 1 month ago

Thanks for the updates @filip-solecki! Do you have a rough ETA for when we'll be able to get the PR for android up?

filip-solecki commented 1 month ago

Hi! It should be ready by the end of the next week as there is a little additional native code to write. More precise info in ios issue

melvin-bot[bot] commented 1 month ago

@JmillsExpensify, @grgia, @BrtqKr, @filip-solecki Whoops! This issue is 2 days overdue. Let's get this updated quick!

grgia commented 1 month ago

@filip-solecki Could you post a current update?

melvin-bot[bot] commented 1 month ago

@JmillsExpensify, @grgia, @BrtqKr, @filip-solecki 6 days overdue. This is scarier than being forced to listen to Vogon poetry!

filip-solecki commented 1 month ago

Hi @grgia! So currently I am working on adding some additional values to native function returning shared object and I am also trying to merge these changes with current iOS branch which has most of shared JS part done

melvin-bot[bot] commented 1 month ago

@JmillsExpensify, @grgia, @BrtqKr, @filip-solecki Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

grgia commented 1 month ago

@filip-solecki mind posting a quick update here as well?

melvin-bot[bot] commented 1 month ago

@JmillsExpensify, @grgia, @BrtqKr, @filip-solecki 6 days overdue. This is scarier than being forced to listen to Vogon poetry!

filip-solecki commented 1 month ago

Hi! @Guccio163 is currently working on the shared file preview and remaining JS-related issues, while I am working on adding support for text sharing.

melvin-bot[bot] commented 3 weeks ago

@JmillsExpensify, @grgia, @BrtqKr, @filip-solecki Eep! 4 days overdue now. Issues have feelings too...

grgia commented 3 weeks ago

@filip-solecki could you give me an update on when you think we could get a draft PR up for android as well?

filip-solecki commented 3 weeks ago

Hi! Same as for iOS as this will be one PR for both platforms

Guccio163 commented 1 week ago

Hi @grgia, how do you think we should implement attachment preview section (visible with the donut below) - should it always crop to the predefined dimensions, or maybe scale to fit the whole attachment? It's quite different from Submit flow, because we have to count pdf and videos in, which display in different dynamics than Image in AttachmentView (pdfs can be scrolled and always scale to full width, videos can't be cropped).

Screenshot 2024-11-21 at 08 10 45

grgia commented 1 week ago

@Expensify/design could you help out with this question

dannymcclain commented 1 week ago

Is it possible to open the attachment modal from this share screen? Like if I tap on that donut image, do I get the attachment modal showing the whole image?

grgia commented 3 days ago

@Guccio163 @filip-solecki could you send an update on this? Also did you get a chance to check out this comment

filip-solecki commented 3 days ago

Sure, Android part is done, right now we are working on polishes for iOS as it will be included in one PR

filip-solecki commented 3 days ago

Is it possible to open the attachment modal from this share screen? Like if I tap on that donut image, do I get the attachment modal showing the whole image?

Sure it is

shawnborton commented 3 days ago

If you can open up the whole attachment in a preview modal, then maybe the easiest thing to do is reuse the attachment box we have when you go to submit an expense?

Guccio163 commented 3 days ago

I'll look closely into it, but from what I've checked it's not that straightforward, because Submit allows only images and right now the biggest problem is making it unified for images, pdfs and videos. Because we are thinking about allowing user to open fullscreen AttachmentView after clicking on the miniature, last friday I came up with an idea to not use rescaled AttachmentView in a thumbnail (which is tricky), but rather try to scale thumbnails used in chats for these types of media.

Screenshot 2024-11-26 at 13 35 42

WDYT @shawnborton ?

shawnborton commented 3 days ago

but rather try to scale thumbnails used in chats for these types of media.

That works for me, I agree we need to support multiple media formats here on the share page so however you think is best to accomplish that works for me.

dannymcclain commented 3 days ago

Yup that works for me too! That's kinda where I was going when I asked about the attachment modal. I think since you can "open" the attachment, it's much less important how we display the thumbnail.

however you think is best to accomplish that works for me

Agree with this ☝️