Expensify / App

Welcome to New Expensify: a complete re-imagination of financial collaboration, centered around chat. Help us build the next generation of Expensify by sharing feedback and contributing to the code.
https://new.expensify.com
MIT License
3.54k stars 2.89k forks source link

[$250] The report action logging the renaming of an expense report says "renamed this room". #48794

Closed m-natarajan closed 1 week ago

m-natarajan commented 2 months ago

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 9.0.31-0 Reproducible in staging?: Y Reproducible in production?: Y If this was caught during regression testing, add the test name, ID and link from TestRail: Email or phone of affected tester (no customers): Logs: https://stackoverflow.com/c/expensify/questions/4856 Expensify/Expensify Issue URL: Issue reported by: @puneetlath Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1725638589810419

Action Performed:

  1. Setup an automatic report title with the policy name in it in old dot
  2. Create a report using that old policy name
  3. The policy settings are updated to change the policy name
  4. Open the report as submitter

Expected Result:

Report name updated as per the change and report action attributes to the Admin who changed the report name

Actual Result:

The report name changes but the report action attributes the change to whoever opened the report

The report action also logs "renamed this room" which is incorrect

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

Screenshots/Videos

Full Screen #13

Add any screenshot/video evidence

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~021835684649465149612
  • Upwork Job ID: 1835684649465149612
  • Last Price Increase: 2024-10-28
Issue OwnerCurrent Issue Owner: @muttmuure
melvin-bot[bot] commented 2 months ago

Triggered auto assignment to @muttmuure (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

muttmuure commented 2 months ago

Handling tomorrow

melvin-bot[bot] commented 1 month ago

Job added to Upwork: https://www.upwork.com/jobs/~021835684649465149612

melvin-bot[bot] commented 1 month ago

Triggered auto assignment to Contributor-plus team member for initial proposal review - @Pujan92 (External)

muttmuure commented 1 month ago

Updated the actual behavior a bit

melvin-bot[bot] commented 1 month ago

@Pujan92, @muttmuure Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

muttmuure commented 1 month ago

Waiting for proposals

melvin-bot[bot] commented 1 month ago

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

melvin-bot[bot] commented 1 month ago

@Pujan92 @muttmuure this issue was created 2 weeks ago. Are we close to approving a proposal? If not, what's blocking us from getting this issue assigned? Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!

melvin-bot[bot] commented 1 month ago

@Pujan92, @muttmuure 6 days overdue. This is scarier than being forced to listen to Vogon poetry!

muttmuure commented 1 month ago

Waiting for proposals

muttmuure commented 1 month ago

Waiting for proposals

melvin-bot[bot] commented 1 month ago

@Pujan92, @muttmuure 8 days overdue is a lot. Should this be a Weekly issue? If so, feel free to change it!

wildan-m commented 1 month ago

The reproduction steps are unclear; video steps would be helpful.

melvin-bot[bot] commented 1 month ago

@Pujan92, @muttmuure 10 days overdue. Is anyone even seeing these? Hello?

melvin-bot[bot] commented 1 month ago

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

melvin-bot[bot] commented 1 month ago

This issue has not been updated in over 14 days. @Pujan92, @muttmuure eroding to Weekly issue.

melvin-bot[bot] commented 1 month ago

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

melvin-bot[bot] commented 1 month ago

@Pujan92 @muttmuure this issue is now 4 weeks old, please consider:

Thanks!

melvin-bot[bot] commented 4 weeks ago

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

muttmuure commented 3 weeks ago

Is this still happening?

muttmuure commented 3 weeks ago

Adding retest weekly label

muttmuure commented 3 weeks ago

Not overdue

melvin-bot[bot] commented 3 weeks ago

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

melvin-bot[bot] commented 2 weeks ago

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

TalhaAmjad0034 commented 1 week ago

Can't able to reproduce this with the mentioned steps, Can we get the video of reproducing steps for this one please.

melvin-bot[bot] commented 1 week ago

📣 @TalhaAmjad0034! 📣 Hey, it seems we don’t have your contributor details yet! You'll only have to do this once, and this is how we'll hire you on Upwork. Please follow these steps:

  1. Make sure you've read and understood the contributing guidelines.
  2. Get the email address used to login to your Expensify account. If you don't already have an Expensify account, create one here. If you have multiple accounts (e.g. one for testing), please use your main account email.
  3. Get the link to your Upwork profile. It's necessary because we only pay via Upwork. You can access it by logging in, and then clicking on your name. It'll look like this. If you don't already have an account, sign up for one here.
  4. Copy the format below and paste it in a comment on this issue. Replace the placeholder text with your actual details. Screen Shot 2022-11-16 at 4 42 54 PM Format:
    Contributor details
    Your Expensify account email: <REPLACE EMAIL HERE>
    Upwork Profile Link: <REPLACE LINK HERE>
TalhaAmjad0034 commented 1 week ago

Contributor details Your Expensify account email: talha.nexas1@gmail.com Upwork Profile Link: https://www.upwork.com/freelancers/~01ef23ac719a1e23e4

melvin-bot[bot] commented 1 week ago

✅ Contributor details stored successfully. Thank you for contributing to Expensify!