[WAITING ON AIMANE TO ACCEPT] Android - Rules - Custom name field is not auto-focused & Text cursor is before the input in % field

[IuliiaHerets]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.0.31-8 Reproducible in staging?: Y Reproducible in production?: N/A Email or phone of affected tester (no customers): applausetester+kh010901@applause.expensifail.com Issue reported by: Applause Internal Team

Action Performed:

1. Launch New Expensify app.
2. Go to Workspace settings > Rules.
3. Enable Custom report names.
4. Tap Custom name.
5. Note that Custom name field is not auto-focused (reproducible in all environment).
6. Return to Rules.
7. Enable Auto-approve compliant reports.
8. Tap Random report audit.
9. Might need to repeat Step 8 a few times to see that the text cursor moves to the front of percentage input (Android app only).

Expected Result:

In Step 5, Custom name field will be auto-focused. In Step 9, the text cursor will always be at the end of the input in Percentage field.

Actual Result:

In Step 5, Custom name field is not auto-focused. In Step 9, the text cursor is at the beginning of the input in Percentage field.

Workaround:

Unknown

Platforms:

• [x] Android: Native
• [ ] Android: mWeb Chrome
• [ ] iOS: Native
• [ ] iOS: mWeb Safari
• [ ] MacOS: Chrome / Safari
• [ ] MacOS: Desktop

Screenshots/Videos

https://github.com/user-attachments/assets/588be26f-d77b-4ab4-9210-2fe98d2fdc65

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021833785982984566631
• Upwork Job ID: 1833785982984566631
• Last Price Increase: 2024-09-11
• Automatic offers:
• Nodebrute | Contributor | 103942038

Issue Owner

Current Issue Owner: @aimane-chnaif

[melvin-bot[bot]]

Triggered auto assignment to @Julesssss (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[melvin-bot[bot]]

Triggered auto assignment to @jliexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[github-actions[bot]]

:wave: Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[Nodebrute]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Custom name field is not auto-focused & Text cursor is before the input in % field

What is the root cause of that problem?

We are not autofocusing this field https://github.com/Expensify/App/blob/e96b0382e602a02b00f4bb8a9aabf405eed96c76/src/pages/workspace/rules/RulesCustomNamePage.tsx#L91

What changes do you think we should make in order to solve the problem?

We can add const {inputCallbackRef} = useAutoFocusInput(); and then pass it as a ref here

What alternative solutions did you explore? (Optional)

[Julesssss]

Hi @IuliiaHerets, can I just check why this wasn't reproducible on production? Is the feature not available, or was it another reason? Thanks!

[IuliiaHerets]

Hi @Julesssss It is a new feature, so it is not available on prod, and can't check. I recorded a video for Web to show a difference between stg and prod

https://github.com/user-attachments/assets/d44f819d-446a-4525-a8ca-eab78eed740d

[Julesssss]

That's great, thank you.

[melvin-bot[bot]]

Job added to Upwork: https://www.upwork.com/jobs/~021833785982984566631

[melvin-bot[bot]]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @aimane-chnaif (External)

[aimane-chnaif]

@Nodebrute's proposal looks good. 🎀👀🎀 C+ reviewed

[melvin-bot[bot]]

Current assignee @Julesssss is eligible for the choreEngineerContributorManagement assigner, not assigning anyone new.

[melvin-bot[bot]]

📣 @Nodebrute 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!

Offer link Upwork job Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻 Keep in mind: Code of Conduct | Contributing 📖

[Nodebrute]

@Julesssss The PR was deployed to production on September 18. The payment is overdue by 2 days.

[jliexpensify]

Automation broken here, so Payment Summary

• C: @Nodebrute paid $250 via Upwork
• C+: @aimane-chnaif $250 paid $250 via Upwork (separate Upwork job cuz old one was closed)

Upwork job

[jliexpensify]

Paid and job closed. Waiting on checklist from @aimane-chnaif

[aimane-chnaif]

This is too minor to add regression test. If you disagree:

1. Go to Workspace settings > Rules
2. Enable Custom report names
3. Tap Custom name
4. Verify that Custom name field is auto-focused

[aimane-chnaif]

@jliexpensify I am still using upwork

[jliexpensify]

Hmm @aimane-chnaif we have you listed as using New Dot payments:

@aimane-chnaif - Aimane Chnaif - 2024-02-29

Is this not correct?

[aimane-chnaif]

I had chatted with @mallenexpensify about moving back to upwork

[Julesssss]

I agree there is no need for a regression test.

[jliexpensify]

New job - https://www.upwork.com/jobs/~021840690701292361406

[jliexpensify]

Offer sent to @aimane-chnaif

[jliexpensify]

@aimane-chnaif can you accept please? I am headed OOO after tomorrow so would like to pay you before I go. Cheers.

[mallenexpensify]

@aimane-chnaif can you please accept the job and reply here once you have? @jliexpensify , I can help keep track of payment when you're OOO

[jliexpensify]

Cheers @mallenexpensify - have assigned you as well!

[mallenexpensify]

@aimane-chnaif paid, payment comment above updated (stated both as 'paid' and also where they were paid 'upwork')

All set!

[aimane-chnaif]

@mallenexpensify Payment failed due to upwork bug. Can you please reopen?

[mallenexpensify]

Paid again via a Bonus on the closed contract. @aimane-chnaif , can you confirm you've received payment? Thx

[aimane-chnaif]

received payment. thanks

[mallenexpensify]

Thanks @aimane-chnaif , closing