Expensify / App

Welcome to New Expensify: a complete re-imagination of financial collaboration, centered around chat. Help us build the next generation of Expensify by sharing feedback and contributing to the code.
https://new.expensify.com
MIT License
3.47k stars 2.82k forks source link

[Search v2.2] -Message that previously had link remains in Links after removing link from the message #48910

Closed IuliiaHerets closed 3 weeks ago

IuliiaHerets commented 1 month ago

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 9.0.31-14 Reproducible in staging?: Y Reproducible in production?: N/A Email or phone of affected tester (no customers): applausetester+kh010901@applause.expensifail.com Issue reported by: Applause Internal Team

Action Performed:

  1. Go to staging.new.expensify.com
  2. Go to DM.
  3. Send a message with link.
  4. Go to Search > Chats.
  5. Go to Links.
  6. Click on the message sent in Step 3.
  7. Edit the message, remove the link and save it.
  8. Refresh Links page.

Expected Result:

The edited message should be removed from Links since the message no longer contains link.

Actual Result:

The edited message is not removed from Links after removing link from the message. Also, the (edited) label disappears from the edited message in Links tab.

Workaround:

Unknown

Platforms:

Screenshots/Videos

https://github.com/user-attachments/assets/03e91edf-ded0-493c-ac17-5471795ca408

View all open jobs on GitHub

Issue OwnerCurrent Issue Owner: @luacmartins
melvin-bot[bot] commented 1 month ago

Triggered auto assignment to @joekaufmanexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

melvin-bot[bot] commented 1 month ago

Triggered auto assignment to @tylerkaraszewski (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

github-actions[bot] commented 1 month ago

:wave: Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.
IuliiaHerets commented 1 month ago

We think that this bug might be related to #wave-control

luacmartins commented 1 month ago

I think we can demote this one. It might actually be a backend issue if the Search API is still returning the result.

luacmartins commented 1 month ago

cc @shubham1206agra

joekaufmanexpensify commented 1 month ago

Reproduced! Adding internal label for now based on @luacmartins comment above

joekaufmanexpensify commented 1 month ago

I think still pending internal prioritization

luacmartins commented 1 month ago

I got a draft PR up. Still have to look into one more edge case and add tests

joekaufmanexpensify commented 1 month ago

Sweet. TY!

joekaufmanexpensify commented 3 weeks ago

Auth PR was deployed to prod last night. Closing!