[Awaiting Payment] keep getting put into #focus mode across platforms

Expensify / App

Welcome to New Expensify: a complete re-imagination of financial collaboration, centered around chat. Help us build the next generation of Expensify by sharing feedback and contributing to the code.

https://new.expensify.com

MIT License

3.47k stars 2.82k forks source link

[Awaiting Payment] keep getting put into #focus mode across platforms #48917

Closed m-natarajan closed 4 days ago

m-natarajan commented 1 month ago

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

Version Number: 9.0.31-20 Reproducible in staging?: Y Reproducible in production?: Y If this was caught during regression testing, add the test name, ID and link from TestRail: Email or phone of affected tester (no customers): Logs: https://stackoverflow.com/c/expensify/questions/4856 Expensify/Expensify Issue URL: Issue reported by: @mallenexpensify Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1725929489084449

Action Performed:

Select preference mode as "Most recent"
Signed out of Desktop/Web
Signed in

Expected Result:

User remains in Most recent mode

Actual Result:

User forced into #focus mode

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

[ ] Android: Native
[ ] Android: mWeb Chrome
[ ] iOS: Native
[ ] iOS: mWeb Safari
[x] MacOS: Chrome / Safari
[ ] MacOS: Desktop

Screenshots/Videos

https://github.com/user-attachments/assets/7ce29dc8-396a-4715-b8cd-0fb87dd364a2

Add any screenshot/video evidence

View all open jobs on GitHub

Issue Owner

Current Issue Owner: @rushatgabhane

melvin-bot[bot] commented 1 month ago

Triggered auto assignment to @puneetlath (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

mallenexpensify commented 1 month ago

This is also happening to @rushatgabhane who commented on the Slack thread

backend bug. it keeps sending the nvp as false

The setting to mute sounds is also reset. Both have happened to me many times

melvin-bot[bot] commented 3 weeks ago

@puneetlath Huh... This is 4 days overdue. Who can take care of this?

melvin-bot[bot] commented 3 weeks ago

@puneetlath Still overdue 6 days?! Let's take care of this!

rushatgabhane commented 3 weeks ago

internal issue. please assign hot pick / internal label

🎀 👀 🎀

melvin-bot[bot] commented 3 weeks ago

Current assignee @puneetlath is eligible for the choreEngineerContributorManagement assigner, not assigning anyone new.

mallenexpensify commented 3 weeks ago

Sorry for fussing with labels and assignment. I thought it might be helpful to try to get a different engineer assigned, but that shouldn't be necessary.

puneetlath commented 3 weeks ago

@mallenexpensify I'm headed OOO for a bit and I have too many NewDot Quality issues assigned right now. I'm going to use the auto-assigner to get someone else.

melvin-bot[bot] commented 3 weeks ago

Triggered auto assignment to @MonilBhavsar (AutoAssignerNewDotQuality)

melvin-bot[bot] commented 2 weeks ago

@mallenexpensify @MonilBhavsar this issue was created 2 weeks ago. Are we close to a solution? Let's make sure we're treating this as a top priority. Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!

MonilBhavsar commented 2 weeks ago

I'll take a look today

MonilBhavsar commented 2 weeks ago

Submitted PR for review

mallenexpensify commented 2 weeks ago

@MonilBhavsar @rushatgabhane will this also fix the similar bug where Mute all sounds from Expensify is also toggled at the same time as being forced into @focus mode? ie. I have sounds muted and, when thrown into #focus mode, I also start getting notifications sounds.

rushatgabhane commented 2 weeks ago

@mallenexpensify see https://expensify.slack.com/archives/C049HHMV9SM/p1727294519198659?thread_ts=1725929489.084449&cid=C049HHMV9SM

mallenexpensify commented 2 weeks ago

Commented here, let's fix the problem of a system setting (mute sound) not being saved when signing out/in. I'm guessing we want a stand-alone issue for that, right?

MonilBhavsar commented 2 weeks ago

Yes, that's a completely different issue. Happy to be assigned to it though!

melvin-bot[bot] commented 1 week ago

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

mallenexpensify commented 1 week ago

Thx @MonilBhavsar , created an issues, assigned you and Rushat for the time being

https://github.com/Expensify/App/issues/49952

mallenexpensify commented 6 days ago

Contributor+: @rushatgabhane due $250 via NewDot

@rushatgabhane plz complete the BZ checklist. BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

[ ] [@] The PR that introduced the bug has been identified. Link to the PR:
[ ] [@] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
[ ] [@] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
[ ] [@] Determine if we should create a regression test for this bug.
[ ] [@] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
[ ] [@BZ] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

mallenexpensify commented 6 days ago

Also confirming that after signing out/in on the latest staging version of Desktop, I was not forced into #focus mode. "Mute all sounds from Expensify" was toggled though, hahahhah (that's being addressed in a separate issue... somewhere)

rushatgabhane commented 4 days ago

The PR that introduced the bug has been identified. Link to the PR: https://github.com/Expensify/App/pull/42772/files#r1794110218
The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: https://github.com/Expensify/App/pull/42772/files#r1794110218
A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: N.A.
Determine if we should create a regression test for this bug. Yes, def!

If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again

1. Have an account with at least 50 reports.
2. Switch to most recent mode from Preferences
3. Singout and Signin.
4. Verify you do not see the #focus mode prompt (Ideally the prompt should be displayed once. If you see it first time, repeat steps 2 and 3 and ensure you do not see again)
5. Verify the mode is not automatically set to #focus
6. Switch to #focus mode from Preferences
7. Singout and Signin
8. Verify the mode is not automatically set to most recent

mallenexpensify commented 4 days ago

Thx @rushatgabhane , we should be all good here. Test case

https://github.com/Expensify/Expensify/issues/434897